[MediaWiki-CodeReview] [MediaWiki r114896]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r114896 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114896 Old status: new New status: ok Commit summary for MediaWiki.r114896: adding missing newline ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r114892]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r114892 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114892 Old status: new New status: ok Commit summary for MediaWiki.r114892: s/gerrit approve/gerrit review/ ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r114891]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r114891 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114891 Old status: new New status: ok Commit summary for MediaWiki.r114891: Set svn:keywords property to Id ___ MediaWiki-CodeRevie

Re: [Wikitech-l] Wikimedia skins directory

2012-04-16 Thread Antoine Musso
K. Peachey wrote: > 1.18 shouldn't be failing anymore since reedy put a symlink in place for it. > > Ideally people would code things like that (aka stuff that isn't > actually MediaWiki) shouldn't be doing it to be dependant on MW skin > folders, eg: build their own css files, Because like this i

Re: [Wikitech-l] Wikimedia skins directory

2012-04-16 Thread K. Peachey
1.18 shouldn't be failing anymore since reedy put a symlink in place for it. Ideally people would code things like that (aka stuff that isn't actually MediaWiki) shouldn't be doing it to be dependant on MW skin folders, eg: build their own css files, Because like this is pointing out, things can c

Re: [Wikitech-l] Wikimedia skins directory

2012-04-16 Thread Ryan Kaldari
I don't think the problem is specific to the skins directory. Bits has been acting weird all day. To answer your question, I think either URL is fine. It just depends on if you want the CSS updated automatically or manually when new versions are deployed. If anyone knows otherwise, feel free to

[Wikitech-l] Wikimedia skins directory

2012-04-16 Thread MZMcBride
Hi. The URL for CSS used to be something like this: //bits.wikimedia.org/skins-1.18/monobook/main.css Now there's apparently this: //bits.wikimedia.org/skins-1.20wmf1/monobook/main.css But this also works: //bits.wikimedia.org/skins/monobook/main.css Can someone please explain which should b

[MediaWiki-CodeReview] [Wikimedia r1619]: New comment added

2012-04-16 Thread MediaWiki Mail
"Pgehres (WMF)" posted a comment on Wikimedia.r1619. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1619#c32683 Commit summary for Wikimedia.r1619: UPDATE query was missing a WHERE statement. This is causing every record in `civicrm_contribution_recur` to get a new value set for `nex

Re: [Wikitech-l] selenium browser testing proposal and prototype

2012-04-16 Thread Platonides
On 16/04/12 16:45, Chris McMahon wrote: > Cucumber adds a layer of abstraction I think is unnecessary-- these tests > are to be read by developers, many of whom will not be expert. Rspec is a > nice alternative to xUnit-style assertions, and the standard among Ruby > developers. Which seem to be

Re: [Wikitech-l] Patch for Widgets extension

2012-04-16 Thread Krenair
It doesn't look like this extension is in Git. You should be able to commit to it in Subversion. Alex On 16/04/12 21:25, Sergey Chernyshev wrote: Guys, I've updated Widgets extension to support latest version of FlaggedRevisions, but no longer have repo access as MW moved to Git. If somebod

[Wikitech-l] Patch for Widgets extension

2012-04-16 Thread Sergey Chernyshev
Guys, I've updated Widgets extension to support latest version of FlaggedRevisions, but no longer have repo access as MW moved to Git. If somebody can patch the extension for me, I'll really appreciate that - here's the diff (not much work): Index: extensions/Widgets/WidgetRenderer.php =

[MediaWiki-CodeReview] [MediaWiki r114928]: New comment added

2012-04-16 Thread MediaWiki Mail
"^demon" posted a comment on MediaWiki.r114928. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114928#c32682 Commit summary for MediaWiki.r114928: Importing https://www.mediawiki.org/wiki/Extension:AkismetKlik/source Also bringing in https://github.com/achingbrain/php5-akismet/ Need

Re: [Wikitech-l] MathJax scalable math rendering update for 1.19

2012-04-16 Thread Brion Vibber
On Mon, Apr 16, 2012 at 12:26 PM, Erik Moeller wrote: > On Wed, Mar 7, 2012 at 1:05 PM, Brion Vibber wrote: > > In the last few days I've updated the Math extension's experimental > MathJax > > support to where it can actually be enabled by individual users. If all > > goes well with review I'd

Re: [Wikitech-l] MathJax scalable math rendering update for 1.19

2012-04-16 Thread Erik Moeller
On Wed, Mar 7, 2012 at 1:05 PM, Brion Vibber wrote: > In the last few days I've updated the Math extension's experimental MathJax > support to where it can actually be enabled by individual users. If all > goes well with review I'd love to get this deployed soon so the math-heads > can turn it on

Re: [Wikitech-l] Unified login vs. unified settings

2012-04-16 Thread Platonides
On 16/04/12 02:08, Andrew Garrett wrote: > *I* rewrote the preference system, and my proposed patch for global > preferences was part of that package. It was reverted, mostly to ease > review load. I think that's pretty much what I did when I implemented it (I > had a local flag to disable global p

Re: [Wikitech-l] Welcome, Chris Steipp

2012-04-16 Thread Raylton P. Sousa
Welcome, I know you'll love it! 2012/4/16 Leslie Carr > Welcome! > > On Mon, Apr 16, 2012 at 10:32 AM, Sumana Harihareswara > wrote: > > On 04/16/2012 12:41 PM, Rob Lanphier wrote: > >> Hi everyone, > >> > >> I’d like to introduce Chris Steipp, who starts today as our Senior > >> Security Engin

Re: [Wikitech-l] Welcome, Chris Steipp

2012-04-16 Thread Leslie Carr
Welcome! On Mon, Apr 16, 2012 at 10:32 AM, Sumana Harihareswara wrote: > On 04/16/2012 12:41 PM, Rob Lanphier wrote: >> Hi everyone, >> >> I’d like to introduce Chris Steipp, who starts today as our Senior >> Security Engineer. > > Looking forward to working with you, Chris.  Welcome! > > -- > Su

[MediaWiki-CodeReview] [Wikimedia r1614]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1614 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1614 Old status: new New status: ok Commit summary for Wikimedia.r1614: Cutting over the trunk version of the standalone globalcollect adapter to prod __

[MediaWiki-CodeReview] [Wikimedia r1617]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1617 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1617 Old status: new New status: ok Commit summary for Wikimedia.r1617: Adding a required file to the standalone adapter ___ Medi

[MediaWiki-CodeReview] [Wikimedia r1616]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1616 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1616 Old status: new New status: ok Commit summary for Wikimedia.r1616: MFT r1615 ___ MediaWiki-CodeReview mailing list mediawiki

Re: [Wikitech-l] Welcome, Chris Steipp

2012-04-16 Thread Sumana Harihareswara
On 04/16/2012 12:41 PM, Rob Lanphier wrote: > Hi everyone, > > I’d like to introduce Chris Steipp, who starts today as our Senior > Security Engineer. Looking forward to working with you, Chris. Welcome! -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation __

[MediaWiki-CodeReview] [Wikimedia r1613]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1613 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1613 Old status: new New status: ok Commit summary for Wikimedia.r1613: Creating the standalone GC adapter directory for deploy _

[MediaWiki-CodeReview] [Wikimedia r1612]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1612 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1612 Old status: new New status: ok Commit summary for Wikimedia.r1612: Creating the standalone directory for deploy ___ MediaWik

[MediaWiki-CodeReview] [Wikimedia r1611]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1611 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1611 Old status: new New status: ok Commit summary for Wikimedia.r1611: MFT r1606, r1607 ___ MediaWiki-CodeReview mailing list me

[MediaWiki-CodeReview] [Wikimedia r1610]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Jpostlethwaite" changed the status of Wikimedia.r1610 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1610 Old status: new New status: ok Commit summary for Wikimedia.r1610: MFT r1606, r1607 ___ MediaWiki-CodeReview mailing list me

Re: [Wikitech-l] git-review wanting to submit lot of changes

2012-04-16 Thread Jeremy Postlethwaite
I have run into that message before: "You have more than one commit that you are about to submit." If you do not want to commit, bust still will want to save revisions of your work, then get stash is your friend. If you need to know Git very well, then this is a very helpful list of commands y

[MediaWiki-CodeReview] [MediaWiki r113415]: New comment added

2012-04-16 Thread MediaWiki Mail
"Saper" posted a comment on MediaWiki.r113415. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113415#c32681 Commit summary for MediaWiki.r113415: (bug 25095) Special:Categories doesn't show first relevant item when "from" is filled Saper's comment: Because not doing so causes bug 36

[Wikitech-l] Welcome, Chris Steipp

2012-04-16 Thread Rob Lanphier
Hi everyone, I’d like to introduce Chris Steipp, who starts today as our Senior Security Engineer.  Chris comes to us from Global Media Outreach, where he served as their CTO.  Before that, he worked at Novacoast, doing security consulting.  He went to school at Royal Hollaway in Egham, UK (just o

Re: [Wikitech-l] Unified login vs. unified settings

2012-04-16 Thread Oren Bochman
I'd love it too - but I noticed that different wikis have quite different settings due to different gadgets and extensions being available. So a good solution would have to be smart enough to accommodate this. Oren Bochman -Original Message- From: wikitech-l-boun...@lists.wikimedia.org

Re: [Wikitech-l] selenium browser testing proposal and prototype

2012-04-16 Thread Chris McMahon
On Mon, Apr 16, 2012 at 5:14 AM, Gergő Tisza wrote: > > Not sure what counts as authoritative, but there are a number of fairly > usable > PHP implementations such as php-webdriver [1] from Facebook or > phpunit-selenium > [2] from the PHPUnit framework, both of which are non-complete but very >

Re: [Wikitech-l] selenium browser testing proposal and prototype

2012-04-16 Thread Gergő Tisza
Chris McMahon wikimedia.org> writes: > As QA Lead for WMF, one of the things I want to do is to create an > institutional suite of automated cross-browser regression tests using > Selenium. I have two goals for this suite: first, to make it attractive > and convenient for the greater software t

[MediaWiki-CodeReview] [pywikipedia r10115]: Revision status changed

2012-04-16 Thread MediaWiki Mail
"Xqt" changed the status of pywikipedia.r10115 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10115 Old status: new New status: ok Commit summary for pywikipedia.r10115: Localisation updates from http://translatewiki.net. ___ Med

Re: [Wikitech-l] Too many random test wikis

2012-04-16 Thread Petr Bena
I made [[mediawiki:Test_wikis]] feel free to improve it and link to that page from everywhere possible where people might be looking for this On Mon, Apr 16, 2012 at 1:51 AM, Federico Leva (Nemo) wrote: > Just in case someone thinks otherwise, none of my doubts has been addressed. > The point is