[Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Alex Brollo
As you know, wikisource needs robust, well-defined data, and there's a strict, deep relationship between wikisource and Commons since Commons hosts images of books, in .djvu or .pdf files. Commons shares both images and contents fo information page of images, so that any wiki project can visualize

Re: [Wikitech-l] $( 'div' ) vs. $( 'div /') in coding conventions (and methods for building DOMs with jQuery)

2012-08-29 Thread Tei
I will rescue two facts listed in this thread, about using jquery and creating tags [quote][1] Basically $( 'span class=foo' ) will break completely in IE7/IE8. [quote][2] It's important to note however that IE required that input and button tags are created with a type (if they are going to

Re: [Wikitech-l] Notification bubble system

2012-08-29 Thread Raylton P. Sousa
It looks like NotifyOSD[1] and think it will work very well with echo[2]. I think an interesting thing would be the ability to position it on the screen through the preferences[3] [1]https://wiki.ubuntu.com/NotifyOSD [2]https://www.mediawiki.org/wiki/Echo_(Notifications)

[Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Antoine Musso
Hello, After much hassle with Jenkins, ant and PHPUnit, I finally managed to run an extension PHPUnit test suite under Jenkins. The winner is TitleBlacklist for which results are available via: https://integration.mediawiki.org/ci/job/Ext-TitleBlacklist/ The Jenkins job is setup to report the

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Tyler Romeo
Are there any plans to move more extensions (or at least those with unit tests) under Jenkins? Because I know one of my extension (TwoFactorAuthentication) has unit tests. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com |

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Chad
On Wed, Aug 29, 2012 at 10:18 AM, Antoine Musso hashar+...@free.fr wrote: Hello, After much hassle with Jenkins, ant and PHPUnit, I finally managed to run an extension PHPUnit test suite under Jenkins. The winner is TitleBlacklist for which results are available via:

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Antoine Musso
Le 29/08/12 16:24, Tyler Romeo a écrit : Are there any plans to move more extensions (or at least those with unit tests) under Jenkins? Because I know one of my extension (TwoFactorAuthentication) has unit tests. Ultimately, all extensions hosted on WMF git server will be integrated in

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Tyler Romeo
Ultimately, all extensions hosted on WMF git server will be integrated in Jenkins. If you get PHPUnit test, I will add a job for it as soon as the current jobs are stable enough. Awesome! *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Max Semenik
On 29.08.2012, 18:27 Chad wrote: Question: why does the config for non-extension tests attempt to load extensions? -Parser and -Misc both seem to be failing due to a broken inclusion of Wikibase. Core tests should be run without any extensions. Ideally, core tests should include as many

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Chad
On Wed, Aug 29, 2012 at 10:53 AM, Max Semenik maxsem.w...@gmail.com wrote: On 29.08.2012, 18:27 Chad wrote: Question: why does the config for non-extension tests attempt to load extensions? -Parser and -Misc both seem to be failing due to a broken inclusion of Wikibase. Core tests should be

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Jeroen De Dauw
Hey, Ultimately, all extensions hosted on WMF git server will be integrated in Jenkins. If you get PHPUnit test, I will add a job for it as soon as the current jobs are stable enough. Thanks for your work on this! :) Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil.

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Chad
On Wed, Aug 29, 2012 at 11:01 AM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, Ultimately, all extensions hosted on WMF git server will be integrated in Jenkins. If you get PHPUnit test, I will add a job for it as soon as the current jobs are stable enough. Thanks for your work on

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Derric Atzrott
Core tests should be run without any extensions. Ideally, core tests should include as many extension tests as possible to prevent core from silently breaking extensions. That's why we write tests for extensions. You could very easily write two extensions that produce conflicting

Re: [Wikitech-l] [testing] TitleBlacklist now tested under Jenkins

2012-08-29 Thread Mark Holmquist
Ultimately, all extensions hosted on WMF git server will be integrated in Jenkins. If you get PHPUnit test, I will add a job for it as soon as the current jobs are stable enough. At the risk of sounding unoriginal, _zomg this is amazing_. Thanks a bunch, Antoine! -- Mark Holmquist Contractor,

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread bawolff
On Wed, Aug 29, 2012 at 12:39 AM, Alex Brollo alex.bro...@gmail.com wrote: As you know, wikisource needs robust, well-defined data, and there's a strict, deep relationship between wikisource and Commons since Commons hosts images of books, in .djvu or .pdf files. Commons shares both images and

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Yuvi Panda
On Thu, Aug 30, 2012 at 12:25 AM, bawolff bawolff...@gmail.com wrote: You can also do this more directly using JSON with callback - Define a function foo, and put http://commons.wikimedia.org/w/api.php?action=parsepage=Main_Pageformat=jsoncallback=foo as the src of the script tag. This works

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Mark Holmquist
Has there been any discussion of CORS support in Mediawiki / WMF sites anywhere? There was some talk of it in bug 32890 [0] in UploadWizard, and I tried to throw together code for it in a patchset [1], but I didn't spend much time on it (the effort was mostly to put the code into a workable

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Chris Steipp
As mentioned in those bugs, mediawiki support a basic CORS implementation already. It looks like we haven't authorized any domain for wmf projects though. On Wed, Aug 29, 2012 at 12:03 PM, Mark Holmquist mtrac...@member.fsf.org wrote: Has there been any discussion of CORS support in Mediawiki /

[Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Chad
Hi everyone, This is something I've been meaning to bring up for some time, but have just been delaying getting it done. For a bunch of reasons, we need to look at disabling direct pushing on the master branch for all extensions in Gerrit. This doesn't affect other branches, just master. There's

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Brion Vibber
On Wed, Aug 29, 2012 at 2:55 PM, Chris Steipp cste...@wikimedia.org wrote: As mentioned in those bugs, mediawiki support a basic CORS implementation already. It looks like we haven't authorized any domain for wmf projects though. Looks like Roan is taking charge on it on bug 20814, yay. :)

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Thomas Gries
Am 29.08.2012 21:58, schrieb Chad: Hi everyone, This is something I've been meaning to bring up for some time, but have just been delaying getting it done. For a bunch of reasons, we need to look at disabling direct pushing on the master branch for all extensions in Gerrit s much

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Jack Phoenix
Chad, how will this affect my workflow? I suspect it'll complicate it further and make me do some other funky things before I can submit a change. Right now this is how I work with my extensions: (0. clone the git repo) 1. edit the code 2. commit the changes 3. push the committed

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Roan Kattouw
On Wed, Aug 29, 2012 at 12:58 PM, Chad innocentkil...@gmail.com wrote: Before I make the change though, I wanted to ask about it publicly to make sure there's no major blockers to me doing so. As long as people that were previously able to push are still able to +2 (which is probably true,

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Alex Brollo
Thanks for comments. Relationship between wikisource and Commons is very strict, and there's a large 1:1 match between structured wikisource data stored into well-formed templates (used into nsIndex and ns0) and Book template; there's too a 1:1 relationship between nsCreator into Commons and

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread bawolff
On Wed, Aug 29, 2012 at 2:24 PM, Alex Brollo alex.bro...@gmail.com wrote: Thanks for comments. [..] Thanks for API suggestion, but the question is: does it violates same origin AJAX policy? I can read anything by a bot from any project, but AJAX is great to enhance interactivity and to help

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Jeroen De Dauw
Hey, I see several workflow issues I will have if this was applied to all extensions: * Creating tags and pushing them - can this be done using gitreview? * Someone makes a pile of commits on some alternate remote or just locally and then wants to push them to the wmf hosted repo. If the stuff

Re: [Wikitech-l] Appreciation thread

2012-08-29 Thread Mark Holmquist
Even further thanks to Siebrand and Niklas for their stellar help in fixing a huge l10n regression today. The l10n folks do so much work to support so many people, and they're amazing at it. Bravo. -- Mark Holmquist Contractor, Wikimedia Foundation mtrac...@member.fsf.org

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Chad
On Wed, Aug 29, 2012 at 4:44 PM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, I see several workflow issues I will have if this was applied to all extensions: * Creating tags and pushing them - can this be done using gitreview? This is still doable via normal git commands. Nothing

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Jeroen De Dauw
Hey, Only if they're pushing to master. It would make sense to have done the work on the branch, merge it to master, and then just push the merge commit for review. Forgive my git ignorance here, but will merging this merge commit result into all original commits being in the version history,

[Wikitech-l] 5 tips to get your code reviewed faster

2012-08-29 Thread Sumana Harihareswara
Version with helpful links: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews 1) Write small commits. It's easier for other people to review small changes that only change one thing. We'd rather see five small commits than one big one. 2) Respond to test failures and feedback.

Re: [Wikitech-l] 5 tips to get your code reviewed faster

2012-08-29 Thread Thomas Gries
Am 29.08.2012 23:55, schrieb Sumana Harihareswara: Version with helpful links: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews 1) Write small commits. It's easier for other people to review small changes that only change one thing. We'd rather see five small commits than one

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Roan Kattouw
On Wed, Aug 29, 2012 at 1:55 PM, Jeroen De Dauw jeroended...@gmail.com wrote: Forgive my git ignorance here, but will merging this merge commit result into all original commits being in the version history, or will it just show as one huge change? In case of the later, I don't think this is an

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Alex Brollo
2012/8/29 bawolff bawolff...@gmail.com On Wed, Aug 29, 2012 at 2:24 PM, Alex Brollo alex.bro...@gmail.com wrote: Thanks for comments. [..] Thanks for API suggestion, but the question is: does it violates same origin AJAX policy? I can read anything by a bot from any project, but AJAX

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Alex Brollo
No it doesn't violate the same origin policy. Same origin policy only prevents reading information from other websites, it does not stop you from executing content from other websites (Which always seemed an odd distinction to me...). Thus you can use the api with a callback parameter to get

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Platonides
On 29/08/12 22:44, Jeroen De Dauw wrote: I don't see what I would gain by preventing me from doing that for my own extensions, so think extensions owners definitely should keep the right for their own extensions. At least for non-WMF extensions that is. It's a workaround for gerrit being dumb

Re: [Wikitech-l] AJAX sharing of Commons data/metadata

2012-08-29 Thread Brion Vibber
On Wed, Aug 29, 2012 at 6:03 PM, Alex Brollo alex.bro...@gmail.com wrote: Ouch this is a little bit above my skill understanding (really I discovered AJAX not far ago). . Where can I find some examples of API inter-project data exchage wth callback parameter? I.e: I'd like to get the

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Jeremy Baron
On Wed, Aug 29, 2012 at 7:55 PM, Platonides platoni...@gmail.com wrote: On 29/08/12 22:44, Jeroen De Dauw wrote: I don't see what I would gain by preventing me from doing that for my own extensions, so think extensions owners definitely should keep the right for their own extensions. At least

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Ori Livneh
On Wednesday, August 29, 2012 at 12:58 PM, Chad wrote: For a bunch of reasons, we need to look at disabling direct pushing on the master branch for all extensions in Gerrit […] Before I make the change though, I wanted to ask about it publicly to make sure there's no major blockers to me

Re: [Wikitech-l] Disabling direct pushing to master for extensions

2012-08-29 Thread Ryan Lane
For a bunch of reasons, we need to look at disabling direct pushing on the master branch for all extensions in Gerrit […] Before I make the change though, I wanted to ask about it publicly to make sure there's no major blockers to me doing so. E3 is using Phabricator for code-reviews, so