"Reedy" changed the status of MediaWiki.r104758 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104758#c32132

Old Status: ok
New Status: fixme

Commit summary for MediaWiki.r104758:

Script for cleaning up the mess left behind by bug 31576. Still haven't figured 
out what's causing this bug, but I've got it narrowed down to the job runners

Reedy's comment:

I'm not sure if this maintenance script is doing what it's supposed to be.. So 
I've just cancelled them all for the moment.

e.g. abwiki - Less than 3000 pages, just over 6000 templatelinks... Why is the 
script reporting it's processed over 800,000 pages and counting? Shouldn't it 
need to (at worst!)  refresh links on every page.

Should the setting of $processed back to an empty array be moved to the top of 
the processSynonym method? Or even move it to a class variable, so we only 
attempt to parse any page ones per wiki?

<pre>
mysql> select count(*) from page\G
*************************** 1. row ***************************
count(*): 2871
1 row in set (0.00 sec)

mysql> select count(*) from templatelinks\G
*************************** 1. row ***************************
count(*): 6046
1 row in set (0.00 sec)
</pre>

Marking fixme so it gets some attention

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to