"Catrope" changed the status of MediaWiki.r107617 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107617#c28918
Old Status: new > New Status: ok Commit summary for MediaWiki.r107617: Adding ClickTracking to Feedback Response Email links Catrope's comment: <pre> + $clickTrackingLink = $wgServer . $wgScriptPath . '/api.php?action=clicktracking&eventid=' . + wfUrlencode( $eventid ) . '&token=' . wfUrlencode( $token ); </pre> There's a simpler way to do that: <pre> $clickTrackingLink = wfAppendQuery( wfScript( 'api' ), array( 'action' => 'clicktracking', 'eventid' => $eventid, 'token' => $token ) ); </pre> <pre> + $links[$key.'Url'] = $clickTrackingLink . '&redirectto=' . wfUrlencode( $value->getLinkURL() ) . + '&namespacenumber=' . wfUrlencode( $value->getNamespace() ); </pre> You can use wfAppendQuery() here too. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
