"Catrope" changed the status of MediaWiki.r110321 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110321#c30416
Old Status: new > New Status: ok Commit summary for MediaWiki.r110321: [Xml::encodeJsVar] Use FormatJson::encode / native json_encode instead * Follows-up r110320 * XmlTest.php passes Catrope's comment: This isn't 100% equivalent, because people could pass in XmlJsCode objects hidden in a deeply nested structure (e.g. <code>Xml::encodeJsVar( array( 'foo' => new XmlJsCode( '1 + 2' ) ) )</code>. However, I've looked at the code that uses XmlJsCode (only three occurrences, all in ResourceLoader.php) and none of them use this kind of nesting, so this is fine. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
