"Krinkle" changed the status of MediaWiki.r113349 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113349#c31966
Old Status: new New Status: fixme Commit summary for MediaWiki.r113349: * Minor whitespace fix in mediawiki.language.js * Use mw.language.getData in all language js files instead of directling accessing from mw.language.data based on the fixes in r112991 Krinkle's comment: <pre> - var grammarForms = mw.language.data[ 'hu' ].get( 'grammarForms' ); + var grammarForms =mw.language.getData( 'hu', 'grammarForms' ); - var grammarForms = mw.language.data[ 'ru' ].get( 'grammarForms' ); + var grammarForms = mw.language.getData( 'ru', 'grammarForms' ); </pre> minor whitespace and indention nag. <pre> Index: branches/jsgrammar/resources/mediawiki.language/languages/bs.js — — @@ -20,8 +20,9 @@ mediaWiki.language.convertGrammar = function( word, form ) { - var grammarForms = mw.language.data[ 'bs' ].get( 'grammarForms' ); + var grammarForms = mw.language.getData( 'bs', 'grammarForms' ); if ( grammarForms && grammarForms[form] ) { + if ( grammarForms && grammarForms[form] ) { return grammarForms[form][word] ; } switch ( form ) { </pre> Duplicated if-statement, throwing exception <code>SyntaxError: Unexpected end of input</code> (marking fixme). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview