[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-18 Thread MediaWiki Mail
Duplicatebug posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32287 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Duplicatebug's comment: Where is the difference between

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-18 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32290 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: formatTimePeriod only does days... Whereas

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added, and revision status changed

2012-03-17 Thread MediaWiki Mail
Bawolff changed the status of MediaWiki.r114067 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32265 Old Status: new New Status: fixme Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32268 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: Also messages need adding to messages.inc

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32269 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: Also, decade, millennia?

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32270 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Jeroen De Dauw's comment: Was already fixed by r114071

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32271 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Jeroen De Dauw's comment: Feel free to add that.

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added, and revision status changed

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r114067 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32272 Old Status: fixme New Status: new Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32273 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: You should probably add some unit tests to go with

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32274 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: I know 365.25 is technically right, but should it

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32276 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Jeroen De Dauw's comment: Why would you not want to be

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32277 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Jeroen De Dauw's comment: Yeah, I thought about that. Is

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Bawolff posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32278 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Bawolff's comment: phase3/tests/phpunit/languages/LanguageTest.php

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32279 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: Yeah.. Bleugh. I wonder if we should add some more

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32281 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Jeroen De Dauw's comment: Could do that. Although deprecating

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32282 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Reedy's comment: Indeed. I suspect it's something that's not worth the

[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added

2012-03-17 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32283 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Jeroen De Dauw's comment: Agreed. So we need to properly fix