User "Jack Phoenix" posted a comment on MediaWiki.r80435.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80435#c16797
Commit summary:

Add new Hooks class, because $wgHooks globals are evil. 
$wgHooks['EventName'][] = $callback; --> Hooks::register( 'EventName', 
$callback );
wfRunHooks( 'EventName', array() ); --> Hooks::run( 'EventName', array() );
Tests added to complement change. Backwards compatibility added.

Comment:

I say we keep this class and deprecate $wgHooks and wfRunHooks() and remove 
them in the future (MW 1.20? 1.21?).

I'm being bold and setting the status to OK.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to