User "Reedy" changed the status of MediaWiki.r80887. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80887#c0 Commit summary: Followup r80864: DatabaseSqlite exploded on installer page because it tried to open an invalid $wgSqliteDataDir. Even though it doesn't use $server, only call open() if it's set, like in the other constructors. The amount of code duplication here is stupid. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview