[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-08 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17856 Commit summary: Type hints to substring used in integer addition Comment: I got your point. Maybe use meaningful variables instead? $hour = substr( $now, 8, 2 )

[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17767 Commit summary: Type hints to substring used in integer addition Comment: what is the hint for? Isn't PHP able to handle : 42 * 60 ?

[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17768 Commit summary: Type hints to substring used in integer addition Comment: Just more obvious ___ MediaWiki-CodeReview mailing