[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-20 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17061 Commit summary: Add check for evil, EVIL @ Comment: Here it is a list for the lazy: Problems in phase3/includes/GlobalFunctions.php: Use of @ operator in functi

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-20 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17058 Commit summary: Add check for evil, EVIL @ Comment: I use /@, and yes, it got all the @param, @return in the document blocks. So it is useless for me. (of course /[^

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-20 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17055 Commit summary: Add check for evil, EVIL @ Comment: Is it really so hard to press ctrl+F once you know the file? ___ Media

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-20 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17054 Commit summary: Add check for evil, EVIL @ Comment: So you can get a rough line number by looking backward & forward for tokens having a line number. This way you get

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-20 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17049 Commit summary: Add check for evil, EVIL @ Comment: The line number is only returned for tokens that aren't a single character. __

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-19 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17039 Commit summary: Add check for evil, EVIL @ Comment: token_get_all() returns the line number as well since PHP 5.2.2. Look at /trunk/tools/code-utils/find-long-functio

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-19 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c17030 Commit summary: Add check for evil, EVIL @ Comment: It will be much easier adding that check to check-vars than trying to get a regex for that. _

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-16 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c16951 Commit summary: Add check for evil, EVIL @ Comment: I agree with ^demon. Trying to grep for @ is a pain in the horse, except if you know which files to look for (

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-15 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r88187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c16938 Commit summary: Add check for evil, EVIL @ Comment: Line number would be hard, since the tokenizer doesn't keep track of those. I disagree that it's useless, it makes

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-15 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r88187. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88187#c16936 Commit summary: Add check for evil, EVIL @ Comment: Well it would be useful to have an hint at the function / token using the @ operator. May