User "Brion VIBBER" changed the status of MediaWiki.r90483. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r90483. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90483#c18599 Commit summary: Mark test incomplete for a legitimate reason like trying to serialize a PDO object--rather than imaginary ones such as blaming memory_limit being too low when the test was being stupid and lowering it for us. Comment: Per notes on bug 29493 it looks like the PDO objects getting serialized happens during the approximate memory usage breakdown that gets called when we find we've hit 90% of the memory limit. This allows us to get some idea of what was going on when the test went wild and blew up memory usage. Recommend a revert on this plus a fix of the memory breakdown; may also need to adjust that 50M upwards (PHP 5.2/5.3 have increased reported memory usage from older versions, and we're running a lot of stuff on 64bit I imagine which means higher memory usage for every zval). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
