User "^demon" changed the status of MediaWiki.r91597. Old Status: new New Status: fixme
User "^demon" also posted a comment on MediaWiki.r91597. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91597#c19292 Commit summary: Added sourcetracking sql file Comment: * We don't typically denote our table/column names with backticks, just use the bare name * Please put <tt>/*_*/</tt> in front of 'sourcetracking' so it respects $wgDBprefix * Rather than using PRIMARY KEY(trackingid), do this: <tt>trackingid int(11) NOT NULL AUTO_INCREMENT PRIMARY KEY</tt>. This way you can support Sqlite * Don't hardcode Engine=InnoDB and the charset, replace them with <tt>/*$wgDBTableOptions*/</tt> _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview