"Tim Starling" changed the status of MediaWiki.r95347 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95347#c28748
Old Status: new > New Status: ok Commit summary for MediaWiki.r95347: (bug 27678) * Disable offset in reallyDoQuery if search was performed. So it won't beapplied twice. * List of pages is stored in $this->searchList instead of $searchList, so it will be used in getQueryInfo method. * When no matching indexes were found the page says so, instead of displaying all indexes. * When search button was clicked twice, user was redirected to main page. * When search button was clicked twice, the previous page limit was lost. * isCacheable returns false, due to search capabilities. Patch by Beau Tim Starling's comment: It seems to me that this special page would be much easier to write if it wasn't a QueryPage subclass. It doesn't seem to be getting much value out of QueryPage, almost everything is overridden. You'd be able to avoid do-nothing queries like <pre> + // If not pages were found do not return results + $conds[] = 'false'; </pre> _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
