"Tim Starling" changed the status of MediaWiki.r95680 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95680#c27169
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r95680:
(bug 30617) inline comments forms cannot be closed
On clicking a line, a javascript insert a <tr> element containg the
form. That <tr> did not get an unique id which caused troubles when
opening multiples inline comments.
This patch forge an id based on the diff line it applies to which should
be unique since we only allow one comment form per line.
Tim Starling's comment:
htmlId is not escaped for CSS, so $( '#'+htmlId ) is not guaranteed to work.
document.getElementById() will work reliably.
Also it's not escaped for HTML, so the HTML construction needs to be something
like
<pre>
$(<td colspan="3">'
+'<textarea id="lineCommentContent" rows="5"></textarea><br/>'
+'<input id="lineCommentSend" type="button" value="Send">'
+'</td></tr>').wrap($('<tr/>').id(htmlId));
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
