Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

On Wed, May 18, 2016 at 10:41 PM, Chad wrote: > On Wed, May 18, 2016 at 8:35 AM Daniel Kinzler > wrote: > >> Am 13.05.2016 um 18:23 schrieb Greg Grossmeier: >> > >> >> Gerrit also has drafts... >> > >> > Drafts are only visible to the

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

On Wed, May 18, 2016 at 8:35 AM Daniel Kinzler wrote: > Am 13.05.2016 um 18:23 schrieb Greg Grossmeier: > > > >> Gerrit also has drafts... > > > > Drafts are only visible to the author, unfortunately. > > And anyone the author adds as a reviewer. Works nicely in my

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

Am 13.05.2016 um 18:23 schrieb Greg Grossmeier: > >> Gerrit also has drafts... > > Drafts are only visible to the author, unfortunately. And anyone the author adds as a reviewer. Works nicely in my experience. ___ Wikitech-l mailing list

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

> Gerrit also has drafts... Drafts are only visible to the author, unfortunately. But yes, that'd work, but it's also fairly drastic. And people might not know about it before they push ('git-review .') and then they can't (afaict) make their change into a draft (per

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

> . > On 12 May 2016 4:18 p.m., "Stas Malyshev" wrote: > > > > Hi! > > > > > No, -2 is restricted to project owners and thus not an op- > > > tion for the vast majority of contributors. For that pur- > > > pose, I proposed a Gerrit label "WIP" > > > (cf. >

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

Gerrit also has drafts... On 13 May 2016 at 01:56, Jon Robson wrote: > . > On 12 May 2016 4:18 p.m., "Stas Malyshev" wrote: > > > > Hi! > > > > > No, -2 is restricted to project owners and thus not an op- > > > tion for the vast majority of

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

. On 12 May 2016 4:18 p.m., "Stas Malyshev" wrote: > > Hi! > > > No, -2 is restricted to project owners and thus not an op- > > tion for the vast majority of contributors. For that pur- > > pose, I proposed a Gerrit label "WIP" > > (cf.

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

Hi! > No, -2 is restricted to project owners and thus not an op- > tion for the vast majority of contributors. For that pur- > pose, I proposed a Gerrit label "WIP" > (cf. > http://permalink.gmane.org/gmane.science.linguistics.wikipedia.technical/84068). This looks like a nice solution. --

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

Jon Robson wrote: > Gerrit is commonly used as a place to share works in progress early. > This is great, but it has an unfortunate side effect of making it > harder for would-be reviewers to find patches that need reviewing > using this query: >

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

Oh good point, you are correct, at least it would seem that way. I only have the option to -1 and +1 on operations/puppet, no -2 On Thu, May 12, 2016 at 5:12 PM, Alex Monk wrote: > On 12 May 2016 at 22:26, Jon Robson wrote: > > > Could I ask that as a

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

We definitely need consistency for any convention like this to be useful. Phabricator has the equivalent of self-2 in Differential: `arc diff --plan-changes` It's a good convention, and I will try to adhere to the self-2 in addition to added WIP in the commit subject. On Thu, May 12, 2016 at

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

On 12 May 2016 at 22:26, Jon Robson wrote: > Could I ask that as a norm, if you post a WIP patch that you also self -2 > it? > I think you can only -2 if you have the rights necessary to +2? ___ Wikitech-l mailing list

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

I didn't know you could search message. Thanks. Even so.. the crux of what I'm asking for is a reliable way to filter these out. Even with the search you gave me I see "DONOTSUBMIT" in certain messages :) On Thu, May 12, 2016 at 2:29 PM, James Forrester wrote: > On 12

Re: [Wikitech-l] Best practice for WIP patches to help code review office hours

On 12 May 2016 at 14:26, Jon Robson wrote: > Gerrit is commonly used as a place to share works in progress early. > > This is great, but it has an unfortunate side effect of making it > harder for would-be reviewers to find patches that need reviewing > using this query: > >

[Wikitech-l] Best practice for WIP patches to help code review office hours

Gerrit is commonly used as a place to share works in progress early. This is great, but it has an unfortunate side effect of making it harder for would-be reviewers to find patches that need reviewing using this query: