On Thu, Apr 5, 2012 at 11:37 AM, Platonides wrote:
> On 05/04/12 20:23, Roan Kattouw wrote:
> > This only happens if you click "Publish and Submit", which means "publish
> > my comments and attempt to merge the commit". This fails because there is
> > no Verified +1 review, so the commit doesn't
On 05/04/12 20:23, Roan Kattouw wrote:
> This only happens if you click "Publish and Submit", which means "publish
> my comments and attempt to merge the commit". This fails because there is
> no Verified +1 review, so the commit doesn't satisfy the criteria for
> merging. If you click "Publish com
On Thu, Apr 5, 2012 at 11:20 AM, Platonides wrote:
> If you submit a code review for a changeset and not a verification
> status (only if it is not verified?), it throws you an error:
> > Application Error
> > Server Error
> > Requires Verified
>
> I suspect it's a bug and we should ignore it but
On Thu, Apr 5, 2012 at 2:20 PM, Platonides wrote:
> If you submit a code review for a changeset and not a verification
> status (only if it is not verified?), it throws you an error:
>> Application Error
>> Server Error
>> Requires Verified
>
> I suspect it's a bug and we should ignore it but, can
If you submit a code review for a changeset and not a verification
status (only if it is not verified?), it throws you an error:
> Application Error
> Server Error
> Requires Verified
I suspect it's a bug and we should ignore it but, can we get rid of it?
We don't want changesets dummily marked as
On Thu, Apr 5, 2012 at 4:04 AM, Happy Melon wrote:
> So basically, in Gerrit, (1 + 1 != 2)...?? :-)
>
> ...and that's exactly why I said that "+2" is a confusingly named concept
in my previous message.
Roan
___
Wikitech-l mailing list
Wikitech-l@lists.
On 5 April 2012 11:43, Antoine Musso wrote:
> Le 04/04/12 22:56, Roan Kattouw a écrit :
>
> >> What that means, is that a change could look fine (Verified + CR) and
> >> thus be merged by accident if someone with the correct right click the
> >> 'Submit Patch Set 1' button :-D
> >>
> >> No, that
Le 04/04/12 22:56, Roan Kattouw a écrit :
>> What that means, is that a change could look fine (Verified + CR) and
>> thus be merged by accident if someone with the correct right click the
>> 'Submit Patch Set 1' button :-D
>>
>> No, that's not true. A change requires Code Review +2 before it can
On Wed, Apr 4, 2012 at 11:55 AM, Antoine Musso wrote:
> Dear Gerrit users,
>
> Gerrit let us flag changes with two fields:
>
> - Code Review
> - Verified
>
> Anyone is allowed to +1/-1 the Code Review field but only a few people
> are allowed to mark a change as Verified.
> I have bring back Je
Dear Gerrit users,
Gerrit let us flag changes with two fields:
- Code Review
- Verified
Anyone is allowed to +1/-1 the Code Review field but only a few people
are allowed to mark a change as Verified.
I have bring back Jenkins in action and it is now running tests for us,
whenever a test suite
10 matches
Mail list logo
