On Thu, Sep 20, 2012 at 2:08 PM, Mark Holmquist wrote:
> Hm. Will this be file-level whitelisting (i.e., "this file changed from the
> master branch in this patchset, so we'll show the changes") or is it
> line-level? If the latter, how? Because I'm not sure it's trivial
>
I believe it's file-
- Gerrit won't perform the rebase if it's not necessary
Cool! I think the only reason this will be better is "reduced number of
patchsets", but that's a good thing nevertheless.
- Changes as a result of a rebase aren't shown in the changes list when
comparing to an old patchset
Hm. Will
On Thu, Sep 20, 2012 at 3:42 PM, Mark Holmquist wrote:
>> * Changes and rebases are combined.
>
>
> It should be said, this is part of the recent "five tips to get your code
> reviewed faster". You should never combine a rebase with an actual
> substantial change, because it makes it very hard to
* Changes and rebases are combined.
It should be said, this is part of the recent "five tips to get your
code reviewed faster". You should never combine a rebase with an actual
substantial change, because it makes it very hard to compare between
patchsets. (I didn't see this in the "quick tip
Niklas, Aaron S., Siebrand, Santhosh, Amir, Alolita had a discussion
about code review. Here are the notes. It might repeat some things
Sumana sent earlier and you might not agree on everything.
Problems:
* Having tags in Gerrit would be nice. Commit summary lines are
sometimes abused for this.
*
