Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-27 Thread Daniel Zahn
On Wed, Apr 25, 2012 at 4:30 AM, Erik Moeller wrote: > Take a look at http://wikitech.wikimedia.org/view/Server_admin_log to > see an example of a mix wikitech has interwiki prefixes including: bugs or (bugzilla) and RT so when logging to SAL from IRC you can directly use something like [[RT:123

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-26 Thread Platonides
On 25/04/12 23:37, Krinkle wrote: > == Gerrit change numbers == > - Specific to gerrit, requires gerrit to get/resolve them (might become > problematic in long-term if we drop gerrit) > - Not usable in git cli > * One id per change set, not per patch/commit/amend > + Easy to link in bugzilla ("ger

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-25 Thread Krinkle
Also note that there are 2 kinds of SHA-1 hashes, there is the Change-ID sha-1 hash of the merge request that is pushed to gerrit (afaik stays persisent after amending patches), and then there is the sha-1 hash of the commit itself into the repository. Quick overview of my observations: == Ger

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-25 Thread Antoine Musso
Le 24/04/12 21:00, Erik Moeller wrote: > One proposal: > - Gerrit URLs for links on Bugzilla, links on wikis, follow-up to > un-merged commits > - Commit SHA-1s for deployment log entries and follow-ups to merged commits Hi, That is more or less what I have empirically adopted. Gerrit change numb

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-25 Thread Chad
On Tue, Apr 24, 2012 at 3:00 PM, Erik Moeller wrote: > I'm personally not a fan of the Gerrit change-IDs in plain form, > because I can't use them with commands like 'git log' or 'git show' > without grepping through commit messages. They tie us pretty heavily > to Gerrit as the gateway to all inf

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-25 Thread Greg Sabino Mullane
Wikitech-l Digest, Vol 105, Issue 105 Reply-To: In-Reply-To: X-PGP-Key: http://www.gtsm.com/Greg_Sabino_Mullane.key.html Erik Moeller asked: > can we agree on how we want to identify changes ... > One proposal: > - Gerrit URLs for links on Bugzilla, links on wikis, follow-up to > un-merged commi

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-24 Thread Patrick Reilly
On Tue, Apr 24, 2012 at 12:00 PM, Erik Moeller wrote: > Hi all, > > can we agree on how we want to identify changes > > - when deploying code > - when merging follow-ups > - when commenting on bugzilla? > > Take a look at http://wikitech.wikimedia.org/view/Server_admin_log to > see an example of a

[Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-24 Thread Erik Moeller
Hi all, can we agree on how we want to identify changes - when deploying code - when merging follow-ups - when commenting on bugzilla? Take a look at http://wikitech.wikimedia.org/view/Server_admin_log to see an example of a mix between Gerrit legacy change IDs (integers, as URLs) and commit IDs