Hello,
I would consider https://bugzilla.wikimedia.org/show_bug.cgi?id=40653
(filed by Daniel Kinzler after one of my comments) as a blocker for this merge.
Also Nikerabbit's comments in
https://gerrit.wikimedia.org/r/#/c/25736/1/includes/Content.php
lines 222 and following would be great to fix
Hi everyone,
We now at around the time that we planned to merge the ContentHandler branch in.
Questions:
* Daniel/others: have you submitted a merge commit for this? If not,
do you need help/clarification, or do you have it?
* People who reviewed Denny's faux commit[1] and left comments. Any
That moment of suspense before a big branch merge...
*--*
*Tyler Romeo*
Stevens Institute of Technology, Class of 2015
Major in Computer Science
www.whizkidztech.com | tylerro...@gmail.com
On Tue, Oct 2, 2012 at 9:07 PM, Rob Lanphier ro...@wikimedia.org wrote:
Hi everyone,
We now at around
Hi,
I have tried to create one changeset with the whole content handler
for your convenience:
https://gerrit.wikimedia.org/r/#/c/25736/
Note that is based on 7ccc77a and needs to get rebased before merge,
but the major parts should be there.
Since I am not a Git expert, I may have mad it all
Thanks Denny. This is pretty helpful for looking at the exact changes being
made.
*--*
*Tyler Romeo*
Stevens Institute of Technology, Class of 2015
Major in Computer Science
www.whizkidztech.com | tylerro...@gmail.com
On Sat, Sep 29, 2012 at 6:46 AM, Denny Vrandečić
On Sep 25, 2012 12:15 PM, IAlex ialex.w...@gmail.com wrote:
Would it be possible to have the whole changes as an changeset on Gerrit?
This would make review and comments much easier than having to do this on
this list.
Yes and no. The person that merges the branch can create a merge commit and
On Thu, Sep 27, 2012 at 10:54 AM, Roan Kattouw roan.katt...@gmail.com wrote:
Yes and no. The person that merges the branch can create a merge commit and
submit that for review (git checkout -b mergewikidata master git merge
wikidata git review) but Gerrit will not show the diff properly:
Hi everyone,
Assuming no one finds any substantive issues, we plan on merging the
ContentHandler feature (Wikidata branch) early next week, in time for
1.20wmf14 (assuming we're still calling this the 1.20 series then).
The tracking bug for that is here:
Hello,
Would it be possible to have the whole changes as an changeset on Gerrit?
This would make review and comments much easier than having to do this on this
list.
Cheers!
Alexandre Emsenhuber (ialex)
Le 25 sept. 2012 à 19:16, Rob Lanphier a écrit :
Hi everyone,
Assuming no one finds
On Tue, Sep 25, 2012 at 7:14 PM, IAlex ialex.w...@gmail.com wrote:
Would it be possible to have the whole changes as an changeset on Gerrit?
This would make review and comments much easier than having to do this on
this list.
is
I think it would be nice to have a changeset in Gerrit showing the actual
merge. I'm not sure how this would be possible with Gerrit, but it would
definitely be useful as a final review (and for QA purposes).
*--*
*Tyler Romeo*
Stevens Institute of Technology, Class of 2015
Major in Computer
Hello,
Having to dispatch comments over hunderds of commits is probably not the best
idea,
since I'm sure some of them will get lost. I would prefer having a central to
do this instead.
Cheers!
Alexandre Emsenhuber (ialex)
Le 25 sept. 2012 à 21:20, Jeremy Baron a écrit :
On Tue, Sep 25,
12 matches
Mail list logo
