Am 29.08.2012 21:58, schrieb Chad:
Hi everyone,
This is something I've been meaning to bring up for some time, but have
just been delaying getting it done. For a bunch of reasons, we need to
look at disabling direct pushing on the master branch for all extensions in
Gerrit. This doesn't
On Wed, Aug 29, 2012 at 10:12 PM, Ryan Lane rlan...@gmail.com wrote:
For a bunch of reasons, we need to look at disabling direct pushing
on the master branch for all extensions in Gerrit […] Before I make
the change though, I wanted to ask about it publicly to make sure
there's no major
Hi everyone,
This is something I've been meaning to bring up for some time, but have
just been delaying getting it done. For a bunch of reasons, we need to
look at disabling direct pushing on the master branch for all extensions in
Gerrit. This doesn't affect other branches, just master. There's
Am 29.08.2012 21:58, schrieb Chad:
Hi everyone,
This is something I've been meaning to bring up for some time, but have
just been delaying getting it done. For a bunch of reasons, we need to
look at disabling direct pushing on the master branch for all extensions in
Gerrit
s much
Chad,
how will this affect my workflow? I suspect it'll complicate it further and
make me do some other funky things before I can submit a change. Right now
this is how I work with my extensions:
(0. clone the git repo)
1. edit the code
2. commit the changes
3. push the committed
On Wed, Aug 29, 2012 at 12:58 PM, Chad innocentkil...@gmail.com wrote:
Before I make the change though, I
wanted to ask about it publicly to make sure there's no major blockers
to me doing so.
As long as people that were previously able to push are still able to
+2 (which is probably true,
Hey,
I see several workflow issues I will have if this was applied to all
extensions:
* Creating tags and pushing them - can this be done using gitreview?
* Someone makes a pile of commits on some alternate remote or just locally
and then wants to push them to the wmf hosted repo. If the stuff
On Wed, Aug 29, 2012 at 4:44 PM, Jeroen De Dauw jeroended...@gmail.com wrote:
Hey,
I see several workflow issues I will have if this was applied to all
extensions:
* Creating tags and pushing them - can this be done using gitreview?
This is still doable via normal git commands. Nothing
Hey,
Only if they're pushing to master. It would make sense to have done
the work on the branch, merge it to master, and then just push the
merge commit for review.
Forgive my git ignorance here, but will merging this merge commit result
into all original commits being in the version history,
On Wed, Aug 29, 2012 at 1:55 PM, Jeroen De Dauw jeroended...@gmail.com wrote:
Forgive my git ignorance here, but will merging this merge commit result
into all original commits being in the version history, or will it just
show as one huge change? In case of the later, I don't think this is an
On 29/08/12 22:44, Jeroen De Dauw wrote:
I don't see what I would gain by preventing me from doing
that for my own extensions, so think extensions owners definitely should
keep the right for their own extensions. At least for non-WMF extensions
that is.
It's a workaround for gerrit being dumb
On Wed, Aug 29, 2012 at 7:55 PM, Platonides platoni...@gmail.com wrote:
On 29/08/12 22:44, Jeroen De Dauw wrote:
I don't see what I would gain by preventing me from doing
that for my own extensions, so think extensions owners definitely should
keep the right for their own extensions. At least
On Wednesday, August 29, 2012 at 12:58 PM, Chad wrote:
For a bunch of reasons, we need to look at disabling direct pushing
on the master branch for all extensions in Gerrit […] Before I make
the change though, I wanted to ask about it publicly to make sure
there's no major blockers to me
For a bunch of reasons, we need to look at disabling direct pushing
on the master branch for all extensions in Gerrit […] Before I make
the change though, I wanted to ask about it publicly to make sure
there's no major blockers to me doing so.
E3 is using Phabricator for code-reviews, so
14 matches
Mail list logo