Hi.
I'm concerned that Gerrit actively discourages discussion currently. I see
a few issues:
* auto-collapsing all comments except the most recent;
* no reply feature or support for quoting (similar to what Bugzilla uses);
and
* the "add comment" feature doesn't allow you to write a comment while
You are definitely not the only one who finds these issues annoying. I too
worry about the same.
~Matt Walker
Wikimedia Foundation
Fundraising Technology Team
On Mon, Apr 1, 2013 at 7:39 PM, MZMcBride wrote:
> Hi.
>
> I'm concerned that Gerrit actively discourages discussion currently. I see
>
On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker wrote:
> You are definitely not the only one who finds these issues annoying. I too
> worry about the same.
+1
Another big one is "(1 comment)" which gives no information about the
comment or where it was made and no easy way to jump straight to it.
On 2013-04-02 12:32 AM, "Jeremy Baron" wrote:
>
> On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker
wrote:
> > You are definitely not the only one who finds these issues annoying. I
too
> > worry about the same.
>
> +1
>
> Another big one is "(1 comment)" which gives no information about the
> comme
On 02/04/13 06:43, Brian Wolff wrote:
On 2013-04-02 12:32 AM, "Jeremy Baron" wrote:
On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker
wrote:
You are definitely not the only one who finds these issues annoying. I
too
worry about the same.
+1
Another big one is "(1 comment)" which gives no in
Thanks for bringing this up MZ. I completely agree with you. The amount of
times I've had to link people on irc to a comment to see it is ridiculous.
I'm not sure what the exact solution is but I feel we need to improve it in
gerrit itself rather than move to bugzilla.
On Mon, Apr 1, 2013 at 7:3
Le 02/04/13 04:39, MZMcBride a écrit :
> I'm concerned that Gerrit actively discourages discussion currently.
So do not use it? We have lists, wiki and private emails.
> I see a few issues:
>
> * auto-collapsing all comments except the most recent;
> * no reply feature or support for quoting (si
On Tue, Apr 2, 2013 at 5:46 PM, Antoine Musso wrote:
>
> Le 02/04/13 04:39, MZMcBride a écrit :
> > I'm concerned that Gerrit actively discourages discussion currently.
>
> So do not use it? We have lists, wiki and private emails.
Private email would be even worse... I'm surprised you even though
Hi,
while I do not want to discourage discussion of those items on
wikitech-l, I nevertheless filed them in bugzilla, so we can keep
track of the issues / solutions.
On Mon, Apr 01, 2013 at 10:39:50PM -0400, MZMcBride wrote:
> * auto-collapsing all comments except the most recent;
https://bugzil
Antoine Musso wrote:
>Le 02/04/13 04:39, MZMcBride a écrit :
>> I'm concerned that Gerrit actively discourages discussion currently.
>
>So do not use it? We have lists, wiki and private emails.
>
> [...]
>
>I would prefer having all the code and implementations discussion where
>the code is, aka
On Tue, Apr 2, 2013 at 9:03 AM, MZMcBride wrote:
> Would it be possible to have Gerrit import a JavaScript page from
> MediaWiki.org (e.g., "MediaWiki:Gerrit.js")? This might allow dedicated
> users to override some of the default behavior (such as the block-level
> comment auto-collapsing) or add
For my own changes I have a workflow that's a little clunky, but works for
me. I'll comment or mark done on every comment, so if I see the same
number of drafts as comments, I know I've addressed them all.
The workflow I have not found is a way to efficiently re-review other
people's changes that
Christian Aistleitner wrote:
>while I do not want to discourage discussion of those items on
>wikitech-l, I nevertheless filed them in bugzilla, so we can keep
>track of the issues / solutions.
This is wonderful. Thank you for filing these bugs, Christian. I'll take a
look at them now.
MZMcBride
I feel very dirty having done this but I made a chrome extension that
autoexpands all comments and adds a comment count next to unexpanded older
patchsets.
The code's horrible but it works - feel free to try it out:
https://github.com/jdlrobson/gerrit-be-nice-to-me
I suspect the best long term s
This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too
scared :)
On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson wrote:
> I feel very dirty having done this but I made a chrome extension that
> autoexpands all comments and adds a comment count next to unexpanded older
> patchsets.
>
Jon, do you think it might make sense to hide all those jenkin-bot
comments? They are mostly noise, and the only time when compilation fails,
its ok to click to expand just that comment. Or maybe just expand the last
jenkin-bot comment, but hide all the previous ones.
On Wed, Apr 3, 2013 at 1:53
Yuri
Great minds think alike ;-)
https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b57003797ba9ecb1134797d4
On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan wrote:
> Jon, do you think it might make sense to hide all those jenkin-bot
> comments? They are mostly noise, and th
hehe, thanks! :), just pulled again, but, its broken a bit :(
https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it deleted
comment lines, but apparently its just in indecipherable colors, until
clicked
On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson wrote:
> Yuri
> Great minds think a
You'll need to reload the extension in chrome://extensions
It purposely doesn't delete the comment lines - it just makes them
invisible just in case you might want to see them. It's all one big hack so
might be wrong but it works for me ;-)
On Wed, Apr 3, 2013 at 12:17 PM, Yuri Astrakhan wrote:
>
on both monitors i checked, 0.2 opacity is too low, plus I don't think it
should apply to the border, just the header inside it, which also removes
the need to restore it on click. What do you think?
function silentNoise( $commentPanel ) {
// makes jenkins comments less prominent
$commentP
On Mon, Apr 1, 2013 at 8:31 PM, Jeremy Baron wrote:
> Another big one is "(1 comment)" which gives no information about the
> comment or where it was made and no easy way to jump straight to it.
> (a link or AJAX or whatever).
This one drives me crazy, especially after I've responded to existing
On Mon, Apr 8, 2013 at 7:32 PM, S Page wrote:
> On Mon, Apr 1, 2013 at 8:31 PM, Jeremy Baron wrote:
>> Another big one is "(1 comment)" which gives no information about the
>> comment or where it was made and no easy way to jump straight to it.
>> (a link or AJAX or whatever).
>
> This one drives
22 matches
Mail list logo
