Re: [Wikitech-l] Improving Wikimedia's Code Review process

Le 16/03/2016 20:49, Daniel Kinzler a écrit : > There will be an RFC meeting tonight about this: > https://phabricator.wikimedia.org/E148 > > One thing that I don't remember coming up during the summit is: > > Can we perhaps get all the people with +1 rights to use them and actually > review >

Re: [Wikitech-l] Improving Wikimedia's Code Review process

On Wed, Mar 16, 2016 at 3:47 PM, Jon Robson wrote: > We have two swat windows every day. It's magical... I post a request for a > deploy on a Wiki page and someone deploys it. > > Could we try a similar thing with code review. Code review window (maximum > 1 patch per

Re: [Wikitech-l] Improving Wikimedia's Code Review process

There will be an RFC meeting tonight about this: https://phabricator.wikimedia.org/E148 One thing that I don't remember coming up during the summit is: Can we perhaps get all the people with +1 rights to use them and actually review stuff? So that people with +2 rights can look at things that

Re: [Wikitech-l] Improving Wikimedia's Code Review process

We have two swat windows every day. It's magical... I post a request for a deploy on a Wiki page and someone deploys it. Could we try a similar thing with code review. Code review window (maximum 1 patch per person) and have a group of +2ers look at a maximum set of patches? It would need a few

[Wikitech-l] Improving Wikimedia's Code Review process

Hey everybody! At the Wikimedia Developer Summit there was a session about "Making Code Review not suck" [1].  The outcome are Phabricator (sub)tasks of the task "Define potential actions to reduce code review queues and waiting times" in   https://phabricator.wikimedia.org/T101686 The following