Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-13 Thread Krinkle
On Thu, Jan 12, 2012 at 5:57 PM, Chad innocentkil...@gmail.com wrote: On Thu, Jan 12, 2012 at 11:51 AM, Daniel Barrett d...@vistaprint.com wrote: Me: 8. Our MediaWiki:common.js stopped running on the login page. I realize this was a security fix; it just took me by surprise. Fixed by

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-13 Thread Victor Vasiliev
On Thu, Jan 12, 2012 at 5:39 PM, Chad innocentkil...@gmail.com wrote: 2.      The removal of Xml::hidden() caused one of our extensions to break.   I switched to Xml::input(..., array('type', 'hidden')) Xml::hidden() was removed entirely? There *is* Html::hidden() which should be

[Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread Daniel Barrett
As MediaWiki 1.19 is getting ready, I'd like to offer information on how MediaWiki 1.18.0 was the most difficult MW upgrade I've ever been through. Some background: my team administers an internal wiki at a major company with ~2000 users, over 100 extensions (many of them custom/unreleased),

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread Sumana Harihareswara
On 01/12/2012 11:31 AM, Daniel Barrett wrote: So, here's the list of what we had trouble with, and what we did. I welcome any improvements to our fixes! Daniel, thank you so much for taking the time to list these out. And my sympathies that your upgrade was so troublesome! -- Sumana

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread David Gerard
On 12 January 2012 16:31, Daniel Barrett d...@vistaprint.com wrote: So, here's the list of what we had trouble with, and what we did.  I welcome any improvements to our fixes! This deserves a page on mediawiki.org. - d. ___ Wikitech-l mailing

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread Chad
Skipping most of this, but there's a few I at least have an answer for. On Thu, Jan 12, 2012 at 11:31 AM, Daniel Barrett d...@vistaprint.com wrote: 1.      The global variable $action disappeared, breaking a bunch of our extensions.  I switched to $wgRequest-getVal('action'). This may have

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread Daniel Barrett
Me: 8.      Our MediaWiki:common.js stopped running on the login page. I realize this was a security fix; it just took me by surprise.  Fixed by writing a custom extension using the hook UserLoginForm to inject the few lines of JS we needed, and I'm evaluating other non-JS solutions for

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread Chad
On Thu, Jan 12, 2012 at 11:51 AM, Daniel Barrett d...@vistaprint.com wrote: Me: 8.      Our MediaWiki:common.js stopped running on the login page. I realize this was a security fix; it just took me by surprise.  Fixed by writing a custom extension using the hook UserLoginForm to inject the

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-12 Thread Max Semenik
On 12.01.2012, 20:31 Daniel wrote: 5. The removal of $wgMessageCache-addMessage() broke many extensions, some ours and some from mediawiki.org like SimpleForms. Some fixes just required use of the i18n file. Our more difficult issue was that we were injecting system messages into