Re: [Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core patches

2015-10-15 Thread S Page
If you're intrigued by all the code checking automation available, Extension:BoilerPlate [1] implements both the `npm test` and `composer test` entry points, and people have updated it to run jshint, jscs, banana-checker, jsonlint, php-parallel-lint, and now PHP CodeSniffer. Its README [2]

Re: [Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core patches

2015-10-14 Thread Legoktm
Hi, On 09/26/2015 04:28 PM, Legoktm wrote: > There are still a few code style rules that are disabled, [2] is > tracking fixing those issues. These have all been resolved, and all rules in the MediaWiki standard are now passing and voting \o/ > [2] https://phabricator.wikimedia.org/T102609 --

Re: [Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core patches

2015-10-14 Thread Florian Schmidt
*yay* thanks for the work! :) Gesendet mit meinem HTC - Nachricht beantworten - Von: "Legoktm" <legoktm.wikipe...@gmail.com> An: "Wikimedia developers" <wikitech-l@lists.wikimedia.org> Betreff: [Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core p

Re: [Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core patches

2015-09-28 Thread Quim Gil
On Sun, Sep 27, 2015 at 2:20 AM, Ricordisamoa wrote: > foreach( $people_Involved as $person): $person->thank( ) ; endforeach ; :) Indeed! Thank you Legoktm, this is very useful and fits very well in our efforts to improve our code review practices. > > > Il

[Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core patches

2015-09-26 Thread Legoktm
Hi, Thanks to the hard work of a lot of different people, PHP CodeSniffer is now voting on all MediaWiki core patchsets! It checks for basic code style issues automatically so new contributors (and experienced ones!) can fix basic issues without a human needing to point them out. I added some

Re: [Wikitech-l] PHP CodeSniffer is now voting on MediaWiki core patches

2015-09-26 Thread Ricordisamoa
foreach( $people_Involved as $person): $person->thank( ) ; endforeach ; Il 27/09/2015 01:28, Legoktm ha scritto: Hi, Thanks to the hard work of a lot of different people, PHP CodeSniffer is now voting on all MediaWiki core patchsets! It checks for basic code style issues automatically so new