Re: [Wikitech-l] PHP namespaces

On Sun, May 29, 2016 at 2:20 AM, Stas Malyshev wrote: > > According to PSR-4 > > > >The fully qualified class name MUST have a top-level namespace name, > >also known as a "vendor namespace". > > Does this imply all classes in our code base must start w

Re: [Wikitech-l] PHP namespaces

Hi! > According to PSR-4 > >The fully qualified class name MUST have a top-level namespace name, >also known as a "vendor namespace". Does this imply all classes in our code base must start with \Mediawiki? If so, I don't think this is a very good idea

Re: [Wikitech-l] PHP namespaces

According to PSR-4 The fully qualified class name MUST have a top-level namespace name, also known as a "vendor namespace". Just like how it is being done within MediaWiki core, it seems wise to keep existing classes without any top-level namespace for

Re: [Wikitech-l] PHP namespaces

Le 28/05/2016 à 16:15, Ricordisamoa a écrit : > With https://gerrit.wikimedia.org/r/288633 some new classes in the Babel > extension were put into a new namespace "MediaWiki\Babel\BabelBox". > Legoktm approved but Thiemo Mättig (WMDE) disagrees. PHPUnit tests are > already in namespace "Babel\Tests

Re: [Wikitech-l] PHP namespaces

Is the reason for the new namespaces for testing, or because the classes are more suitable to a namespace? On Sat, May 28, 2016 at 9:15 AM, Ricordisamoa wrote: > With https://gerrit.wikimedia.org/r/288633 some new classes in the Babel > extension were put into a new namespace "MediaWiki\Babel\Ba

[Wikitech-l] PHP namespaces

With https://gerrit.wikimedia.org/r/288633 some new classes in the Babel extension were put into a new namespace "MediaWiki\Babel\BabelBox". Legoktm approved but Thiemo Mättig (WMDE) disagrees. PHPUnit tests are already in namespace "Babel\Tests". ___