Re: [Wikitech-l] Refactor of mediawiki/extensions/ArticleFeedbackv5 backend

2012-12-05 Thread Terry Chay
On Dec 5, 2012, at 12:43 PM, Patrick Reilly wrote: > Fellow Wikimedia Developers, > > Matthias Mullie has been working hard to refactor the backend of > mediawiki/extensions/ArticleFeedbackv5 to add proper sharding support. > > The original approach that he took was to rely on RDBStore that wa

Re: [Wikitech-l] Refactor of mediawiki/extensions/ArticleFeedbackv5 backend

2012-12-05 Thread Aaron Schulz
I'm seconding that recommendation to be clear. More specifically, I'd suggest that the AFT classes have two new protected methods: * getSlaveDB() - wrapper for wfGetLBFactory()->getExternalLB( $wgArticleFeedBackCluster )->getConnection( DB_SLAVE, array(), $wikiId ) * getMasterDB() - wrapper for wfG

[Wikitech-l] Refactor of mediawiki/extensions/ArticleFeedbackv5 backend

2012-12-05 Thread Patrick Reilly
Fellow Wikimedia Developers, Matthias Mullie has been working hard to refactor the backend of mediawiki/extensions/ArticleFeedbackv5 to add proper sharding support. The original approach that he took was to rely on RDBStore that was first introduced in Change-Id: Ic1e38db3d325d52ded6d2596af2b6bd3