Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-07-01 Thread Chad
On Fri, Jul 1, 2011 at 2:38 AM, Ashar Voultoiz wrote: >  - add a SVN post commit hook to trigger a build (either through CC web > service or by touching the  CC/projects/mw/touchme directory. > This is on my todo list, as is fixing up our commit hooks in general. -Chad _

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-30 Thread Ashar Voultoiz
On 18/06/11 19:36, Bryan Tong Minh wrote: > How often does CC run the tests? It is once per hour, one can trigger a build manually. > Can we make it run after every commit? Not out of the box :-/ There is two possibilities though: - change CC 'svn update' script so it fetches only one revi

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-18 Thread Bryan Tong Minh
On Wed, Jun 15, 2011 at 11:02 PM, Chad wrote: > Painstakingly, all of the unit tests are now passing on cruise control > (Sqlite) > and my local install (Sqlite & Mysql). This is as of r90150 [0]. Thank you > immensely to Brion for finally tracking down and eliminating that pesky > BlockTest bug.

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-18 Thread Bryan Tong Minh
On Fri, Jun 17, 2011 at 3:35 AM, Max Semenik wrote: > On 17.06.2011, 1:08 Bryan wrote: > >> Can somebody on Windows/SQLite try running the tests? I'm consistently >> getting two failures in XmlTest, which Chad apparently is not getting: > > > Yes, same thing for me. Hoowever. the difs show no real

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-16 Thread Max Semenik
On 17.06.2011, 1:08 Bryan wrote: > Can somebody on Windows/SQLite try running the tests? I'm consistently > getting two failures in XmlTest, which Chad apparently is not getting: Yes, same thing for me. Hoowever. the difs show no real difference, WTF? PHP 5.3.5/XAMPP - these errors aren't relate

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-16 Thread OQ
> 1) BlockTest::testInitializerFunctionsReturnCorrectBlock > Argument 1 passed to Block::equals() must be an instance of Block, > null given, called in > /var/www/thedarkcitadel.com/w/tests/phpunit/includes/BlockTest.php on > line 72 and defined > > /var/www/thedarkcitadel.com/w/includes/Block.php:

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-16 Thread OQ
On Thu, Jun 16, 2011 at 4:08 PM, Bryan Tong Minh wrote: > Can somebody on Windows/SQLite try running the tests? I'm consistently > getting two failures in XmlTest, which Chad apparently is not getting: To hijack, what output from the unit tests should be reported, Errors and failures? >From Lin

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-16 Thread Bryan Tong Minh
Can somebody on Windows/SQLite try running the tests? I'm consistently getting two failures in XmlTest, which Chad apparently is not getting: 1) XmlSelectTest::testSetDefault Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ foo1 bar1 foo2 D:\Bryan\workspace\phase3\te

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-16 Thread Chad
On Thu, Jun 16, 2011 at 3:44 PM, Ashar Voultoiz wrote: > Please note the 1.18 build target does not include tests in the > 'database' group (cause they are heavily slow).  So one could break > REL1_18 without noticing. > Well none of this phpunit work since the branch point has been backported, s

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-16 Thread Ashar Voultoiz
On 15/06/11 23:02, Chad wrote: > Hi everyone, > > Painstakingly, all of the unit tests are now passing on cruise control > (Sqlite) > and my local install (Sqlite& Mysql). This is as of r90150 [0]. Thank you > immensely to Brion for finally tracking down and eliminating that pesky > BlockTest bug

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-15 Thread Brion Vibber
On Wed, Jun 15, 2011 at 2:02 PM, Chad wrote: > This means? We know that according to what we have covered by PHPUnit > (barring things marked incomplete/skipped), everything is currently > working. > > I'd like for Max to turn IRC annoyances back on with the codurr bot for CC > failures. From her

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-15 Thread K. Peachey
On Thu, Jun 16, 2011 at 10:31 AM, Q wrote: > On 6/15/2011 4:02 PM, Chad wrote: >> Hi everyone, >> >> Painstakingly, all of the unit tests are now passing on cruise control >> (Sqlite) >> and my local install (Sqlite & Mysql). This is as of r90150 [0]. Thank you >> immensely to Brion for finally t

Re: [Wikitech-l] Unit testing now working - break it and be reverted

2011-06-15 Thread Q
On 6/15/2011 4:02 PM, Chad wrote: > Hi everyone, > > Painstakingly, all of the unit tests are now passing on cruise control > (Sqlite) > and my local install (Sqlite & Mysql). This is as of r90150 [0]. Thank you > immensely to Brion for finally tracking down and eliminating that pesky > BlockTest

[Wikitech-l] Unit testing now working - break it and be reverted

2011-06-15 Thread Chad
Hi everyone, Painstakingly, all of the unit tests are now passing on cruise control (Sqlite) and my local install (Sqlite & Mysql). This is as of r90150 [0]. Thank you immensely to Brion for finally tracking down and eliminating that pesky BlockTest bug. This means? We know that according to what