Re: [Wikitech-l] 1.18 code review status

2011-08-25 Thread Ashar Voultoiz
On 24/08/11 19:29, Rob Lanphier wrote: > Hi everyone, > > Thank you everyone involved for getting the review queue down as low > as it is. As it stands, we have 82 new revisions to review, and 57 > fixmes: > http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report The most worrying is

Re: [Wikitech-l] 1.18 code review status

2011-08-27 Thread Brion Vibber
On Thu, Aug 25, 2011 at 11:42 PM, Ashar Voultoiz wrote: > The most worrying is the Math system which uses a language most > developers do not know: Objective CAML. > > It is great to have someone working on Math, but it will be hard to get > him reviewed :( > http://www.mediawiki.org/wiki/Special

Re: [Wikitech-l] 1.18 code review status

2011-08-28 Thread Ashar Voultoiz
On 28/08/11 03:20, Brion Vibber wrote: > What that really needs is test cases! > > Not sure how easy to wrangle though... OCaml has an implementation for unit testing. I have spend a bit of time on it and eventually gave up since: - I lack Ocaml skill. - our math code is not commented The te

Re: [Wikitech-l] 1.18 code review status

2011-08-28 Thread Platonides
On 28/08/11 17:49, Ashar Voultoiz wrote: > On 28/08/11 03:20, Brion Vibber wrote: >> What that really needs is test cases! >> >> Not sure how easy to wrangle though... > > OCaml has an implementation for unit testing. I have spend a bit of time > on it and eventually gave up since: >- I lack Oc

Re: [Wikitech-l] 1.18 code review status

2011-08-30 Thread Sumana Harihareswara
I stopped into #ocaml on FreeNode and got a volunteer to give the NEW commits in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/math a review. S/he signed off on almost all of them. So that's progress. Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___

Re: [Wikitech-l] 1.18 code review status

2011-09-02 Thread Ashar Voultoiz
On 30/08/11 22:15, Sumana Harihareswara wrote: > I stopped into #ocaml on FreeNode and got a volunteer to give the NEW > commits in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/math > a review. S/he signed off on almost all of them. So that's progress. That is a good idea :-) -- A