Re: Fwd: Memory leak in WineMine

2000-03-31 Thread H.Takeshima
for example, this code may be valid only in windows 9x, invalid in windows 3.1: hDC = Create[Compatible]DC(); SelectObject( hDC, (anyobject) ); DeleteDC( hDC ); in windows 3.1, original handle of selected object should be restored: hDC = Create[Compatible]DC(); hObj = SelectObject(

Re: Stupid bug in About

2000-03-31 Thread Joshua Thielen
> Try the main menu About Wine. The one you can get at with alt-spacebar > if you are GUI-challenged. The Info About is fine, but the - About Wine > not only has a %s in the caption, but the list of wine authors is empty. Oh yeah, it helps if I read :). I checked this out. The problem arises fr

Re: Fwd: Memory leak in WineMine

2000-03-31 Thread Joshua Thielen
Peter Hunnisett wrote: > Well if the leak appears to be comming from the CreateCompatilbeDC, > my changes will have reduced the impact since we were doing some > pretty massive creation/deletion for DrawMine. I didn't even look > for a leak, though. What changes? Sorry if I'm missing something,

Re: Fwd: Memory leak in WineMine

2000-03-31 Thread Peter Hunnisett
Well if the leak appears to be comming from the CreateCompatilbeDC, my changes will have reduced the impact since we were doing some pretty massive creation/deletion for DrawMine. I didn't even look for a leak, though. The code does have that pattern in several places. Which is causing it, or are

Re: Fwd: Memory leak in WineMine

2000-03-31 Thread Joshua Thielen
> Yes, but it may be unrelated to the memory leak: > The first SelectObject() has a return value: it returns the previously > selected bitmap. You are supposed to select the original bitmap back into > the memory DC before calling DeleteDC on it. But I don't know if it > actually makes a differenc

Re: Stupid bug in About

2000-03-31 Thread lawson_whitney
On Fri, 31 Mar 2000, Joshua Thielen wrote: > This is a multi-part message in MIME format. > --FDEBA0E57E3591937F63A705 > Content-Type: text/plain; charset=us-ascii > Content-Transfer-Encoding: 7bit > > Julio Cesar Gazquez wrote: > > > I tried winemine, and it is indeed the first win

Re: Fwd: Memory leak in WineMine

2000-03-31 Thread Ove Kaaven
On Fri, 31 Mar 2000, Joshua Thielen wrote: > After checking out the memory leak, I think I've narrowed it down to this code > snippet: > > ---in main.c--- > hMemDC = CreateCompatibleDC( hdc ); > SelectObject (hMemDC, p_board->hMinesBMP); > > BitBlt( hdc, > (col - 1) * MINE_WIDTH + p_bo

Re: Fwd: Memory leak in WineMine

2000-03-31 Thread Joshua Thielen
After checking out the memory leak, I think I've narrowed it down to this code snippet: ---in main.c--- hMemDC = CreateCompatibleDC( hdc ); SelectObject (hMemDC, p_board->hMinesBMP); BitBlt( hdc, (col - 1) * MINE_WIDTH + p_board->mines_rect.left, (row - 1) * MINE_HEIGHT + p_board->m

Re: Stupid bug in About

2000-03-31 Thread Joshua Thielen
Julio Cesar Gazquez wrote: > I tried winemine, and it is indeed the first winelib program I ever run. > Then, I found that caption in Wine's about Windows looks "About %s", > even when it works right for wine. This doesn't happen for me (using the tarball of 2326). The correct text should ju

Re: Abort CreateDIBitmap when source bits not readable

2000-03-31 Thread Alexandre Julliard
Uwe Bonnes <[EMAIL PROTECTED]> writes: > I first tried to surround the SetDIBits() at the end of > CreateDIBitmap() with the __TRY __EXCEPT clause, but that resulted > only in the message: > err:seh:EXC_DefaultHandling Exception frame is not in stack limits => > unable to dispatch exceptio

thread suspend/resume/WriteProcessMemory

2000-03-31 Thread Andreas Mohr
Hello all, a program I tested (VideoSelect.exe) does this: Call KERNEL32.746: WriteProcessMemory(7fff,78004858,4106b948,0005,4106b944) ret=0a93b7b3 fs=0247 0819ac10: write_process_memory( handle=2147483647, addr=0x78004858, len=2, first_mask=, last_mask=00ff, data={e9,d3,71,

DSOUND_WriteAudio

2000-03-31 Thread Uwe Bonnes
Hallo, in DSOUND_WriteAudio I got (errno=11:EAGAIN:)Resource temporarily unavailable. Shouldn't if (errno == EINTR) continue; get expanded to if ((errno == EINTR)||(errno == EAGAIN)) c

RE: A case for Wine and Contributing to Wine

2000-03-31 Thread Patrik Stridvall
> >Anyway GNU C options -Wmissing-prototypes and > >-Wmissing-declarations does that already so I didn't think > >it worth while to check it in winapi_check as well. > > > >Of course winapi_check can be made do more advanced checks, > >like checking the parameter names. So what do you wish to chec

Re: Abort CreateDIBitmap when source bits not readable

2000-03-31 Thread Uwe Bonnes
Alexandre Julliard writes: > Uwe Bonnes <[EMAIL PROTECTED]> writes: > > > +if ((init & CBM_INIT) && (IsBadReadPtr(bits,width*height*bpp/8))) > > + { > > + WARN("unreadable bits\n"); > > + return 0; > > + } > > It would be better to do this with an exception handler. Using the > I