Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Dimitrie O. Paun
On March 7, 2003 01:18 am, Dmitry Timoshkov wrote: > I think that using a helper [...] makes it simpler > to modify the code if we will later decide to change the implementation. I don't think this is a consideration. The way the wrapper is written allows for no other implementation, really, sinc

winedbg trouble

2003-03-06 Thread Dan Kegel
OK, finally tried the new winedbg, and I'm afraid I'm mystified. I wanted to debug my pipe regression test. I tried winedbg pipe.exe This starts out ok, printing stuff to stdout like I expect, but then it does something very odd: it switches to reverse video right before it prints "In 32-bit mo

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Dmitry Timoshkov
"Tony Lambregts" <[EMAIL PROTECTED]> wrote: > For the benefit of those of us who are a little thick could someone > explain what that means. I understand that the TEB has TlsSlots for > local storage but.. there is so much I do not understand. A little help... The TEB (see include/thread.h) has

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Tony Lambregts
Dmitry Timoshkov wrote: "Alexandre Julliard" <[EMAIL PROTECTED]> wrote: Thus, there is no need to waste CPU cycles by allocating/deallocating memory, but instead having an automatic buffer on the stack will be quite enough. See files/drive.c,GetCurrentDirectoryA for a sample. All other APIs wh

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Dmitry Timoshkov
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote: > > Thus, there is no need to waste CPU cycles by allocating/deallocating > > memory, but instead having an automatic buffer on the stack will be > > quite enough. See files/drive.c,GetCurrentDirectoryA for a sample. > > > > All other APIs which get

compile fails?

2003-03-06 Thread Gregory M. Turner
Am I the only one with this? gcc -c -I. -I. -I../include -I../include -g -O2 -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -march=athlon-xp \ -pipe -mmmx -m3dnow -msse -fPIC -D__WINESRC__ -DDLLDIR="\"/usr/local/lib/wine\"" -D_REENTRANT -o ldt.o ldt.c ldt.c: In function `set_threa

Re: some ntdll functions (2) - part 1: functions

2003-03-06 Thread Alexandre Julliard
[EMAIL PROTECTED] writes: > + * _ultoa (NTDLL.@) > + * > + * Converts an unsigned long integer to a string. > + * > + * Assigns a '\0' terminated string to str and returns str. > + * Does not check if radix is in the range of 2 to 36 (as native DLL). > + * > + * Difference: > + * - Does not

Re: Add messaging for SB_CTL bars to scroll.c

2003-03-06 Thread Andrew Johnston
On Thursday 06 March 2003 11:49, Dimitrie O. Paun wrote: > Please use inline functions for this sort of thing. > Also, it's typically better to ask the positive question: This patch when applied to the previous patch makes the requested change. Changelog: Remove Macro for detecting invalid SC

Re: PATCH: Inserting an item in a listview sometimes generates incorrect messages

2003-03-06 Thread Adam Gundy
At 10:17 06/03/03 -0500, Dimitrie O. Paun wrote: >On March 6, 2003 06:04 am, Adam Gundy wrote: > >[wine-devel Cc:ed to keep people in the loop] > >> Is a listview guaranteed to be single threaded? I assume it is because it >> is all message driven - so some flag in the LISTVIEW_INFO structure could

Re: PATCH: Inserting an item in a listview sometimes generates incorrect messages

2003-03-06 Thread Dimitrie O. Paun
On Thu, 6 Mar 2003, Adam Gundy wrote: > fine by me. you want me to do it? If you don't mind... :) -- Dimi.

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Rolf Kalbermatter
> Dmitry Timoshkov wrote: > >> "Tony Lambregts" <[EMAIL PROTECTED]> wrote: >> Yeah I actually had it that way at one point due to my familairity >> with drive.c and well... I ran into some compiler errors (in >> RegSaveKeyW) that ended up making the problem worse. Perhaps it was >> something I s

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > Thus, there is no need to waste CPU cycles by allocating/deallocating > memory, but instead having an automatic buffer on the stack will be > quite enough. See files/drive.c,GetCurrentDirectoryA for a sample. > > All other APIs which get a file nam

Re: New conformance test for user32.dll

2003-03-06 Thread Alexandre Julliard
Shachar Shemesh <[EMAIL PROTECTED]> writes: > I usually attach the diff, but make sure that the mime type allows it > to be displayed. I received no complaints so far from Alexander, but > now I'm not sure why. > > The eventual mail has Mime crap, but as it is not encoded Alexander > should be ab

Re: (2nd) Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Vincent Béron
Tony Lambregts a écrit: With Dmitry's suggested change and Vincent's advice (doh!) Second advice: don't forget the patch :)

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Vincent Béron
Tony Lambregts a écrit: when I change the code to the following LONG WINAPI RegSaveKeyA( HKEY hkey, LPCSTR file, LPSECURITY_ATTRIBUTES sa ) { WCHAR fileW[MAX_PATH]; LONG ret, len; len = WideCharToMultiByte(CP_ACP, 0, fileW, -1, file, 0, NULL, NULL); WideCharToMultiByte(CP_ACP, 0, fil

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Tony Lambregts
Tony Lambregts wrote: Dmitry Timoshkov wrote: "Tony Lambregts" <[EMAIL PROTECTED]> wrote: -LONG WINAPI RegSaveKeyW( HKEY hkey, LPCWSTR file, LPSECURITY_ATTRIBUTES sa ) +LONG WINAPI RegSaveKeyA( HKEY hkey, LPCSTR file, LPSECURITY_ATTRIBUTES sa ) { -LPSTR fileA = HEAP_strdupWtoA( GetProce

Re: Should crosstesting work?

2003-03-06 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > They work fine here under NT4. That's a platform I can't test on, unfortunately... Michael Stefaniuc <[EMAIL PROTECTED]> writes: > With self build mingw i couldn't get mingw to link the > binaries. The patch in the thread [...] fixed it for me.

Re: PATCH: Inserting an item in a listview sometimes generates incorrect messages

2003-03-06 Thread Dimitrie O. Paun
On March 6, 2003 06:04 am, Adam Gundy wrote: [wine-devel Cc:ed to keep people in the loop] > Is a listview guaranteed to be single threaded? I assume it is because it > is all message driven - so some flag in the LISTVIEW_INFO structure could > be set. I'd say that is even more opaque. I think t

Re: Janitorial dlls/advapi32/registry.c W->A cleanup

2003-03-06 Thread Tony Lambregts
Dmitry Timoshkov wrote: "Tony Lambregts" <[EMAIL PROTECTED]> wrote: -LONG WINAPI RegSaveKeyW( HKEY hkey, LPCWSTR file, LPSECURITY_ATTRIBUTES sa ) +LONG WINAPI RegSaveKeyA( HKEY hkey, LPCSTR file, LPSECURITY_ATTRIBUTES sa ) { -LPSTR fileA = HEAP_strdupWtoA( GetProcessHeap(), 0, file ); -

Re: New conformance test for user32.dll

2003-03-06 Thread Vincent Béron
Mike Hearn a écrit: I don't need any license info, all patches sent to wine-patches are assumed to be under a Wine-compatible license. If they are not there's no point in submitting them. So if you don't specify, then it's under the LGPL and if you want it to also be available to ReWind you need

Re: New conformance test for user32.dll

2003-03-06 Thread Shachar Shemesh
Alexandre Julliard wrote: Not sure where that documentation is, but it's much better to diff new files than to add separate attachments. The basic rules are: no attachments, no mime crap, no line wrapping, a single patch per mail. Basically if I can't do "cat raw_mail | patch -p0" it's in the wron

Re: Winelib article in this month's C/C++ User's Journal

2003-03-06 Thread Mike Hearn
So when do we get to play Laser Squad Nemesis on Linux? I looked at the site, the demo was only available as an EXE :( On Thu, 2003-03-06 at 01:02, Matthew Bloch wrote: > http://www.cuj.com/current/feature.html?topic=current > > An immodest plug for my introductory Winelib article that the CUJ ed

Re: New conformance test for user32.dll

2003-03-06 Thread Mike Hearn
> I don't need any license info, all patches sent to wine-patches are > assumed to be under a Wine-compatible license. If they are not there's > no point in submitting them. So if you don't specify, then it's under the LGPL and if you want it to also be available to ReWind you need to explicitly s

Re: Winelib article in this month's C/C++ User's Journal

2003-03-06 Thread Francois Gouget
On Thu, 6 Mar 2003, Sylvain Petreolle wrote: > Problem in this link ? It's dead for me. > > --- Matthew Bloch <[EMAIL PROTECTED]> a écrit : > > http://www.cuj.com/current/feature.html?topic=current Didn't work for me either, but after a bit of searching I ended up with: http://www.cuj.com/curren

Re: Winelib article in this month's C/C++ User's Journal

2003-03-06 Thread Sylvain Petreolle
Problem in this link ? It's dead for me. --- Matthew Bloch <[EMAIL PROTECTED]> a écrit : > http://www.cuj.com/current/feature.html?topic=current > > An immodest plug for my introductory Winelib article that the CUJ > editor Joe > Casad was soliciting through thist list back in December. It's