Well, a conformance test would be most useful for being run on Windows,
we already know what Wine does. So the fact that Delphi is faster to
write stuff in than raw C is what motivated me to ask. Yes, there is a
free object pascal compiler, i can't remember what it's called though
On Thu, 2003-01-
On Thursday 16 January 2003 11:44 am, Mike Hearn wrote:
> I think you're right in that a full test case is needed, but I can't
> do that (at least, not in C, if Object Pascal is acceptable I might
> be able to do so).
Why can't it be done in C, out of curiosity? Please forgive me if
paying atten
Unfortunately it seems I was wrong about it stopping the QuickTime menu
corruption... it merely reduces it and changes where it appears. The
changes you gave below don't seem to change that, as far as I can see,
so somehow we're missing a check that Windows does somewhere.
In particular the rather
"Alistair Leslie" <[EMAIL PROTECTED]> wrote:
> Reading about the MENUITEMINFO structure.
> Take from MSDN
> The MFT_BITMAP, MFT_SEPARATOR, and MFT_STRING values cannot be combined with
> one another.
In that case the code which verifies MENUITEMINFO fields could be generalized.
All existing check
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes:
> I'm not opposed to your fix, not at all. I just would like to understand
> better what is the real problem with our code. If you, or somebody else,
> could confirm (by a test case) that exactly (MFT_BITMAP | MFT_SEPARATOR)
> combination should be re
> I'm not opposed to your fix, not at all. I just would like to understand
> better what is the real problem with our code. If you, or somebody else,
> could confirm (by a test case) that exactly (MFT_BITMAP | MFT_SEPARATOR)
> combination should be rejected then I'll vote for your patch.
Reading a
"Mike Hearn" <[EMAIL PROTECTED]> wrote:
> Well, you know a lot more about this than me, so if you think the check
> shouldn't be added then that's fine.
I'm not opposed to your fix, not at all. I just would like to understand
better what is the real problem with our code. If you, or somebody else
> I would suggest to revert your patch until we will find what exactly causes
> IE6 and QuickTime to fail.
Well, in the case of IE6 it's a crash caused by it attempting to destroy
the wrong menu (it does stuff with cloning menus passed in by the html
renderer it seems). That's a secondary reaction
"Mike Hearn" <[EMAIL PROTECTED]> wrote:
> > A conformance test to show the real behaviour is urgently required.
>
> If you mean one that tries every combination of flags to see what
> Windows returns then that's beyond my capabilities and current toolset
> (no real windows development tools).
Th
"Mike Hearn" <[EMAIL PROTECTED]> wrote:
> Fail SetMenuItemInfo if both MFT_BITMAP and MFT_SEPARATOR are
> specified (an api violation).
I thought that Alexandre will not commit this patch, since it's
obviously wrong.
> + if (lpmii->fType & (MFT_BITMAP | MFT_SEPARATOR)) {
> + WARN("fType contains
10 matches
Mail list logo
