Re: Fix for ddraw: CreateSurface

2003-05-30 Thread Lionel Ulmer
> Do you think I should check for the OVERLAY flag into CreateSurface or > into createoffscreen ? I would put this before the 'else assume ...' case and would return the error here (so as the day we will support them, it would be just another case in the if / else if / else if / else code). Somet

Re: Fix for ddraw: CreateSurface

2003-05-29 Thread Sylvain Petreolle
Do you think I should check for the OVERLAY flag into CreateSurface or into createoffscreen ? In case I put it in CreateSurface : - An unhandled case is asked - If this is an overlay, report not supported - Otherwise assume offscreenplain Am I right here ? > Well, I think it would be better to c

Re: Fix for ddraw: CreateSurface

2003-05-29 Thread Lionel Ulmer
On Thu, May 29, 2003 at 12:12:26AM +0200, Sylvain Petreolle wrote: > Since some surface types are unhandled for now, OffScreenPlain is > assumed. > > Unused members of the DDSURFACEDESC2 structure are set to zero, > so the bitperpixel is zero. > > DDRAW_width_bpp_to_pitch is called with bpp 0 and

Fix for ddraw: CreateSurface

2003-05-29 Thread Sylvain Petreolle
Since some surface types are unhandled for now, OffScreenPlain is assumed. Unused members of the DDSURFACEDESC2 structure are set to zero, so the bitperpixel is zero. DDRAW_width_bpp_to_pitch is called with bpp 0 and apps are stopping on assert(bpp != 0); /* keeps happening... */ At least W