On April 5, 2003 09:31 am, Maxime Bellengé wrote:
> 245,246c245,246
> < @ stub EnumLanguageGroupLocalesA
> < @ stub EnumLanguageGroupLocalesW
> ---
Please use uniffied diffs for the patches (diff -u).
Check out
http://www.winehq.org/?page=sending_patches
for more info.
--
Dimi.
Thanks for the comments. I will change that.
Max
On Sat, 2003-04-05 at 12:15, Mike Hearn wrote:
> Hi,
>
> Just a few comments, things that have been mentioned to me so I should
> probably pass along :)
>
> Here:
> - FIXME("stub\n");
> - SetLastError( ERROR_INVALID_PARAMETER );
> - return FA
I wonder if it's possible to force GCC 3.2 to act as a C97 compiler.. It
could be used in Wine's configure script to prevent breakage on us poor GCC
2.95.X compilers :-)
-std=gnu89
A+
--
Eric Pouech
> Again, I'm not a C expert but I think it's invalid strict C to declare
> variables half way through a block, they all have to be at the top of
> the function together.
It's valid C99 though... And as GCC 3.2.x is a C99 compiler, one will see
more and more such code being submitted as patches (I
Hi,
Just a few comments, things that have been mentioned to me so I should
probably pass along :)
Here:
- FIXME("stub\n");
- SetLastError( ERROR_INVALID_PARAMETER );
- return FALSE;
+ TRACE("\n");
+
+ unsigned int i,j,nStrLen;
Normally you'd put a TRACE with the parameters passed after the
