Re: Pajama Sam's unmanaged window

2002-01-31 Thread Dmitry Timoshkov
"Ove Kaaven" <[EMAIL PROTECTED]> wrote: > > > > Since this is probably not the case, perhaps it's better to check for the > > > > popup menu class in is_window_managed(), something like > > > > > > > > if (GetClassLongA(win->hwndSelf, GCW_ATOM) == POPUPMENU_CLASS_ATOM) return > > > > FALSE; > >

Re: Pajama Sam's unmanaged window

2002-01-31 Thread Alexandre Julliard
Ove Kaaven <[EMAIL PROTECTED]> writes: > Hmm. I thought SetWindowLong worked differently than SetClassLong. Weird > stuff... Yes it does, you are right my explanation was more for SetClassLong than SetWindowLong. Basically SetClassLong will affect all windows created with a given class, SetWindo

Re: Pajama Sam's unmanaged window

2002-01-31 Thread Ove Kaaven
On 31 Jan 2002, Alexandre Julliard wrote: > Ove Kaaven <[EMAIL PROTECTED]> writes: > > > Do you have any examples where it might not work... window subclassing is > > the act of using SetWindowLong to replace the window procedure, which does > > not change the class atom, as far as I know? > >

Re: Pajama Sam's unmanaged window

2002-01-31 Thread Alexandre Julliard
Ove Kaaven <[EMAIL PROTECTED]> writes: > Do you have any examples where it might not work... window subclassing is > the act of using SetWindowLong to replace the window procedure, which does > not change the class atom, as far as I know? That's if you want to subclass all windows of a given cla

Re: Pajama Sam's unmanaged window

2002-01-31 Thread Ove Kaaven
On Fri, 1 Feb 2002, Dmitry Timoshkov wrote: > "Ori Pessach" <[EMAIL PROTECTED]> wrote: > > > > Since this is probably not the case, perhaps it's better to check for the > > > popup menu class in is_window_managed(), something like > > > > > > if (GetClassLongA(win->hwndSelf, GCW_ATOM) == POPUP

Re: Pajama Sam's unmanaged window

2002-01-31 Thread Dmitry Timoshkov
"Ori Pessach" <[EMAIL PROTECTED]> wrote: > > Since this is probably not the case, perhaps it's better to check for the > > popup menu class in is_window_managed(), something like > > > > if (GetClassLongA(win->hwndSelf, GCW_ATOM) == POPUPMENU_CLASS_ATOM) return > > FALSE; > > Ah ha! Exactly wha

Re: Pajama Sam's unmanaged window

2002-01-31 Thread Ori Pessach
On Wednesday 30 January 2002 17:39, Ove Kaaven wrote: > On Mon, 28 Jan 2002, Ori Pessach wrote: > > - Changed is_window_managed()'s default return value to TRUE > > Perhaps remove the cruft this leaves behind, then. Of course. > > - In tooltips.c, TOOLTIPS_NCCreate(), I set the WS_EX_TOOLWINDOW

Re: Pajama Sam's unmanaged window

2002-01-30 Thread Ove Kaaven
On Mon, 28 Jan 2002, Ori Pessach wrote: > - Changed is_window_managed()'s default return value to TRUE Perhaps remove the cruft this leaves behind, then. > - In tooltips.c, TOOLTIPS_NCCreate(), I set the WS_EX_TOOLWINDOW bit in the > tooltip's dwExStyle field. This, I believe, is the right th

Re: Pajama Sam's unmanaged window

2002-01-28 Thread Ori Pessach
Hi, With three small changes to menu.c, tooltips.c and window.c, things I'm getting much better results with Pajam Sam et al, without getting WM decorations on tooltips and context menus. The changes are: - Changed is_window_managed()'s default return value to TRUE - In tooltips.c, TOOLTIPS_N

Re: Pajama Sam's unmanaged window

2002-01-27 Thread Ori Pessach
On Sunday 27 January 2002 14:04, Ove Kaaven wrote: > On Sun, 27 Jan 2002, Ori Pessach wrote: > > On Sunday 27 January 2002 11:22, Ove Kaaven wrote: > > > On Sat, 26 Jan 2002, Ori Pessach wrote: > > > > FALSE for those windows. Are there any other types of windows that > > > > shouldn't be managed?

Re: Pajama Sam's unmanaged window

2002-01-27 Thread Ove Kaaven
On Sun, 27 Jan 2002, Ori Pessach wrote: > On Sunday 27 January 2002 11:22, Ove Kaaven wrote: > > On Sat, 26 Jan 2002, Ori Pessach wrote: > > > FALSE for those windows. Are there any other types of windows that > > > shouldn't be managed? > > > > Yes, Alexandre mentions popup menus and tooltips.

Re: Pajama Sam's unmanaged window

2002-01-27 Thread Ori Pessach
On Sunday 27 January 2002 11:22, Ove Kaaven wrote: > On Sat, 26 Jan 2002, Ori Pessach wrote: > > FALSE for those windows. Are there any other types of windows that > > shouldn't be managed? > > Yes, Alexandre mentions popup menus and tooltips. Perhaps a chart could be > made, so that it is possibl

Re: Pajama Sam's unmanaged window

2002-01-27 Thread Ove Kaaven
On Sat, 26 Jan 2002, Ori Pessach wrote: > I found that the game's main window simply wasn't managed. The game opens a > window that covers the entire screen, and doesn't have a caption. > is_window_managed(), in dlls/x11drv/window.c therefore returns FALSE for that > window, and (I'm guessing

Pajama Sam's unmanaged window

2002-01-27 Thread Ori Pessach
Hi, I spent some time trying to hunt down the window management problems I reported a while ago (dialogs displayed by the game Pajama Sam appearing behind the main window, and sometimes not getting keyboard focus). I found that the game's main window simply wasn't managed. The game opens a wi