Re: Oleaut32 3

2003-10-07 Thread Marcus Meissner
On Mon, Oct 06, 2003 at 11:51:22AM -0400, Dimitrie O. Paun wrote: On Mon, 6 Oct 2003, Jon Griffiths wrote: Size and speed. The inlined versions are to meant to be used within the variant code, the biggest user being the coercion functions when I get round to updating them (after the

Re: wine/ windows/winpos.c server/window.c server/ ...

2003-10-07 Thread Martin Fuchs
Hello Alexandre, I see, you implemented storage of the four global shell and takman windows. Btw.: great unified aproach, this single get/set server call. :) But you did not yet insert the altered focus handling in set_active_window() from my patch. Is this just comming next, or is there

Re: Oleaut32 3

2003-10-07 Thread Jon Griffiths
Hi, I see, I did not notice the _-versions where inlined. But since all uses seem to be in the same file (is this correct), can't we just mark the regular ones as extern inline? I didn't put all the functions in the same file, because a) they split pretty logically into groups of 12-20

Re: cdrom problem? winefile crash

2003-10-07 Thread Rein Klazes
On 07 Oct 2003 11:28:51 +0200, you wrote: Hi, fixme:cdrom:CDROM_GetInterfaceInfo CD-ROM device (11, 0) not supported what it mean? I see this as well. And it is a bug. I just send in a proposed fix for it to wine-patches. this is my cd is (11, 0) and then? brw-rw1 moreno

Re: wine/ windows/winpos.c server/window.c server/ ...

2003-10-07 Thread Alexandre Julliard
Martin Fuchs [EMAIL PROTECTED] writes: But you did not yet insert the altered focus handling in set_active_window() from my patch. Is this just comming next, or is there another particular reason for not doing this? Well, I'm not convinced we need to do such special handling at all; why did

Re: libs/unicode new conversions

2003-10-07 Thread Jon Griffiths
Hi, --- Alexandre Julliard [EMAIL PROTECTED] wrote: IMO you should export the FoldString functionality from libs/unicode, not the tables. OK, can do. they need to be generated from the Unicode standard data, and the code to do that should be added to cpmap.pl. The data for the numeric

Re: Theme configuration options

2003-10-07 Thread Dimitrie O. Paun
On Tue, 7 Oct 2003, Steven Edwards wrote: Is there a way we can merge the winelook option in to the themeing support? The work I have been doing to port comdlg32 is kind of stalled because of tweak_winelook being incompleate in this dll. It would be nice if we could plan on moving all of this

Re: libs/unicode new conversions

2003-10-07 Thread Alexandre Julliard
Jon Griffiths [EMAIL PROTECTED] writes: The data for the numeric conversion is in the Unicode data, but it doesn't match MS's as of XP. The other mappings will no doubt differ slightly too. I take it we don't care? Not really; if an app depends on the difference we can always tweak the

Re: Crash in 16-bit code

2003-10-07 Thread Jukka Heinonen
On Tue, Oct 07, Sylvain Petreolle wrote: I still get a crash with WinDVD. Attached : trace with +int (int 1a has no other debug channel) and disass around $eip. Well, well. This looks pretty interesting. It looks like the program is trying to call PCI BIOS routine FIND PCI DEVICE from 32-bit

Re: Crash in 16-bit code

2003-10-07 Thread Jukka Heinonen
On Tue, Oct 07, 2003 at 12:29:15AM +0200, André Johansen wrote: * Jukka Heinonen wrote: | Okay, I have posted a patch to wine-patches that | should have fixed this bug. Let's see if that is | the case. Thanks -- I've tested it, and it seems to get further now. It still crashes, though...

Re: Crash in 16-bit code

2003-10-07 Thread Jukka Heinonen
On Tue, Oct 07, Eric Pouech wrote: may be (code janitorial) we could get rid of all MapSL and PTR_REAL_TO_LIN calls, and just use the CTX_SEG_OFF_TO_LIN macro instead ? That would be more readable IMO. Well, that would be a good idea. I was actually planning to post a patch that would make

Re: Crash in 16-bit code

2003-10-07 Thread Jukka Heinonen
On Tue, Oct 07, André Johansen wrote: Is it possible to add more trace messages somewhere or get a larger call-stack? Well, you could try using +relay debugmsg flag, but that usually yields way too large traces. Probably the easiest way would be adding manually TRACE (or ERR) lines to

Re: Crash in 16-bit code

2003-10-07 Thread André Johansen
* Jukka Heinonen wrote: | Well, you could try using +relay debugmsg flag Here are some lines around the crash-point; compare it to the previous one (I made sure some output from that one was preset in my cut-out): $ wine --debugmsg +int,+int31,+relay ./Setup 2 /tmp/trace From /tmp/trace: [...]

Re: Protected mode interrupt problem

2003-10-07 Thread Alexandre Julliard
Jukka Heinonen [EMAIL PROTECTED] writes: However, I can't see why this would cause a crash because as far as I know, int 0 vector is never called by Wine. It doesn't really matter but I'm just curious... (Perhaps they handle int 0 as a call chain?) It never gets called, but in order to change

Re: Theme configuration options

2003-10-07 Thread Kevin Koltzau
I'm not very familiar with how the winelook is handled in code, what does it do exactly? if it simply affects system metrics colors that would be easily merged with themes, if its more then that (like for example different common dialogs) it may be more difficult Full blown theming in windows

Re: Move actual code out of assert statements

2003-10-07 Thread Alexandre Julliard
[EMAIL PROTECTED] writes: (See attached file: patch_code_out_of_asserts.txt) The indentation is messed up. You should set your editor tab width to 8 instead of 4. -- Alexandre Julliard [EMAIL PROTECTED]

Re: question about copyright and code, is this legal?

2003-10-07 Thread Troy Rollo
On Fri, 3 Oct 2003 23:07, Patrik Stridvall wrote: [correct summary of the law deleted] As far as Wine is concerned though I can't think of any Windows API that: 1. Returns pure facts (not having any unique expression) 2. Would fulfill the requirement of needed a significant effort to