Re: Cleanup A->W calls:

2004-07-08 Thread Dmitry Timoshkov
[EMAIL PROTECTED] wrote: > @@ -362,6 +363,24 @@ > */ > BOOL WINAPI Shell_NotifyIconA(DWORD dwMessage, PNOTIFYICONDATAA pnid ) > { > + BOOL ret; > + > + PNOTIFYICONDATAW p = HeapAlloc(GetProcessHeap(),0,sizeof(NOTIFYICONDATAW)); > + memcpy(p, pnid, sizeof(NOTIFYICONDATAW)); > + MultiByteToWideChar(

Re: HKEY_DYN_DATA in win9x

2004-07-08 Thread Mike Hearn
On Wed, 07 Jul 2004 21:05:58 -0400, Robert Reif wrote: > Where and how. It looks like wine/misc/registry.c _allocate_default_keys > is creating HKEY_DYN_DATA\PerfStats but adding code for a new key doesn't > get called. How and when does this code get called. Make sure the wineserver shuts down

Initial creation of directory and config with ttydrv

2004-07-08 Thread Shachar Shemesh
Hi all, I need to create the initial environment for wine (the .wine directory) in an environment where no X11 server is available. Once the directory is up (for example, if I copy it from somewhere), there is no problem to add a config file that chooses the ttydrv driver. However, I cannot cre

Re: Initial creation of directory and config with ttydrv

2004-07-08 Thread Shachar Shemesh
[EMAIL PROTECTED] wrote: Just run wine. The first time it will create the directory. From: Shachar Shemesh <[EMAIL PROTECTED]> Date: 2004/07/08 Thu AM 11:35:21 GMT To: Wine Development <[EMAIL PROTECTED]> Subject: Initial creation of directory and config with ttydrv Hi all, I need to create the

Re: Add a 16-bit pair DLL for TWAIN

2004-07-08 Thread Andreas Mohr
On Thu, Jul 08, 2004 at 06:26:12PM +0100, Mike Hearn wrote: > This is probably wrong in some aspects as this is the first time I have > done a 16 bit pair DLL, but the Office XP installer never actually calls > it, it just loads it in order to get the version information. > > The main problem is t

Marshal bug

2004-07-08 Thread Duane Clark
Howdy, This patch: http://www.winehq.org/hypermail/wine-cvs/2004/05/0283.html causes a crash within Actel Designer (commercial FPGA design software). Reverting the patch with current CVS fixes the application. A trace and crash dump look like > wine /c/Actel/bin/designer.exe trace:ole:DllMain 0x4

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Mike McCormack
You probably want to use a Windows method to allocate memory here, such as HeapAlloc() or CoTaskMemAlloc, as the caller is not going to use free() to free the memory... Mike Andrei Barbu wrote: Changelog: Fixes a memory access fault inside of D3D8_GetCreationParameters. ... HRESULT WINAPI IDi

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Andrei Barbu
Unfortunately I've never actually had to use those before. I'll look them up. Which one would be best in this case? On Thu, 2004-07-08 at 15:39, Mike McCormack wrote: > You probably want to use a Windows method to allocate memory here, such > as HeapAlloc() or CoTaskMemAlloc, as the caller is not

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Marcus Meissner
On Fri, Jul 09, 2004 at 04:39:31AM +0900, Mike McCormack wrote: > You probably want to use a Windows method to allocate memory here, such > as HeapAlloc() or CoTaskMemAlloc, as the caller is not going to use > free() to free the memory... > Mike > > Andrei Barbu wrote: > >Changelog: > > > >Fixe

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Andrei Barbu
It doesn't have to return that memory, DX functions work by taking parameters they modify. In essence, that's the point, modifying pParameters and returning D3D_OK Andrei On Thu, 2004-07-08 at 15:50, Marcus Meissner wrote: > On Fri, Jul 09, 2004 at 04:39:31AM +0900, Mike McCormack wrote: > > You

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Christian Costa
Andrei Barbu wrote: It doesn't have to return that memory, DX functions work by taking parameters they modify. In essence, that's the point, modifying pParameters and returning D3D_OK Marcus is right. Morover, according to the doc, a pointer to a valid area must be passed as parameter (the prototy

Re: Marshal bug

2004-07-08 Thread Mike Hearn
What happens if you reinstall the app or reregister all the DLLs shipped with it (using regsvr32) ? Does that fix it ? thanks -mike

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Mike Hearn
On Thu, 08 Jul 2004 18:58:57 -0400, Andrei Barbu wrote: > It doesn't have to return that memory, DX functions work by taking > parameters they modify. In essence, that's the point, modifying > pParameters and returning D3D_OK Right, what he means is that the parameter is basically a pointer to a p

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Andrei Barbu
I agree on the docs, interestingly enough though, Chessmaster 9000 gives an invalid pointer (0x1) and there's a memory access error. Works on Windows though, so I'm assuming DX might be allocating the memory on it's own. On Thu, 2004-07-08 at 19:45, Christian Costa wrote: > Andrei Barbu wrote: >

Re: Initial creation of directory and config with ttydrv

2004-07-08 Thread Vincent Béron
Le jeu 08/07/2004 à 08:03, Shachar Shemesh a écrit : > Wine won't run if it is set to use the X11drv driver, and there is no > X11 display. Then again, the only way I can tell it to use the ttydrv is > by placing a config file in the .wine directory, which does not exist > until I run wine once.

Re: D3D8_GetCreationParameters fix

2004-07-08 Thread Andrei Barbu
Having given thought to the issue, you're right. That was a bad solution, sorry. It should have failed with D3DERR_INVALIDCALL if it's a bad write pointer. Is this new patch ok? On Thu, 2004-07-08 at 19:45, Christian Costa wrote: > Andrei Barbu wrote: > > >It doesn't have to return that memory,

Re: Initial creation of directory and config with ttydrv

2004-07-08 Thread Shachar Shemesh
Vincent Béron wrote: Le jeu 08/07/2004 à 08:03, Shachar Shemesh a écrit : Wine won't run if it is set to use the X11drv driver, and there is no X11 display. Then again, the only way I can tell it to use the ttydrv is by placing a config file in the .wine directory, which does not exist until