Re: epoll patch - status?

2004-09-08 Thread Mike McCormack
Shachar Shemesh wrote: +r = epoll_ctl( epoll_fd, EPOLL_CTL_DEL, fd, &eev ); +assert( 0 == r ); This assert still depends on the removal semantics. If it's ok for the users to close the Unix fd before removing it from the poll array, you may find that it's already gone and the assert wi

Re: Drowning in FIXMEs...

2004-09-08 Thread Peter \"Firefly\" Lund
On Mon, 6 Sep 2004 [EMAIL PROTECTED] wrote: > On Sun, Sep 05, 2004 at 10:09:26PM +0300, Jukka Heinonen wrote: > > Well, under DOS VGA text mode, mouse cursor is like "gpm" mouse > > cursor, a character cell which gets inverted or otherwise > > IIRC it's inverted. That depends. There is a call wh

Re: epoll patch - status?

2004-09-08 Thread Shachar Shemesh
Mike McCormack wrote: Shachar Shemesh wrote: Read the comment in the appropriate section of my code. You have a race here that will crash you occasionally. Fixed. Ahmm. I'm not so sure. Did you also handle the case where 1, 2 and 3 were flagged, 1 releases 3, and 2 asks for a new fd and receives

Re: epoll patch - status?

2004-09-08 Thread Shachar Shemesh
Mike McCormack wrote: I mean I've allocated an array of 10 struct epoll_events to receive events from epoll, and I plan to dynamically allocate it later. I have greater plans for wineserver :-) As part of those plans, I'm going to ask some kernel gurus whether that's strictly necessary. If it's n

Re: epoll patch - status?

2004-09-08 Thread Mike McCormack
Shachar Shemesh wrote: * used direct syscalls as my libc doesn't have epoll_* functions Which Alexandre already asked not to. In any case, if you do, you have to add a copyright notice to the authors of the header file who's content you are copying. OK, fixed. * fixed array of epoll_event struct

Re: test.winehq.org site

2004-09-08 Thread Chris Morgan
Winrash doesn't actually submit any results, the winetests submit the results themselves. I looked in the log file on my machine and I've seen the tests running and I've seen the "My Documents" window popup so it does appear that the winetests are running. Chris On Wednesday 08 September 200

The solution for the Delphi menu bug

2004-09-08 Thread Michael Kaufmann
Hi all, I found a different approach to make the menus of Delphi applications work in WINE. I was working on a different bug (allow a single menu to be used in multiple windows), and found that my fix for this problem also fixes the Delphi menu bug. So we don't have to break a testcase! The fix

Re: DirectInput suggestion

2004-09-08 Thread Robert Reif
Jonathan Wilson wrote: I dont know how this stuff works on linux so my suggestion may be wrong but here goes. Basicly, my suggestion is that any joystick that is visible to linux apps be made visible to windows apps via DirectInput joystick APIs. This eliminates the need for WINE to care about U

Re: Re: test.winehq.org site

2004-09-08 Thread James Hawkins
> From what I can tell on my xp machine it looks like winrash is running correctly Has winrash submitted any results from your tests, or have you seen any results from the tests? When I ran winrash, it seemed like it was running the tests in the background, but nothing ever happened. On Wed, 8

Re: Problem with change of DIDEVICEOBJECTDATA

2004-09-08 Thread Robert Reif
Stefan Dösinger wrote: Hello, I have a problem with the change of struct DIDEVICEOBJECTDATA in CVS: DIDEVICEOBJECTDATA now has size 20, but Settler 3 still calls SysMouseAImpl_GetDeviceData with dodsize=16 and complains about the returned error. Stefan Dösinger Just posted a patch to wine-pa

Re: Re: test.winehq.org site

2004-09-08 Thread Chris Morgan
>From what I can tell on my xp machine it looks like winrash is running correctly, no >errors downloading the winetest are reported. Maybe winetest is failing prematurely >or the reporting of the results isn't occuring correctly? Chris > > From: "Dimitrie O. Paun" <[EMAIL PROTECTED]> > Date:

Re: UltimaOnLine: X11DRV_CritSection deadlock

2004-09-08 Thread Uwe Bonnes
> "Lionel" == Lionel Ulmer <[EMAIL PROTECTED]> writes: Lionel> (Answering this one as the original mail is lost in my HUGE Lionel> wine-devel folder that takes ages to load on my puny P120 used Lionel> to read mails :-) ) >> > But the true problem is that if I'm idle for some

RE: [SHLWAPI] Implemented PathSearchAndQualify (fix)

2004-09-08 Thread Rolf Kalbermatter
A few comments: /* @@ -3126,8 +3146,87 @@ */ BOOL WINAPI PathSearchAndQualifyW(LPCWSTR lpszPath, LPWSTR lpszBuf, UINT cchBuf) { - FIXME("(%s,%p,0x%08x)-stub\n", debugstr_w(lpszPath), lpszBuf, cchBuf); - return FALSE; +

Re: Problem with change of DIDEVICEOBJECTDATA

2004-09-08 Thread Lionel Ulmer
On Wed, Sep 08, 2004 at 07:52:46PM +0200, Stefan Dösinger wrote: > Hello, > I have a problem with the change of struct DIDEVICEOBJECTDATA in CVS: > DIDEVICEOBJECTDATA now has size 20, but Settler 3 still calls > SysMouseAImpl_GetDeviceData with dodsize=16 and complains about the returned > error.

Re: UltimaOnLine: X11DRV_CritSection deadlock

2004-09-08 Thread Lionel Ulmer
(Answering this one as the original mail is lost in my HUGE wine-devel folder that takes ages to load on my puny P120 used to read mails :-) ) > > But the true problem is that if I'm idle for some time, I get this error, > > and kde stops responding at mouse (and sometimes also keyboard) events:

Re: Settlers 3: bug in NTDLL_get_server_timeout??

2004-09-08 Thread Lionel Ulmer
> I can start s3 with disabling the call to NTDLL_get_server_timeout. > Now I've two other problems: > *The image is placed slightly wrong This may be a DDraw issue... A WINEDEBUG=+ddraw log enclosed in a Bugzilla bug report would be nice. > *The mouse always moves back to the center of the scree

Re: Revised menu patch

2004-09-08 Thread Michael Kaufmann
Hi Alexandre The only explanation was "it breaks the testcase X", where X is a testcase that doesn't even pass on Windows 9x. I think the patch won't break any real application. Famous last words. There have been a number of similar hacks done in the menu code already, but they all had to be r

Re: Revised menu patch

2004-09-08 Thread Alexandre Julliard
Michael Kaufmann <[EMAIL PROTECTED]> writes: > The only explanation was "it breaks the testcase X", where X is a > testcase that doesn't even pass on Windows 9x. I think the patch won't > break any real application. Famous last words. There have been a number of similar hacks done in the menu cod

Re: epoll patch - status?

2004-09-08 Thread Shachar Shemesh
Mike McCormack wrote: Shachar Shemesh wrote: After a discussion with Alexandre on IRC I came to the conclusion that nothing I will do will make this patch go in. Mike, please add it to your list of "uncommitted patches". Hi Shachar, I'm not sure which Mike the above is addressed at... :) Mike He

Re: UltimaOnLine: X11DRV_CritSection deadlock

2004-09-08 Thread James Hawkins
> a cure for cancer instead of looking for ET's. United Devices does not > offer the Agent in native Linux or any other OS except win32, written in > VB6. Sorry to hear that. :-\ On Wed, 8 Sep 2004 10:52:34 -0700, Roger Olson <[EMAIL PROTECTED]> wrote: > James Hawkins Wrote: > > > Maybe I'm c

Re: Revised menu patch

2004-09-08 Thread Michael Kaufmann
Hi Dmitry How do you define the "real behavior" ? That's a behaviour of an existing product that could be tested and confirmed. So is there an existing third-party program that depends on the "real behavior" ? Have you checked that Windows 2003 still passes this test? No, I don't.

Problem with change of DIDEVICEOBJECTDATA

2004-09-08 Thread Stefan Dösinger
Hello, I have a problem with the change of struct DIDEVICEOBJECTDATA in CVS: DIDEVICEOBJECTDATA now has size 20, but Settler 3 still calls SysMouseAImpl_GetDeviceData with dodsize=16 and complains about the returned error. Stefan Dösinger

Re: UltimaOnLine: X11DRV_CritSection deadlock

2004-09-08 Thread Roger Olson
James Hawkins Wrote: > Maybe I'm confused, but if you're running a win32 setiathome binary on > wine, you're better off downloading the linux binary and using that. The United Devices Agent is a Setiathome like app except it processes chemical interactions between protiens and drug molecules in a

Re: UltimaOnLine: X11DRV_CritSection deadlock

2004-09-08 Thread James Hawkins
> I have a setiathome type app Maybe I'm confused, but if you're running a win32 setiathome binary on wine, you're better off downloading the linux binary and using that. On Wed, 8 Sep 2004 09:57:56 -0700, Roger Olson <[EMAIL PROTECTED]> wrote: > > Diego 'Flameeyes' Pettenò Wrote: > > > > But t

Re: PATCH: use standard offsetof()

2004-09-08 Thread Alexandre Julliard
Dominik Strasser <[EMAIL PROTECTED]> writes: > Follow these recommendations as you code: > > ... >Use the offsetof() macro to derive structure member > offsets. The offsetof() macro is in . > > > Which platforms are still not ANSI C nowadays ? I don't know about nowadays, but I know we en

Re: Revised menu patch

2004-09-08 Thread Michael Kaufmann
Hi Uwe Micheal, can we perhaps create a test case, that mimics the Delphi behaviour and succeeds on WinXX but fails on Wine? Then the behaviour is well documented and there is less reason to not fix it while breaking another test. Yes, that's a good idea! I've attached a test case that fails onl

Re: rejected patch? libw32sys.so linked to win32s/libw32skrnl.so

2004-09-08 Thread James Hawkins
Recently when I've tried to set a dll override to native, it wouldn't work if the native dll was in the windows\system directory. When I moved the dll to the folder that contained the executable, then the override was honored. Is this a regression, expected behavior, or an error on the part of th

Re: dinput axis mapping and format mapping patch

2004-09-08 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > Hmm, we're going to have to move all the registry keys? I thought we > were just going to convert Software/Wine/Wine into a standard key > rather than loaded at startup. No, the keys will be moved, so that we can handle the transition properly. > If we're

Re: UltimaOnLine: X11DRV_CritSection deadlock

2004-09-08 Thread Roger Olson
Diego 'Flameeyes' Pettenò Wrote: > > But the true problem is that if I'm idle for some time, I get this error, > and kde stops responding at mouse (and sometimes also keyboard) events: I have a setiathome type app (United Devices) that processes data in the background. While it's bg processing,

Re: PATCH: use standard offsetof()

2004-09-08 Thread Dominik Strasser
Alexandre Julliard wrote: Marcus Meissner <[EMAIL PROTECTED]> writes: gcc 3.5 no longer likes our own OFFSETOF() macro in winebuild, so we should use the standard one from Not all platforms have offsetof (or even stddef.h). What's wrong with our definition? offsetof is ANSI C, see http://www.par

Re: epoll patch - status?

2004-09-08 Thread Mike McCormack
Shachar Shemesh wrote: After a discussion with Alexandre on IRC I came to the conclusion that nothing I will do will make this patch go in. Mike, please add it to your list of "uncommitted patches". Hi Shachar, I'm not sure which Mike the above is addressed at... :) I agree epoll is something wor

Re: test.winehq.org site

2004-09-08 Thread Dimitrie O. Paun
On Wed, Sep 08, 2004 at 06:32:31PM +0200, Saulius Krasuckas wrote: > When can we expect it to be up and running? It is up and running, we're just missing an index page. Until that gets created, use this link instead: http://test.winehq.org/data/ Unfortunately, the testing process has bee

test.winehq.org site

2004-09-08 Thread Saulius Krasuckas
On Wed, 8 Sep 2004, Dmitry Timoshkov wrote: > "Michael Kaufmann" <[EMAIL PROTECTED]> wrote: > > Have you checked that Windows 2003 still passes this test? > > No, I don't. For exactly that reason we have http://test.winehq.org > where the results of the current test suite are posted. And where so

rejected patch? libw32sys.so linked to win32s/libw32skrnl.so

2004-09-08 Thread Peter Petrakis
Hello All, Citing this email from way back in 2000. http://www.mail-archive.com/wine-devel%40winehq.com/msg00914.html Talks about a crash when capture.exe is run from the orcad suite. I'm using orcad lite 9.2 (student edition), I can get everything to work except capture. I've upgraded to the la

Re: Acknowledgement page

2004-09-08 Thread Dimitrie O. Paun
On Sat, Sep 04, 2004 at 04:37:52PM -0600, Brian Vincent wrote: > Should have explained that bit.. anyone listed on the Who's Who > page doesn't show up here. This list will fall right under that on > the introduction page.. but perhaps I need to add a reference back > to the Who's Who page. I t

Re: Revised menu patch

2004-09-08 Thread Mike Hearn
> Until then, many > Delphi apps won't work. For me, this is not acceptable. For me, it's not acceptable to debate an inclusion of a not acceptable solution, there were enough explanations why it's not acceptable. You are welcome to fix it properly though. Please don't take my words offensively,

Re: Simple bugzilla question

2004-09-08 Thread Dimitrie O. Paun
On Wed, Aug 25, 2004 at 07:23:44PM +0100, Ann and Jason Edmeades wrote: > My understanding is I accept it and assign to myself, then fix it, then > what... Do I put the bug in fixed state and submit the patch or leave that > change to the raised? You submit the patch to wine-patches, and then add

Re: Revised menu patch

2004-09-08 Thread Dmitry Timoshkov
"Michael Kaufmann" <[EMAIL PROTECTED]> wrote: > How do you define the "real behavior" ? That's a behaviour of an existing product that could be tested and confirmed. > The behavior of Windows XP? Including it as well. > Have > you checked that Windows 2003 still passes this test? No, I don't

DirectInput suggestion

2004-09-08 Thread Jonathan Wilson
I dont know how this stuff works on linux so my suggestion may be wrong but here goes. Basicly, my suggestion is that any joystick that is visible to linux apps be made visible to windows apps via DirectInput joystick APIs. This eliminates the need for WINE to care about USB and such.

Re: Settlers 3: bug in NTDLL_get_server_timeout??

2004-09-08 Thread Stefan Dösinger
> My patch of yesterday addresses this problem. A fix should be committed > shortly. > > http://www.winehq.com/hypermail/wine-patches/2004/09/0098.html Yes, exactly the same issue. I'll watch the wine lists and wait for a bugfix. I can start s3 with disabling the call to NTDLL_get_server_timeout.

Re: Allow assignment of olefonts to other olefonts

2004-09-08 Thread Mike Hearn
Seems like you don't release the interface pointer that you do a query interface on. Oops. You shouldn't need to special case copying from the same object... just make sure you always allocate a new piece of memory and copy the old string name before freeing it. Yeah. I put that in because it's

Re: Revised menu patch

2004-09-08 Thread Uwe Bonnes
> "Michael" == Michael Kaufmann <[EMAIL PROTECTED]> writes: ... Michael> I promise that I'll remember you to reactivate this Michael> testcase. If we don't modify DestroyMenu NOW, there's also a Michael> good chance that this bug will never be fixed. Remember, a lot Michael> o

Re: Allow assignment of olefonts to other olefonts

2004-09-08 Thread Mike McCormack
ChangeLog: Allow assignment of olefonts to other olefonts Seems like you don't release the interface pointer that you do a query interface on. You shouldn't need to special case copying from the same object... just make sure you always allocate a new piece of memory and copy the old string nam

Re: epoll patch - status?

2004-09-08 Thread Andreas Mohr
Hi, On Wed, Sep 08, 2004 at 12:22:53PM +0300, Shachar Shemesh wrote: > After a discussion with Alexandre on IRC I came to the conclusion that > nothing I will do will make this patch go in. Mike, please add it to > your list of "uncommitted patches". I'm a bit sad to hear that. After all epoll()

Re: epoll patch - status?

2004-09-08 Thread Mike Hearn
After a discussion with Alexandre on IRC I came to the conclusion that nothing I will do will make this patch go in. Mike, please add it to your list of "uncommitted patches". There is such a list? If so then Mike, could you add my systray patch and debug delay patch? I'm always losing the links

Re: Revised menu patch

2004-09-08 Thread Michael Kaufmann
Hi Dmitry My last menu patch didn't pass a test case. I've commented out this test case, because it tests undocumented behavior. That's a very bad idea, then you need to comment out half of the test cases in Wine. The tests show *the real* behaviour, it doesn't really matter whether it's docu

Re: Allow assignment of olefonts to other olefonts

2004-09-08 Thread Mike Hearn
Alexandre, is there anything wrong with this patch? ChangeLog: Allow assignment of olefonts to other olefonts

Re: epoll patch - status?

2004-09-08 Thread Shachar Shemesh
Alexandre Julliard wrote: Shachar Shemesh <[EMAIL PROTECTED]> writes: I'm sorry for being a pest about this. I was wondering whether there is anything that needs to be done on that one in order to facilitate committing this patch? It needs some cleaning up, you need to find a way to make fe

Re: dinput axis mapping and format mapping patch

2004-09-08 Thread Mike Hearn
You should add this in the registry instead of the config file, this way we won't have to move it later on. HKLM/Software/Wine/Dinput should be a good place for it. Hmm, we're going to have to move all the registry keys? I thought we were just going to convert Software/Wine/Wine into a standard ke