Re: wine/dlls/ntdll time.c

2004-10-19 Thread Rein Klazes
On Mon, 18 Oct 2004 18:00:27 -0400, you wrote: > On Mon, Oct 18, 2004 at 04:19:29PM -0500, Alexandre Julliard wrote: > > Log message: > > Rein Klazes <[EMAIL PROTECTED]> > > In RtlQueryTimezoneInformation use information from the registry if it > > is available. > > > > Patch: http://

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Boaz Harrosh
Mike McCormack wrote: ChangeLog: * add epoll implementation to libwine_port +__asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl %%ebx" Grate ! [Q] Does that mean that we directly check if it is supported in kernel, bypassing glibc all together? how do we avoid conf

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Mike McCormack
Boaz Harrosh wrote: [Q] Does that mean that we directly check if it is supported in kernel, bypassing glibc all together? how do we avoid conflicts with glibc? The definitions are wrapped by #ifndef HAVE_EPOLL_CREATE, which is set by a configure check. The end result is that we use this code if

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Shachar Shemesh
Mike McCormack wrote: Boaz Harrosh wrote: [Q] Does that mean that we directly check if it is supported in kernel, bypassing glibc all together? how do we avoid conflicts with glibc? The definitions are wrapped by #ifndef HAVE_EPOLL_CREATE, which is set by a configure check. The end result is t

dlls/x11drv/winpos.c::SWP_DoOwnedPopups

2004-10-19 Thread Peter Riocreux
I have a lot of WARNs from this function so I thought I would have a shufty at it to see if it was easy to fix. The FIXME above it is written so as to suggest that it is a matter of mere keystrokes to fix it up, or weeks of work, depending on your frame of mind when you read it. Still being a be

Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups

2004-10-19 Thread Peter Riocreux
Peter Riocreux <[EMAIL PROTECTED]> writes: > I have a lot of WARNs from this function so I thought I would have a > shufty at it to see if it was easy to fix. > > The FIXME above it is written so as to suggest that it is a matter of > mere keystrokes to fix it up, or weeks of work, depending on y

Re: Turn off Antialiasing for Rendering with Palette

2004-10-19 Thread Glenn Wurster
> You shouldn't change the global antialias flag, this is ugly and it > will most likely break the font caching. You have to add checks for a > palette directly at the places that handle the anti-aliasing (and your > palette check is wrong too, you shouldn't peek into the internals of > the DC bitm

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Mike McCormack
Shachar Shemesh wrote: You do realize that many (somewhat old) glibcs have epoll_create defined that is hardwired to return E_NOSYS without calling the kernel, right? It won't do any worse than the code that is already there now, as we fall through to the select code if epoll_create returns an er

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Marcus Meissner
On Wed, Oct 20, 2004 at 02:32:53AM +0900, Mike McCormack wrote: > > Shachar Shemesh wrote: > > >You do realize that many (somewhat old) glibcs have epoll_create defined > >that is hardwired to return E_NOSYS without calling the kernel, right? > > It won't do any worse than the code that is alre

DrawTextA: regarding the nCount variable

2004-10-19 Thread William Poetra Yoga H
In the MSDN, it is stated that if nCount is 1, then it is assumed that lpString is a null-terminated string. But in the DrawTextExA function, it is -1, as in the code: if (count == -1) count = strlen(str); Shouldn't this be 1 instead of -1? CMIIW. (But theForger's tutorial also uses -1)

Re: DrawTextA: regarding the nCount variable

2004-10-19 Thread James Hawkins
Is there a way you can add a test case for this to wine's test suite? That would be the easiest way to find an answer. Sometimes msdn is wrong, but a test will find out. On Tue, 19 Oct 2004 09:39:10 -0700 (PDT), William Poetra Yoga H <[EMAIL PROTECTED]> wrote: > In the MSDN, it is stated that i

Re: DrawTextA: regarding the nCount variable

2004-10-19 Thread Bill Medland
On October 19, 2004 09:39 am, William Poetra Yoga H wrote: > In the MSDN, In what MSDN? I presume you mean the msdn.microsoft.com site as at a certain date. > it is stated that if nCount is 1, Not in the MSDN CDs of January 2002; it is -1 there. > then it is assumed that > lpString is a null-

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Boaz Harrosh
Mike McCormack wrote: But first I'd like to try and get this more simple improvement accepted into the CVS. Amen

Re: Startmenu

2004-10-19 Thread Thorsten Kani
...now with screenshots included. Hi, I took a look at the Startmenu. It does its job except for the following minor problems: -Keyboard input is completely ignored -Icon Backgrounds are white instead of grey -All the Icons were drawn a few pixels below where they belong, wich makes them a bit o

Re: Startmenu

2004-10-19 Thread Robert Shearman
Thorsten Kani wrote: ...now with screenshots included. Hi, I took a look at the Startmenu. It does its job except for the following minor problems: -Keyboard input is completely ignored -Icon Backgrounds are white instead of grey -All the Icons were drawn a few pixels below where they belong, wic

Re: add epoll implementation to libwine_port (take 3)

2004-10-19 Thread Chris Dodd
Mike McCormack <[EMAIL PROTECTED]> wrote in news:[EMAIL PROTECTED]: > A few more changes after consulting with Alexandre. > > ChangeLog: > * add epoll implementation to libwine_port : > +__asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl > %%ebx" +