Re: wine/dlls/user button.c

2004-10-25 Thread Mike McCormack
Hi Dimi, The following hunk of the patch below breaks the IE install. You should be able to press Alt-A to accept the license in the first dialog, but with this hunk applied it no longer works. Mike Index: wine/dlls/user/button.c diff -u wine/dlls/user/button.c:1.2 wine/dlls/user/button.c:1.3

Re: WSCEnumProtocols, was _SHExpandEnvironmentStrings() should return input string if no % found to expand?

2004-10-25 Thread Rolf Kalbermatter
James Hawkins wrote: No, it will work. The cast probably there because the original author didn't want to write two functions. Instead he added a bool to the internal function that specifies whether the buffer is unicode or not. The cast is then needed to keep the compiler happy. The fact

Re: Functions For Helping FillRect

2004-10-25 Thread William Poetra Yoga H
--- Dimitrie O. Paun [EMAIL PROTECTED] wrote: This is OK, the rect functions are consistent with the rest of the GUI functions (I would also add that not including the right and bottom borders is a good thing, but let's not debate that). Anyway, even if the standard APIs were awkward, in

Re: Functions For Helping FillRect (Correction)

2004-10-25 Thread William Poetra Yoga H
--- Vincent Béron [EMAIL PROTECTED] wrote: You're passing a struct by value. If you want the caller to have his structure to be modified, you need to pass it by ref. Vincent No, I don't want the original structure to be modified. I want to return a structure from the function, a

Problems With MSI

2004-10-25 Thread Joaquín Fernández
Hello... i am having problems installing program with MSI Installer. When i launch setup.exe, the installer begin the process and when finish of copy files (progress bar is 100%), stay in endless loop. I ran serveral programs using MSI installer but nothing, all hangs at end of copy files. I

Re: unaligned access bug in winspool on sparc

2004-10-25 Thread Eric Frias
Juan Lang a écrit : Yikes. That's a bad one. The trouble is MS loves this sort of return value. Even if the dll itself doesn't dereference an unaligned pointer, the caller might depending on how things are layed out. The trouble is i386 allows unaligned memory access, so we don't see

Re: unaligned access bug in winspool on sparc

2004-10-25 Thread Juan Lang
--- Eric Frias [EMAIL PROTECTED] wrote: I did some more reading, and found there's a way to get the kernel to install a handler for unaligned accesses which will synthesize the unaligned access with two aligned accesses, and then jump back to the original point in the code. Interesting.

Problems downloading the RedHat packages

2004-10-25 Thread Bill Medland
I am unable to download the RedHat 20041019 packages; any idea why? (Did they get built?) I can download a SuSE one (well, it at least asks me if I want to save it) but for all the Red Hat ones I've tried the mirror page keeps repeatedly coming up and it never actually tries to download. --

Re: wine/dlls/user button.c

2004-10-25 Thread Dimitrie O. Paun
On Mon, Oct 25, 2004 at 05:38:01PM +0900, Mike McCormack wrote: Hi Dimi, The following hunk of the patch below breaks the IE install. You should be able to press Alt-A to accept the license in the first dialog, but with this hunk applied it no longer works. Thank you, I'll submit a

Re: unaligned access bug in winspool on sparc

2004-10-25 Thread Alexandre Julliard
Juan Lang [EMAIL PROTECTED] writes: Do you feel it's reasonable just to turn on ST_FIX_ALIGN, which *could* mask errors both in wine and in the user's code? It may indeed. The masking problems in user code bothers me, though, since you're using winelib and you may not have a program which

Re: Functions For Helping FillRect

2004-10-25 Thread Alexandre Julliard
William Poetra Yoga H [EMAIL PROTECTED] writes: Um... OK, so the correct code is to add 1 to the sides, right? I mean, to draw the 50x75 rectangle we would do: r.left = 10; r.top = 10; r.right = 61; r.bottom = 86; FillRect(hdc, r, hbr); And for everything else when we have an x by y

Re: Problems downloading the RedHat packages

2004-10-25 Thread Vincent Béron
Le lun 25/10/2004 à 13:57, Bill Medland a écrit : I am unable to download the RedHat 20041019 packages; any idea why? (Did they get built?) I can download a SuSE one (well, it at least asks me if I want to save it) but for all the Red Hat ones I've tried the mirror page keeps repeatedly

Re: WSCEnumProtocols

2004-10-25 Thread Alexandre Julliard
Hans Leidekker [EMAIL PROTECTED] writes: +INT WINAPI WSAEnumProtocolsA( LPINT lpiProtocols, LPWSAPROTOCOL_INFOA lpBuffer, LPDWORD lpdwLength ) +{ + return WINSOCK_EnumProtocols( lpiProtocols, (WSAPROTOCOL_INFOW *)lpBuffer, lpdwLength, FALSE ); +} You cannot cast a WSAPROTOCOL_INFOA* to

Re: Functions For Helping FillRect

2004-10-25 Thread William Poetra Yoga H
--- Alexandre Julliard [EMAIL PROTECTED] wrote: William Poetra Yoga H [EMAIL PROTECTED] writes: Um... OK, so the correct code is to add 1 to the sides, right? I mean, to draw the 50x75 rectangle we would do: r.left = 10; r.top = 10; r.right = 61; r.bottom = 86;

Re: rsaenh [beware: 27kB attachment]

2004-10-25 Thread Juan Lang
Hi Michael, some very brief feedback: 1. MD4, MD5, and SHA1 are now implemented in wine's advapi32. Please use these instead of OpenSSL's. 2. The regression tests should be written so they don't fail if OpenSSL isn't available. 3. Get rid of magic numbers: What do the values 0x36 and 0x5c mean

Re: Functions For Helping FillRect

2004-10-25 Thread Alexandre Julliard
William Poetra Yoga H [EMAIL PROTECTED] writes: Oh, so: r.left = 10; r.top = 10; r.right = 60; r.bottom = 85; FillRect(hdc, r, hbr); And for everything else when we have an x by y rectangle, we actually mean (x-1) by (y-1), is it OK to assume so? Am I correct? Will fill a 50x75

Re: Problems downloading the RedHat packages

2004-10-25 Thread Walt Ogburn
I can't download the RH 20041019 packages either: The mirror you've selected, telia.dl.sourceforge.net does not currently have the file you requested. - Walter On Mon, 25 Oct 2004, Bill Medland wrote: I am unable to download the RedHat 20041019 packages; any idea why? (Did they get built?)

Re: wine/dlls/user button.c

2004-10-25 Thread Dimitrie O. Paun
The thing is that the old code wasn't entirely correct too. Here is a test case + fix. Thanks a lot Dmitry, I got carried away with some other stuff. -- Dimi.

Re: Functions For Helping FillRect

2004-10-25 Thread William Poetra Yoga H
--- Alexandre Julliard [EMAIL PROTECTED] wrote: And, is my second assumption correct, btw? I mean, x = r.right - r.left + 1 y = r.bottom - r.top + 1 I'm not sure what you mean, it seems you are trying to think too hard about it; just don't worry about doing +1/-1, that should never be