Re: advpack: add two missing stubs

2005-01-10 Thread Dmitry Timoshkov
"Steven Edwards" <[EMAIL PROTECTED]> wrote: > --- Robert Reif <[EMAIL PROTECTED]> wrote: > > Some of the new code was borrowed from reactos. GetVersionFromFile* > > Its nice to note where the code came from. We always try to do it in ReactOS > so please credit Jim > for his advpack function. It

Re: Correction to COINIT_MULTITHREADED test

2005-01-10 Thread Paul Vriens
On Mon, 2005-01-10 at 21:20, Bill Medland wrote: > Bill Medland ([EMAIL PROTECTED]) > Correct testing for multithreaded > (as spotted by Paul Vriens; fix suggested by Robert Shearman) > Hi Bill, it wasn't the check that was way over my head. The thing is, that with this code change we walk a new

Re: Minor wine-devel DCOM corrections

2005-01-10 Thread Dan Kegel
Rob Shearman wrote: We have a number of marshaling tests in our test framework at the moment (in wine/dlls/ole32/tests/marshal.c). It is hard to do anything cross-process (or cross-machine!) because of the way the test framework is done. Mike did suggest using environment variables to hack aroun

Re: advpack: add two missing stubs

2005-01-10 Thread Steven Edwards
--- Robert Reif <[EMAIL PROTECTED]> wrote: > Some of the new code was borrowed from reactos. GetVersionFromFile* Its nice to note where the code came from. We always try to do it in ReactOS so please credit Jim for his advpack function. Thanks Steven ___

Re: Palm OS Desktop & Wine

2005-01-10 Thread Hiji
--- [EMAIL PROTECTED] wrote: > Hiji wrote: > > Ah, but my friend, in the Wine-Users alias we > > established that it should follow the trend of the > > thread. In this thread, I started the trend as a > > "top-post". > > > > So, I should ask you (in this specific thread), > > "Please don't bott

Re: advpack: add two missing stubs

2005-01-10 Thread Robert Reif
Rob Shearman wrote: I think you forgot to include the tests. Rob Past my bed time. diff -u -N wine.cvs/dlls/advpack/tests/advpack.c wine/dlls/advpack/tests/advpack.c --- wine.cvs/dlls/advpack/tests/advpack.c 1969-12-31 19:00:00.0 -0500 +++ wine/dlls/advpack/tests/advpack.c 2005-01

Re: advpack: add two missing stubs

2005-01-10 Thread Robert Reif
Robert Reif wrote: Robert Reif wrote: Add stubs for NeedReboot and NeedRebootInit. without FIXME bug This time with three more functions implemented and some tests. Some of the new code was borrowed from reactos. GetVersionFromFile* is badly broken in reactos so I don't really trust IsNTAdmin. I o

Re: Palm OS Desktop & Wine

2005-01-10 Thread tony_lambregts
Hiji wrote: Ah, but my friend, in the Wine-Users alias we established that it should follow the trend of the thread. In this thread, I started the trend as a "top-post". So, I should ask you (in this specific thread), "Please don't bottom-post." hehehe. ;) About USB... Isn't it working (at minimu

Re: wine alsa detection

2005-01-10 Thread Vincent Béron
Le lun 10/01/2005 à 19:53, Vincent Béron a écrit : > Le lun 10/01/2005 à 05:16, Joris Huizer a écrit : > > Hello, > > > > Today I switched back to alsa 0.9 (downgraded everything that had to do > > with alsa 1.0 as far as I can tell) but still, alsa is detected as > > available: > > > > checkin

Re: advpack: add two missing stubs

2005-01-10 Thread Robert Reif
Robert Reif wrote: Add stubs for NeedReboot and NeedRebootInit. without FIXME bug Index: dlls/advpack/advpack.c === RCS file: /home/wine/wine/dlls/advpack/advpack.c,v retrieving revision 1.6 diff -u -r1.6 advpack.c --- dlls/advpack/adv

Re: wine alsa detection

2005-01-10 Thread Vincent Béron
Le lun 10/01/2005 à 05:16, Joris Huizer a écrit : > Hello, > > Today I switched back to alsa 0.9 (downgraded everything that had to do > with alsa 1.0 as far as I can tell) but still, alsa is detected as > available: > > checking alsa/asoundlib.h usability... yes > checking alsa/asoundlib.h pre

Re: Palm OS Desktop & Wine

2005-01-10 Thread Hiji
Ah, but my friend, in the Wine-Users alias we established that it should follow the trend of the thread. In this thread, I started the trend as a "top-post". So, I should ask you (in this specific thread), "Please don't bottom-post." hehehe. ;) About USB... Isn't it working (at minimum) with iT

Re: [LOSTWAGES] Add regedit janitorial project

2005-01-10 Thread Francois Gouget
On Mon, 10 Jan 2005, Mike McCormack wrote: Steven Edwards wrote: Maybe we need to keep a list of weekend coder projects. The aim is to lower the barrier of entry to the project by pointing out very specific, focused taskes that newcomers with programming experience can do. I had a slightly differe

WineConf 2005

2005-01-10 Thread Brian Vincent
WINECONF 2005 GOES TO EUROPE! We have a tentative reservation for Wineconf and we'd like some feedback regarding dates and times: WHERE: Stuttgart, Germany WHEN: April 30 / May 1st (plan on arriving April 29th) We realize it's not possible to accomodate everyone's schedule, but these dates seem

RtlQueryRegistryValues implementation, probably not prefect but makes safedisc happy

2005-01-10 Thread Ivan Leo Puoti
I've attempted to implement RtlQueryRegistryValues() This code is probably buggy, as I haven't tested it much, but it makes safedisc happy. If it's OK I'll send a patch to add it to ntdll, ntoskrnl will then forward calls. comments/corrections/thoughts welcome. Ivan. /* * Copyright 2004-2005 Mar

Re: Palm OS Desktop & Wine

2005-01-10 Thread Ivan Leo Puoti
Hiji wrote: I've never done this, but thinking on a more fundamental level, USB isn't fully supported under Wine. So, I'm assuming your PDA relies on a USB connection. So, even if you got the application to run, chances are, you couldn't sync with your device. :S I could be wrong, but this is my

Re: Palm OS Desktop & Wine

2005-01-10 Thread Hiji
I've never done this, but thinking on a more fundamental level, USB isn't fully supported under Wine. So, I'm assuming your PDA relies on a USB connection. So, even if you got the application to run, chances are, you couldn't sync with your device. :S I could be wrong, but this is my understandi

Palm OS Desktop & Wine

2005-01-10 Thread FyD
Dear All, I have a Tungsten E PDA and use K-pilot/J-pilot to backup/restore/install .pdb/.prc files with my linux box. No problem for that. => However, I would like to install a .pdf viewer on my PDA and the files provided for this installation are not .pdb/.prc files but a Windows executable file

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Bill Medland
On January 10, 2005 11:40 am, Robert Shearman wrote: > Paul Vriens wrote: > >On Mon, 2005-01-10 at 18:02, Robert Shearman wrote: > >>The parameter to CoInitializeEx is of type COINIT and so the caller can > >> also specify another flag like COINIT_DISABLE_OLE1DDE along with the > >> apartment flag.

Re: comctl32.dll and commctrl.dll

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 13:51:02 -0600, Robert Shearman wrote: > What toolbar regression? There is no toolbar regression. There never > will be any toolbar regressions. *blink* *blink* There is no toolbar regression. These are not the regressions we're looking for. You can go about your business

Re: Minor wine-devel DCOM corrections

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 11:30:16 -0800, Bill Medland wrote: > Hi Mike > > It was sort-of-helpful to me. Didn't really teach me anything I didn't > already understand but I think it is a good introduction. It lays the > groundwork and the nomenclature for further discussions. Yeah it's all fairly ba

Re: comctl32.dll and commctrl.dll

2005-01-10 Thread Robert Shearman
Mike Hearn wrote: comctl32 is *really* close these days. I hardly ever run with native anymore, sure there are bugs and the rebar control is pretty b0rked, and I guess Rob needs to go look at the toolbar regression before we get dragged back to COM work but these days it's so nearly there! What

Re: Minor wine-devel DCOM corrections

2005-01-10 Thread Robert Shearman
Bill Medland wrote: Did we ever get anywhere with adding some sort of DCOM-testing framework into the tests? I can't remember if it was you or Robert that mentioned resurrecting a test program. We have a number of marshaling tests in our test framework at the moment (in wine/dlls/ole32/tests

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Robert Shearman
Paul Vriens wrote: On Mon, 2005-01-10 at 18:02, Robert Shearman wrote: The parameter to CoInitializeEx is of type COINIT and so the caller can also specify another flag like COINIT_DISABLE_OLE1DDE along with the apartment flag. So we either need to convert the values to booleans before we call t

Re: Fwd: Foobar2000 audio player Regression

2005-01-10 Thread Robert Shearman
Nick Hornback wrote: Foobar2000 worked virtually perfectly in the 20041019 release, aside from some comctrl32 repainting issues -- which native comctrl32.dll fixed. In 20041201 it is completely unuseable. Two major problems: 1) The toolbars are completely gone. They are sort of displayed when they

Re: Minor wine-devel DCOM corrections

2005-01-10 Thread Bill Medland
On January 10, 2005 11:08 am, Mike Hearn wrote: > On Mon, 10 Jan 2005 10:56:30 -0800, Bill Medland wrote: > > Bill Medland ([EMAIL PROTECTED]) > > Minor typo correction and term expansion changes > > Bill, if that document was helpful I'll write some more docs for you. Hi Mike It was sort-of-helpf

Re: Use Interlocked* functions

2005-01-10 Thread Joris Huizer
Mike Hearn wrote: On Mon, 10 Jan 2005 18:03:30 +0100, Joris Huizer wrote: Paul Vriens was posting patches in which references to This->ref in TRACE calls were replaced by a variable containing the value of This->ref - I can't remember why this was necessary, but I don't think he's doing it just

Re: Minor wine-devel DCOM corrections

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 10:56:30 -0800, Bill Medland wrote: > Bill Medland ([EMAIL PROTECTED]) > Minor typo correction and term expansion changes Bill, if that document was helpful I'll write some more docs for you.

Re: ntdll / kernel32 : #52 (take #2)

2005-01-10 Thread Alexandre Julliard
Eric Pouech <[EMAIL PROTECTED]> writes: > +/** > + * NtAddAtom (NTDLL.@) > + */ > +NTSTATUS WINAPI NtAddAtom( const WCHAR* name, ULONG name_len, ATOM* atom ) > +{ > +return RtlAddAtomToAtomTable( get_global_table(), name

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Mike Hearn
On Mon, 2005-01-10 at 11:31 -0600, Robert Shearman wrote: > You don't need to add these unnecessary brackets. They add nothing to > the readability of the code. I normally wouldn't but the code style in that section is to avoid stuff like this: if (foo) bar else { baz } which I

Re: comctl32.dll and commctrl.dll

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 11:11:01 +0100, Dripple wrote: > I do agree with you... The point is I'd love to write a how-to run this > app without any windiws license. Which does not mean I do not have a > legal license here... ;-) Ideally what we need is not more HOWTOs, but rather to fix the bugs in o

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Robert Shearman
Mike Hearn wrote: ... static NTSTATUS load_dll( LPCWSTR load_path, LPCWSTR libname, DWORD flags, WINE_MODREF** pwm ); static FARPROC find_named_export( HMODULE module, const IMAGE_EXPORT_DIRECTORY *exports, @@ -893,9 +894,17 @@ static NTSTATUS process_attach( WINE_MOD WINE_MODREF *prev = cu

Re: Use Interlocked* functions

2005-01-10 Thread Rob Shearman
Mike McCormack wrote: The most important reason in my mind to do this is so that people implementing objects in the future copy code that uses the Interlocked* functions. There's no overhead to using those functions... no penalty if we use them in code that doesn't need to be thread safe, so w

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Paul Vriens
On Mon, 2005-01-10 at 18:02, Robert Shearman wrote: > Paul Vriens wrote: > > >Hi, > > > >while looking through the code I saw: > > > >if (model & COINIT_MULTITHREADED) > > > >this will never work as COINIT_MULTITHREADED = 0. > > > > > > Good catch. > > >The attached patch fixes the 3 occurrenc

Re: Use Interlocked* functions

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 18:03:30 +0100, Joris Huizer wrote: > Paul Vriens was posting patches in which references to This->ref in > TRACE calls were replaced by a variable containing the value of > This->ref - I can't remember why this was necessary, but I don't think > he's doing it just for the fu

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Mike Hearn
On Mon, 2005-01-10 at 17:19 +0100, Alexandre Julliard wrote: > It needs to be at most a warning, attach failures can legitimately > happen. OK, here's a better patch fixed w.r.t what we talked about on IRC. Give a more informative error when a DLL fails to initialize during startup Index: dlls

Re: Use Interlocked* functions

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 22:42:22 +, Mike McCormack wrote: > Well, it's true that some objects don't need to be thread safe, however > it's not recorded anywhere in the Wine source which object need to be > thread safe and which don't. That info is usually available in MSDN or the registry. But I

Re: [LOSTWAGES] Add regedit janitorial project

2005-01-10 Thread Mike McCormack
Steven Edwards wrote: Maybe we need to keep a list of weekend coder projects. The aim is to lower the barrier of entry to the project by pointing out very specific, focused taskes that newcomers with programming experience can do. I think the Janitorial list is already a place where people can f

Re: Use Interlocked* functions

2005-01-10 Thread Joris Huizer
Mike Hearn wrote: On Mon, 10 Jan 2005 11:38:20 +0100, Joris Huizer wrote: To see how far we are, I tried grepping to get This->refs stuff grep -r -n -e 'TRACE(.*This->ref)' * grep -r -n "++(This->ref)" * grep -r -n -- "--(This->ref)" * I hope there are a lot of false positives there :-/ You re

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Robert Shearman
Paul Vriens wrote: Hi, while looking through the code I saw: if (model & COINIT_MULTITHREADED) this will never work as COINIT_MULTITHREADED = 0. Good catch. The attached patch fixes the 3 occurrences of a check against COINIT_*. This patch however makes the COM_CreateApartment in compobj.c: 5

Re: WININET: implement InternetTime{From,To}SystemTime{A,W} (#2)

2005-01-10 Thread Dmitry Timoshkov
"Hans Leidekker" <[EMAIL PROTECTED]> wrote: > Changelog: > Implement and test InternetTime{From,To}SystemTime{A,W}. If you could also make the attached tests pass (applied over your tests) that would be great. The tests show that strings should be parsed a bit smarter and comparisons should be

ole32 : wrong check in compobj.c

2005-01-10 Thread Paul Vriens
Hi, while looking through the code I saw: if (model & COINIT_MULTITHREADED) this will never work as COINIT_MULTITHREADED = 0. The attached patch fixes the 3 occurrences of a check against COINIT_*. This patch however makes the COM_CreateApartment in compobj.c: 545 if (!(apt = COM_Curren

Re: Janitorial : Use Compiler Warnings ( -Wmissing-declarations ) ( #1 )

2005-01-10 Thread Alexandre Julliard
Rémi Assailly <[EMAIL PROTECTED]> writes: > Can we create "private" headers ? headers which will be only used in files > where > some declarations are missing ? No, at least not in this case. These are used in generated files that must not depend on other headers. -- Alexandre Julliard [EMAIL

Re: WININET: implement InternetTime{From,To}SystemTime{A,W} (#2)

2005-01-10 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > +/*** > + * InternetTimeFromSystemTimeW (WININET.@) > + * > + * NOTES > + * This is not an illegal W->A crosscall since internet dates are ASCII > strings. It would still b

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > This patch was missed, does it no longer apply? It needs to be at most a warning, attach failures can legitimately happen. > Also is it OK to just put the changelog as the first line of the email > like that? Sure. -- Alexandre Julliard [EMAIL PROTECTE

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Mike Hearn
Hi Alexandre, This patch was missed, does it no longer apply? Also is it OK to just put the changelog as the first line of the email like that? thanks -mike On Wed, 22 Dec 2004 18:19:47 +, Mike Hearn wrote: > Give a more informative error when a DLL fails to initialize > --- dlls/ntdll/load

Re: Switching to winecfg

2005-01-10 Thread Mike Hearn
On Sat, 08 Jan 2005 06:05:20 +0200, Crestez Leonard wrote: > I don't think that this needs a complex migration process, all we need > to do is save the wine config registry to $WINEPREFIX/config. If people > want their config file back, wine can skip saving the configuration if > it wasn't modified

Re: Janitorial : Use Compiler Warnings ( -Wmissing-declarations ) ( #1 )

2005-01-10 Thread Rémi Assailly
Selon Alexandre Julliard <[EMAIL PROTECTED]>: > Rémi Assailly <[EMAIL PROTECTED]> writes: > > > --- include/wine/library.h 2005-01-07 19:41:26.0 +0100 > > +++ include/wine/library.h 2005-01-07 19:49:41.389057824 +0100 > > @@ -42,6 +42,7 @@ > > extern void *wine_dlopen( const char *filen

Re: comctl32.dll and commctrl.dll

2005-01-10 Thread Dripple
I do agree with you... The point is I'd love to write a how-to run this app without any windiws license. Which does not mean I do not have a legal license here... ;-) Holly Bostick a écrit : Rob Shearman wrote: Dripple wrote: Hi all, I'm a newbie in wine using and wine developpement. I just need

Re: Native comctl32.dll and native commctrl.dll

2005-01-10 Thread Dripple
Do you want me to provide a extract of a WINEDEBUG=+dll run ? Vitaly Lipatov a Ãcrit : Ð ÑÐÐÐÑ ÐÑ 7 ÑÑ 2005 10:15 Dripple ÑÐÐ(a): I'm trying to have this app (http://appdb.winehq.org/appview.php?appId=1485&versionId=2451) working. In fact, it works. But only using native comctl32.dll,

typelib2.c problems

2005-01-10 Thread Gerald Pfeifer
The following change to dlls/oleaut32/typelib2.c revision 1.32 date: 2005/01/09 17:32:17; author: julliard; state: Exp; lines: +14 -14 Paul Vriens <[EMAIL PROTECTED]> - use Interlocked* functions in AddRef and Release. - store the result of the Interlocked functions and use only this.

Re: Use Interlocked* functions

2005-01-10 Thread Mike McCormack
Mike Hearn wrote: To be quite honest I'm not convinced this janitorial task is a good idea. It makes the code look at first glance like it's thread safe when it actually isn't. A better janitorial task would simply be "Make free-threaded COM objects thread safe" except that making code thread safe

Re: [LOSTWAGES] Add regedit janitorial project

2005-01-10 Thread Steven Edwards
--- Mike McCormack <[EMAIL PROTECTED]> wrote: > The people who I want to find it will be looking in "Janitorial". I'm > trying to create a list of stuff that people can pick up and do in a few > days, and keep it updated. Janitorial seems to be the appropriate place Maybe we need to keep a l

Re: Use Interlocked* functions

2005-01-10 Thread Mike Hearn
On Mon, 10 Jan 2005 11:38:20 +0100, Joris Huizer wrote: > To see how far we are, I tried grepping to get This->refs stuff > grep -r -n -e 'TRACE(.*This->ref)' * > grep -r -n "++(This->ref)" * > grep -r -n -- "--(This->ref)" * > > I hope there are a lot of false positives there :-/ You real

Use Interlocked* functions

2005-01-10 Thread Joris Huizer
To see how far we are, I tried grepping to get This->refs stuff grep -r -n -e 'TRACE(.*This->ref)' * grep -r -n "++(This->ref)" * grep -r -n -- "--(This->ref)" * I hope there are a lot of false positives there :-/ regards, Joris

wine alsa detection

2005-01-10 Thread Joris Huizer
Hello, Today I switched back to alsa 0.9 (downgraded everything that had to do with alsa 1.0 as far as I can tell) but still, alsa is detected as available: checking alsa/asoundlib.h usability... yes checking alsa/asoundlib.h presence... yes checking for alsa/asoundlib.h... yes checking for snd_