Re: Best DLLs to write conformance tests for?

2005-01-12 Thread Dan Kegel
Eric Pouech wrote: Well, there's still plenty of test cases that can be written for each DLL. Ideally we start from the bottom (ntdll, kernel, gdi, etc) with our test cases so that we can fix code in the dlls and programs that depend on those dlls. Following that line of thought, imagehlp (use

[COMCTL32] The use of the PGS_VERT flag

2005-01-12 Thread Paul Vriens
Hi, the flag PGS_VERT is zero and should not be checked against. It's only the lack of PGS_HORZ that should be checked. Is the following piece of code needed in dll//comctl32/pager.c: 851 if (!(dwStyle & PGS_HORZ) && !(dwStyle & PGS_VERT)) 852 { 853 dwStyle |= PGS_VER

Re: USER32: Implement SPI_{GET,SET}MINIMIZEDMETRICS

2005-01-12 Thread Mike McCormack
[EMAIL PROTECTED] wrote: *Implemented SPI_GETMINIMIZEDMETRICS calculated from values returned by GetSystemMetrics. The math applied to the values returned from GetSystemMetrics was verified against Windows 98 and XP using a simple test program. Yey for test programs :) Would you mind sending it

Re: [AppDB] Now User Preferences is Br0ck. (fix sort of?)

2005-01-12 Thread tony_lambregts
[EMAIL PROTECTED] wrote: It seems that adding a new user now works and so does editing a version. So thats the good news. The bad news is that user preferences is still broken with Current CVS. It gets a little farther and display's the versions box, but I get the following error message on my s

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Brian Vincent
On Thu, 13 Jan 2005 01:11:35 +, Paul Millar <[EMAIL PROTECTED]> wrote: > On Thursday 13 January 2005 00:41, Dimitrie O. Paun wrote: > > Hmm, that would be cool. For reasons I can not understand, I can > > not access Paul's site at www.astro.gla.ac.uk, so having them > > available somewhere else

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Dimitrie O. Paun
On Thu, Jan 13, 2005 at 02:24:21AM +0100, Ferenc Wagner wrote: > Can't you even ping the server? If not, what does > traceroute say? If yes, your IP number must be blacklisted > at Glasgow... ;) No, I can't ping either: [EMAIL PROTECTED] ~]$ ping www.astro.gla.ac.uk PING terra.astro.gla.ac.uk (

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Dimitrie O. Paun
On Thu, Jan 13, 2005 at 01:11:35AM +, Paul Millar wrote: > Could you do a bit more investigation, like "host > www.astro.gla.ac.uk"? Here you go: [EMAIL PROTECTED] ~]$ host www.astro.gla.ac.uk www.astro.gla.ac.uk is an alias for terra.astro.gla.ac.uk. terra.astro.gla.ac.uk has address 130.20

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]

2005-01-12 Thread Mike McCormack
Shachar Shemesh wrote: From what I understood from him, this had a lot to do with the "epoll" change I investigated some time back. I'll let Mike say whether that is so. There's a bug in the overlapped I/O code in file.c that means a normal file fd is added to the select() array and never remove

Re: [AppDB] Now User Preferences is Br0ck.

2005-01-12 Thread tony_lambregts
It seems that adding a new user now works and so does editing a version. So thats the good news. The bad news is that user preferences is still broken with Current CVS. It gets a little farther and display's the versions box, but I get the following error message on my system (line 35 of db.php

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Ferenc Wagner
Paul Millar <[EMAIL PROTECTED]> writes: > On Wednesday 12 January 2005 20:09, Stefan Leichter wrote: > >> Am Mittwoch, 12. Januar 2005 18:14 schrieb Dimitrie O. Paun: >> >>> Anyone knows what happened to the tests? >> >> [...] The attached patch fixes mingw for me. Hope i got the GUIDs >> right.

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Ferenc Wagner
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > For reasons I can not understand, I can not access Paul's > site at www.astro.gla.ac.uk Can't you even ping the server? If not, what does traceroute say? If yes, your IP number must be blacklisted at Glasgow... ;) -- Feri.

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Paul Millar
On Thursday 13 January 2005 00:41, Dimitrie O. Paun wrote: > Hmm, that would be cool. For reasons I can not understand, I can > not access Paul's site at www.astro.gla.ac.uk, so having them > available somewhere else would be very good for me. Yes, this problem again? I've never heard of problems

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Paul Millar
On Wednesday 12 January 2005 21:12, Ferenc Wagner wrote: > If Paul can use Stefan's patch, then new builds can be > expected real soon, I guess. Should be up tomorrow, all things being equal (and a following wind ;^) Paul. pgpcyHA6UAyeh.pgp Description: PGP signature

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Paul Millar
On Wednesday 12 January 2005 20:09, Stefan Leichter wrote: > Am Mittwoch, 12. Januar 2005 18:14 schrieb Dimitrie O. Paun: > > Anyone knows what happened to the tests? > > [...] The attached patch fixes mingw for me. Hope i got the GUIDs > right. > > As far i know the test are build at / uploaded

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Dimitrie O. Paun
On Wed, Jan 12, 2005 at 06:58:19PM -0500, Kevin Koltzau wrote: > I actually gave up keeping the sourceforge upload working, I am however > still building winetest. Sourceforge made some changes to their site that > broke sfutils. I had thought about hosting the builds on wine.sourceforge.net, > whi

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Dimitrie O. Paun
On Wed, Jan 12, 2005 at 05:29:36PM +, Mike Hearn wrote: > Is there a todo list of what needs to be done for winetest anywhere? This is what I had in mind: * We need a page under http://www.winehq.org/site/status (in the right-hand box) which should contain: -- an explanatio

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Kevin Koltzau
On Wednesday 12 January 2005 04:12 pm, Ferenc Wagner wrote: > Yes, looks like Kevin had to give up on cross building the > binaries a couple of months ago; it was he who updated the > SF downloads page. I actually gave up keeping the sourceforge upload working, I am however still building winetest

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]

2005-01-12 Thread André Goddard Rosa
On Wed, 12 Jan 2005 12:01:39 -0600, Jeremy White <[EMAIL PROTECTED]> wrote: > Fyi, > > I spent a great deal of time this past fall exploring Wine scheduling > issues, and I thought I would post what I learned. > WoW, thanks for this deeper explanation of your findings. This modifications will be

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Ferenc Wagner
Mike Hearn <[EMAIL PROTECTED]> writes: > On Wed, 12 Jan 2005 22:26:18 +0100, Ferenc Wagner wrote: > >> What makes you think I've got one? It should be *you* >> who speak up and tell what information/presentation is >> need for the best and easiest use. > > I basically did: some UI for test.winehq

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Mike Hearn
On Wed, 12 Jan 2005 22:26:18 +0100, Ferenc Wagner wrote: > What makes you think I've got one? It should be *you* who > speak up and tell what information/presentation is need for > the best and easiest use. I basically did: some UI for test.winehq.com to let you easily navigate the available buil

Re: The use of a zero flag

2005-01-12 Thread Dimitrie O. Paun
On Wed, Jan 12, 2005 at 09:04:20PM +0100, Paul Vriens wrote: > Is it worthwhile to set up a Janitorial task for this or are these plain > bugs? On the one hand it will be hard to find these and you have to know > the code of course. Yeah, I think it's worthwhile to look at such cases, but I don't

[AppDB] script to clean duplicate users

2005-01-12 Thread Jonathan Ernst
This script will remove duplicate users from the appdb (same email address), give their data to the most recently logged user that has the same email address and then fix the db structure so that it's not possible anymore to have two time the same email address. Usage: 1)chmod u+x ./clean.php 2)e

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Ferenc Wagner
Mike Hearn <[EMAIL PROTECTED]> writes: > On Wed, 12 Jan 2005 17:29:18 +0100, Ferenc Wagner wrote: > >> ChangeLog: * Generate valid HTML 4.01 Strict. >>* Underline vis_note class links, too. > > Groovy! Is there a todo list of what needs to be done for > winetest anywhere? I've got one

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Ferenc Wagner
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On Wed, Jan 12, 2005 at 05:29:18PM +0100, Ferenc Wagner wrote: > >> ChangeLog: * Generate valid HTML 4.01 Strict. >>* Underline vis_note class links, too. > > Cool stuff Feri. Anyone knows what happened to the tests? > The last one at ht

Re: [QUARTZ] Revert regsvr.c patch

2005-01-12 Thread Robert Shearman
Paul Vriens wrote: Hi, Christian made me aware of the following: --- As long as this object is not implemented, the FIXME should remain to remind us that something is missing from quartz. --- As 'Seeking' is not yet implemented I would like to have this patch reverted. Sorry for any inconvenience.

Re: Palm OS Desktop & Wine

2005-01-12 Thread Stefan Dösinger
> > The palm Desktop > > installer requires some playing with MSI, I don't remember exactly what I > > did. Note that you can't run the Palm Desktop application, but you can > > run hotsync.exe which is enought to get PDF files onto the palm. > > hotsync.exe: I guess you mean running the HotSync ic

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Stefan Leichter
Am Mittwoch, 12. Januar 2005 18:14 schrieb Dimitrie O. Paun: > Cool stuff Feri. Anyone knows what happened to the tests? > The last one at http://test.winehq.org/data/ is 2004-12-28. > Also, the last tests build at SF is winetest-200409111000 > which is a bit outdated :) > Well, since 2004-12-28 we

The use of a zero flag

2005-01-12 Thread Paul Vriens
Hi, a few days ago I found a bug in ole32/compobj.c where we did something like: if ( foo & FLAG) where FLAG=0 This 'inspired' me to check for more of these kind of checks. One that I already found is in dlls/dplayx/dplay.c We are checking for DPSET_REMOTE (which is zero) where we should

Re: [AppDB] create new users is Br0ck.

2005-01-12 Thread Jonathan Ernst
Le mercredi 12 janvier 2005 Ã 16:40 +0100, Paul van Schayck a Ãcrit : > Hey, > > I'm not entirely sure what's going wrong here either. I don't see any > functional change except from a mysql_connect() to a pconnect(). Which > shouldn't make a difference. After setting up the bugzilla tables and >

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]

2005-01-12 Thread Ove Kaaven
ons, 12,.01.2005 kl. 12.01 -0600, skrev Jeremy White: > Second, we did not synchronize Wine message times with X11 > message times properly. Fixing that resolved some issues > with Photoshop (and given that Ove reworked that patch into > WineX the same day I submitted it, I'd guess it fixed some >

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]

2005-01-12 Thread Shachar Shemesh
Jeremy White wrote: Fourth, the Wine server had an issue with the way it managed it request queues. To be honest, I don't understand this bug or the fix; all I know is that Mike McCormack figured this one out and posted a magic fix. This was, I believe, the primary reason that the wineserver woul

Re: Best DLLs to write conformance tests for?

2005-01-12 Thread Eric Pouech
Well, there's still plenty of test cases that can be written for each DLL. Ideally we start from the bottom (ntdll, kernel, gdi, etc) with our test cases so that we can fix code in the dlls and programs that depend on those dlls. Following that line of thought, imagehlp (used by winedbg), cabi

Re: [ck] Re: Threading issues? [ck-request@vds.kolivas.org: ck Digest, Vol 3, Issue 16]

2005-01-12 Thread Jeremy White
Fyi, I spent a great deal of time this past fall exploring Wine scheduling issues, and I thought I would post what I learned. The most critical point is Wine was pretty badly broken; it simply had a number of flaws in how scheduling was done. First, the winmm timer, used by a lot of programs, was p

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Mike Hearn
On Wed, 12 Jan 2005 17:29:18 +0100, Ferenc Wagner wrote: > ChangeLog: * Generate valid HTML 4.01 Strict. >* Underline vis_note class links, too. Groovy! Is there a todo list of what needs to be done for winetest anywhere? Going to http://test.winehq.com/ still yields an error, you have

Re: WineHQ:winetest: produce valid HTML

2005-01-12 Thread Dimitrie O. Paun
On Wed, Jan 12, 2005 at 05:29:18PM +0100, Ferenc Wagner wrote: > ChangeLog: * Generate valid HTML 4.01 Strict. >* Underline vis_note class links, too. Cool stuff Feri. Anyone knows what happened to the tests? The last one at http://test.winehq.org/data/ is 2004-12-28. Also, the last te

Re: [AppDB] create new users is Br0ck.

2005-01-12 Thread Tony Lambregts
Jonathan Ernst wrote: Le mardi 11 janvier 2005 Ã 21:25 -0700, [EMAIL PROTECTED] a Ãcrit : The last patch broke make_bugzilla_version_list() which is used by account.php and admin/editAppVersion.php. That means that new users can not create accounts and maintainers cannot edit their versions. ht

Re: [AppDB] create new users is Br0ck.

2005-01-12 Thread Paul van Schayck
Hey, I'm not entirely sure what's going wrong here either. I don't see any functional change except from a mysql_connect() to a pconnect(). Which shouldn't make a difference. After setting up the bugzilla tables and include/config.php it worked for me. Weird... I saw a patch from Jonathan tough c

Re: Janitorial : check all refcounts in Wine?

2005-01-12 Thread Mike Hearn
On Wed, 12 Jan 2005 14:42:53 +0100, Paul Vriens wrote: > If I however do a wider search I find a bit more, for example: > > kernel/atom.c:256: entryPtr->refCount++; No .. > msi/handle.c:188:ret = info->refcount--; I don't think so, handles are not COM objects and m

Janitorial : check all refcounts in Wine?

2005-01-12 Thread Paul Vriens
Hi, for the described Janitorial task 'Use Interlocked functions in AddRef and Release methods' I'm currently looking at This->ref. If I however do a wider search I find a bit more, for example: kernel/atom.c:256: entryPtr->refCount++; msi/handle.c:188:ret = info->r

Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-12 Thread Paul Vriens
> > One question remains though, what do I do with: > > /* also release reference to the nested stream */ > if (This->pStream != NULL) > IAVIStream_Release(This->pStream); > > should this be done regardless of the value of This->ref ? > Hi Michael, forget the question. I just saw that the