load_VDMX - is the check for bCharSet == -1 necessary?

2005-01-20 Thread Troy Rollo
In dlls/gdi/freetype.c, load_VDMX refuses to process ratio records in which bCharSet is 0. Looking at the meaning of bCharSet and the layout of the VDMX table , I can see no rational reason for this, and no reason appears in the code. Since 13t

Re: RtlQueryRegistryValues and RtlCheckRegistryKey

2005-01-20 Thread Robert Shearman
Ivan Leo Puoti wrote: Implement RtlQueryRegistryValues, RtlCheckRegistryKey is implemented in this patch as a free bonus. Thanks to the guys on IRC for their help. BTW when RtlCheckRegistryKey is called with the RTL_REGISTRY_HANDLE flag, it always returns STATUS_SUCCESS, even if called with NULL, a

Re: Fix heap corruption in quartz server registration

2005-01-20 Thread Paul Vriens
On Thu, 2005-01-20 at 22:21, Mike Hearn wrote: > On Thu, 2005-01-20 at 20:32 +0100, Paul Vriens wrote: > > Sorry, didn't help. > > > > I'm going to try Rob's suggestions now. > > This patch fixes it for me. > > Mike Hearn <[EMAIL PROTECTED]> > Fix heap corruption in quartz server registration, a

Fix heap corruption in quartz server registration

2005-01-20 Thread Mike Hearn
On Thu, 2005-01-20 at 20:32 +0100, Paul Vriens wrote: > Sorry, didn't help. > > I'm going to try Rob's suggestions now. This patch fixes it for me. Mike Hearn <[EMAIL PROTECTED]> Fix heap corruption in quartz server registration, add some whitespace, break out of loop if out of memory --- dlls/

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Mike Hearn
On Thu, 2005-01-20 at 20:32 +0100, Paul Vriens wrote: > Sorry, didn't help. > > I'm going to try Rob's suggestions now. Right, Alexandre just clued me in that anonymous mmaps are always zerod. Nice theory, but no cigar this time. I've been able to reproduce the bug (sometimes) and am narrowing it

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Paul Vriens
On Thu, 2005-01-20 at 20:17, Mike Hearn wrote: > On Thu, 20 Jan 2005 19:36:27 +0100, Paul Vriens wrote: > > When I do the same change now, the X Error is gone as well. Does this > > give you a clue? > > Could you try this patch please? > > --- dlls/ntdll/thread.c (revision 109) > +++ dlls/ntdll/

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Robert Shearman
Paul Vriens wrote: On Thu, 2005-01-20 at 18:21, Robert Shearman wrote: If it's heap corruption then it could well depend on the order of allocations, so it could be timing dependent. I've attached a patch that poisons the apartment structure after when it is freed so that hopefully any use-aft

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Mike Hearn
On Thu, 20 Jan 2005 19:36:27 +0100, Paul Vriens wrote: > When I do the same change now, the X Error is gone as well. Does this > give you a clue? Could you try this patch please? --- dlls/ntdll/thread.c (revision 109) +++ dlls/ntdll/thread.c (local) @@ -73,6 +73,7 @@ static TEB *alloc_teb( ULON

Re: wined3d updates

2005-01-20 Thread Ann and Jason Edmeades
Hi Oliver, D3DRESOURCETYPE WINAPI IWineD3DCubeTextureImpl_GetType(IWineD3DCubeTexture *iface) { -return IWineD3DResourceImpl_GetType((IWineD3DResource *)iface); +return IWineD3DResource_GetType((IWineD3DResource *)iface); } This is wrong (and others) - you'll end up in an infinite loop.

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Paul Vriens
On Thu, 2005-01-20 at 18:21, Robert Shearman wrote: > If it's heap corruption then it could well depend on the order of > allocations, so it could be timing dependent. > I've attached a patch that poisons the apartment structure after when it > is freed so that hopefully any use-after-free will b

Re: Font selection logic defective?

2005-01-20 Thread Bill Medland
On January 20, 2005 07:37 am, Bill Medland wrote: > On January 20, 2005 03:31 am, Huw D M Davies wrote: > > On Wed, Jan 19, 2005 at 05:58:59PM -0800, Bill Medland wrote: > > > On January 18, 2005 03:00 pm, Huw D M Davies wrote: > > > > On Tue, Jan 18, 2005 at 12:08:17PM -0800, Bill Medland wrote: >

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Paul Vriens
On Thu, 2005-01-20 at 18:21, Robert Shearman wrote: > If it's heap corruption then it could well depend on the order of > allocations, so it could be timing dependent. > I've attached a patch that poisons the apartment structure after when it > is freed so that hopefully any use-after-free will b

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Paul Vriens
On Thu, 2005-01-20 at 18:21, Robert Shearman wrote: > Paul Vriens wrote: > > >On Thu, 2005-01-20 at 11:47, Paul Vriens wrote: > > > > > >>On Wed, 2005-01-19 at 20:32, Alexandre Julliard wrote: > >> > >> > >>>Paul Vriens <[EMAIL PROTECTED]> writes: > >>> > >>> > >>> > and part of a

Re: Wine threads and TRY/CATCH macros and DCE threads and TRY/CATCH macros

2005-01-20 Thread Luke Kenneth Casson Leighton
On Thu, Jan 20, 2005 at 08:49:27AM -0800, Juan Lang wrote: > Hi Luke, I don't know is this is useful, but the TRY/CATCH stuff in > particular is declared here: > http://source.winehq.org/source/include/wine/exception.h > and the Wine exception handling code is implemented here: > http://source.wine

Re: RpcImpersonateClient (and ImpersonateNamedPipeClient)

2005-01-20 Thread Luke Kenneth Casson Leighton
On Thu, Jan 20, 2005 at 09:08:27AM -0800, Juan Lang wrote: > Hi Luke, you said: > > that's where you'd need the cooperation of samba / samba tng: > > it's got "SIDs" behind it, and "SIDs" means a SAMR server > > and a NETLOGON server and an LSARPC server (and in the > > case of windows 2000 interop

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Robert Shearman
Paul Vriens wrote: On Thu, 2005-01-20 at 11:47, Paul Vriens wrote: On Wed, 2005-01-19 at 20:32, Alexandre Julliard wrote: Paul Vriens <[EMAIL PROTECTED]> writes: and part of a trace: 0009:trace:ole:COM_ApartmentRelease destroying apartment 0x77e64460, oxid 80009 Looks li

Re: RpcImpersonateClient (and ImpersonateNamedPipeClient)

2005-01-20 Thread Juan Lang
Hi Luke, you said: > that's where you'd need the cooperation of samba / samba tng: > it's got "SIDs" behind it, and "SIDs" means a SAMR server > and a NETLOGON server and an LSARPC server (and in the > case of windows 2000 interoperability, access to an Active > Directory Server). Another possibil

Re: Running dxdiag

2005-01-20 Thread Steven Edwards
--- Mike [EMAIL PROTECTED]: > Well, if the little stub is overwritten by a correct native DLDLLhen > there is no problem at all. If some install overwrites it with an older > version than what apps expect (or Wine provides) then that might be a > problem, but that's just the generic DLDLLell the

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Paul Vriens
On Thu, 2005-01-20 at 11:47, Paul Vriens wrote: > On Wed, 2005-01-19 at 20:32, Alexandre Julliard wrote: > > Paul Vriens <[EMAIL PROTECTED]> writes: > > > > > and part of a trace: > > > > > > 0009:trace:ole:COM_ApartmentRelease destroying apartment 0x77e64460, > > > oxid 80009 > > > > Looks

Re: Wine threads and TRY/CATCH macros and DCE threads and TRY/CATCH macros

2005-01-20 Thread Juan Lang
Hi Luke, I don't know is this is useful, but the TRY/CATCH stuff in particular is declared here: http://source.winehq.org/source/include/wine/exception.h and the Wine exception handling code is implemented here: http://source.winehq.org/source/dlls/ntdll/exception.c As Mike said, the Wine threadin

Re: Running dxdiag

2005-01-20 Thread Mike Hearn
Juan Lang wrote: This isn't enough for new installers, either :( I have an MSI-based InstallShield installer that's looking for shdocvw.dll to see if IE6 is installed. (It isn't, but that's how it's looking for it.) Trouble is, how would this work with the native/builtin thing? Right now all our

Re: Running dxdiag

2005-01-20 Thread Juan Lang
Hi Mike, > Dumping the headers is necessary for stupid installers that map DLL files > manually and rummage around in the headers to figure out versions and > stuff ... simply having an empty file isn't enough for all of them I'm > afraid :( This isn't enough for new installers, either :( I have

Re: [LOSTWAGES] update the non-standard include files task (RESEND)

2005-01-20 Thread Rémi Assailly
Selon "Dimitrie O. Paun" <[EMAIL PROTECTED]>: > On Thu, Jan 20, 2005 at 02:58:22PM +0900, Mike McCormack wrote: > > > > So did you ;) Here's a merge of both. > > I don't do this on purpose, but you missed win.h again :) > Again, with feeling... > > -- > Dimi. > win.h still exists...

Re: Font selection logic defective?

2005-01-20 Thread Bill Medland
On January 20, 2005 03:31 am, Huw D M Davies wrote: > On Wed, Jan 19, 2005 at 05:58:59PM -0800, Bill Medland wrote: > > On January 18, 2005 03:00 pm, Huw D M Davies wrote: > > > On Tue, Jan 18, 2005 at 12:08:17PM -0800, Bill Medland wrote: > > > > (Huw?) > > > > > > > > Do I need to dig deeper to u

Re: Wine threads and TRY/CATCH macros and DCE threads and TRY/CATCH macros

2005-01-20 Thread Mike Hearn
On Thu, 20 Jan 2005 11:29:23 +, Luke Kenneth Casson Leighton wrote: > so i was wondering if someone could point me in the direction > of some Wine source code - testing, implementation, macros > etc. that would allow me to vaguely confirm whether my > suspicions are correct. http://source.wine

Re: Fwd: Re: Wine builtin mscms.dll

2005-01-20 Thread Hans Leidekker
On Thursday 20 January 2005 08:04, you wrote: > I got your name from Mike. I was wondering if you could give me a pointer or a > hint on how to use wine's builtin mscms.dll. A simple DLL override in > .wine/config does not seem to do the job (using wine-20041210). Well, you have to realize that d

Re: [Fwd: Wine-Wiki.org]

2005-01-20 Thread Andreas Mohr
Hi, On Thu, Jan 20, 2005 at 09:28:50AM -0500, Tom wrote: > Hello, > > *My* thoughts about this is if we link to every wiki,tool,help,whatever > site out there they should in return link to our Donations site/link. > > This is just my opinion :-) Wrong, since now it's not only yours anymore ;-)

Re: [LOSTWAGES] update the non-standard include files task (RESEND)

2005-01-20 Thread Dimitrie O. Paun
On Thu, Jan 20, 2005 at 02:30:09PM +0100, Rémi Assailly wrote: > win.h still exists... My bad, I've misread this check-in: http://www.winehq.org/hypermail/wine-cvs/2005/01/0463.html -- Dimi.

Re: [Fwd: Wine-Wiki.org]

2005-01-20 Thread Tom
Ivan Leo Puoti wrote: Forwarding in case someone cares about this. Ivan. Subject: Wine-Wiki.org From: Jason Swindle <[EMAIL PROTECTED]> Date: Wed, 19 Jan 2005 14:10:04 -0600 To: [EMAIL PROTECTED] Hello, Can you please add Wi

RpcImpersonateClient (and ImpersonateNamedPipeClient)

2005-01-20 Thread Luke Kenneth Casson Leighton
like the ImpersonateNamedPipeClient function, it's funny - i've _just_ being dealing with this stuff in Samba TNG: lkcl2005/01/20 13:05:50 CET Modified files: source/lib msrpc-client.c source/rpc_parse parse_creds.c Log:

Re: Native comctl32.dll and native commctrl.dll

2005-01-20 Thread Vitaly Lipatov
Ð ÑÐÐÐÑ ÐÑ 10 ÑÑ 2005 13:09 Dripple ÑÐÐ(a): > Do you want me to provide a extract of a WINEDEBUG=+dll run ? +dll or other kind debugging output for anyone who wants help with this program. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

Re: Font selection logic defective?

2005-01-20 Thread Huw D M Davies
On Wed, Jan 19, 2005 at 05:58:59PM -0800, Bill Medland wrote: > On January 18, 2005 03:00 pm, Huw D M Davies wrote: > > On Tue, Jan 18, 2005 at 12:08:17PM -0800, Bill Medland wrote: > > > (Huw?) > > > > > > Do I need to dig deeper to understand this or is there a defect in the > > > logic. If there

Wine threads and TRY/CATCH macros and DCE threads and TRY/CATCH macros

2005-01-20 Thread Luke Kenneth Casson Leighton
hi, as you may be aware, dce threads is posix draft 4 threads and FreeDCE has an emulation library kindly made up-to-date to successfully run even on NPTL on x86 and AMD64, courtesy of loic. http://cvs.sourceforge.net/viewcvs.py/freedce/dcethreads/ it is my understanding / guess that mic

Re: Regression : tools/wineinstall fails with an X Error

2005-01-20 Thread Paul Vriens
On Wed, 2005-01-19 at 20:32, Alexandre Julliard wrote: > Paul Vriens <[EMAIL PROTECTED]> writes: > > > and part of a trace: > > > > 0009:trace:ole:COM_ApartmentRelease destroying apartment 0x77e64460, > > oxid 80009 > > Looks like some sort of heap corruption, the apartment pointer is > susp

Re: [AppDB] new screenshot and image classes

2005-01-20 Thread Jonathan Ernst
*This script uses GD 1 instead of GD 2 functions so that it'll work on the live server* Here is a script that will recreate missing thumbnails and apply the watermarking. Please configure the script by modifying the first lines and don't forget to create the thumbnail directories. Other than

Re: olepicture.c compile failure : "structure has no member named `UserData', implicit declaration of function `DGifOpen'"

2005-01-20 Thread Marcus Meissner
On Wed, Jan 19, 2005 at 05:48:13PM -0800, Rizwan Kassim wrote: > This has been reported as Bugzilla 1730. > " > olepicture.c: In function `_gif_inputfunc': > olepicture.c:834: structure has no member named `UserData' > olepicture.c: In function `OLEPictureImpl_Load': > olepicture.c:923: warning: im