Fix recently introduced SEGV in DOCFILE IStorage implementation

2005-02-23 Thread Troy Rollo
After changing StorageBaseImpl, StorageInternalImpl was not updated to reflect the change. ChangeLog: Fix SEGV in IStorage implementation due to structure mismatch between StorageBaseImpl and StorageInternalImpl. Index: dlls/ole32/storage32.h ===

Re: pcmconverter.c question

2005-02-23 Thread Robert Reif
Jeremy White wrote: The attached patch fixes all remaining test failures in winmm when run in interactive mode on my box with Wineoss. It does so by making msacm conversions start aligned (which lets them finish aligned for my test cases). However, it's clear that Robert Reif intended them not to b

using safe string functions in wine

2005-02-23 Thread James Hawkins
Hey, While perusing msdn recently, I stumbled across string safe functions. These functions were created to replace the standard c string handling routines. The following are some design criteria of string safe functions (msdn): * Always NULL-terminate the string. * Always take a destination bu

Re: World Of Warcraft

2005-02-23 Thread Raphael
On Wednesday 23 February 2005 10:26, Alex Woods wrote: > I owe you a beer! I'm waiting you :) > It works great. No crash, and the minimap is there looking how I think > it should (don't have windows or cedega so it's the first time I've seen > inside the game properly). Unfortunately, wine cras

Re: World Of Warcraft

2005-02-23 Thread Raphael
On Wednesday 23 February 2005 22:32, Troy Rollo wrote: > On Wed, 23 Feb 2005 19:59, Raphael wrote: > > On Tuesday 22 February 2005 03:10, Troy Rollo wrote: > > > Nope. That typo was mine. > > > > lol sorry for mismatch :) > > > > i'll give you copyright :) > > Well I wouldn't want to let somebody e

Re: World Of Warcraft

2005-02-23 Thread Troy Rollo
On Wed, 23 Feb 2005 19:59, Raphael wrote: > On Tuesday 22 February 2005 03:10, Troy Rollo wrote: > > > > Nope. That typo was mine. > > lol sorry for mismatch :) > > i'll give you copyright :) Well I wouldn't want to let somebody else take the blame for my mistakes. I'll leave that sort of thing t

pcmconverter.c question

2005-02-23 Thread Jeremy White
The attached patch fixes all remaining test failures in winmm when run in interactive mode on my box with Wineoss. It does so by making msacm conversions start aligned (which lets them finish aligned for my test cases). However, it's clear that Robert Reif intended them not to be aligned. My quest

Re: Any resources about threading problems?

2005-02-23 Thread Mike Hearn
On Wed, 23 Feb 2005 09:30:50 -0800, Bill Medland wrote: > Does anyone know any site or book or something with a decent discussion about > the problems of the different threading models and their implementations? That'd be the developers guide ;) > In the Developer's Guide in section 8.3 there a

Any resources about threading problems?

2005-02-23 Thread Bill Medland
Does anyone know any site or book or something with a decent discussion about the problems of the different threading models and their implementations? In the Developer's Guide in section 8.3 there are references to "the threading chapter". Is this a section that has not yet been written? As I

Re: Cygwin X11 server, notepad and message boxes

2005-02-23 Thread Brian Vincent
On Wed, 23 Feb 2005 11:29:40 +0100, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: > I'm trying to run notepad on WINE, with DISPLAY environment variable > pointing to Cygwin (X Server 6.7.0.0-12) running on my Windows XP > machine. It works rather OK-ish, but when I try to close Notepad, it > gets s

Re: rsabase: Make rsabase a wrapper around rsaenh

2005-02-23 Thread Michael Stefaniuc
Tom wrote: Michael Stefaniuc wrote: Jonathan Ernst wrote: Le mercredi 23 fÃvrier 2005 Ã 13:50 +0100, Michael Jung a Ãcrit : Ok, that makes rsabase a really trivial dll. Please remove dlls/rsabase/main.c from cvs (Is there any way to capture this in a diff?) diff -u dlls/rsabase/main.c /dev/null

Re: rsabase: Make rsabase a wrapper around rsaenh

2005-02-23 Thread Tom
Michael Stefaniuc wrote: Jonathan Ernst wrote: Le mercredi 23 fÃvrier 2005 Ã 13:50 +0100, Michael Jung a Ãcrit : Ok, that makes rsabase a really trivial dll. Please remove dlls/rsabase/main.c from cvs (Is there any way to capture this in a diff?) diff -u dlls/rsabase/main.c /dev/null >> rsabase.

Re: Wrong keycodes ?

2005-02-23 Thread Dmitry Timoshkov
"George Ginden" <[EMAIL PROTECTED]> wrote: > VK_LEFT is #defined as 0x25 > > Now If I press the left arrow key, wine produces the following trace > > trace:keyboard:X11DRV_ToUnicodeEx NumLockMask = 0010 > trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0010 > trace:keyboard:X11DRV_ToUnicodeEx Fou

Re: rsabase: Make rsabase a wrapper around rsaenh

2005-02-23 Thread Scott W Gifford
Michael Stefaniuc <[EMAIL PROTECTED]> writes: > Jonathan Ernst wrote: >> Le mercredi 23 février 2005 à 13:50 +0100, Michael Jung a écrit : >> >>> Ok, that makes rsabase a really trivial dll. Please remove >>> dlls/rsabase/main.c from cvs (Is there any way to capture this in a >>> diff?) >> diff -u

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > If you have time available, could you explain what the different cases > are for putting the checks in either ntdll or the wine server. In the > meantime I will be reading through the server's reg functions and > adding the checks there. If the functio

Re: Wrong keycodes ?

2005-02-23 Thread George Ginden
Dmitry Timoshkov ha scritto: What exactly does look wrong for you? It all works as expected here. Add +key,+event in addition to +keyboard and post the results with explanations what really goes wrong. Well I may be wrong but : VK_LEFT is #defined as 0x25 Now If I press the left arrow key, wine

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread James Hawkins
On 23 Feb 2005 16:00:04 +0100, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > James Hawkins <[EMAIL PROTECTED]> writes: > > > By lower level functions do you mean the ntdll reg functions? > > Either in ntdll or directly in the Wine server, depending on the case; > most likely in the server. >

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > By lower level functions do you mean the ntdll reg functions? Either in ntdll or directly in the Wine server, depending on the case; most likely in the server. -- Alexandre Julliard [EMAIL PROTECTED]

Re: rsabase: Make rsabase a wrapper around rsaenh

2005-02-23 Thread Michael Stefaniuc
Jonathan Ernst wrote: Le mercredi 23 fÃvrier 2005 Ã 13:50 +0100, Michael Jung a Ãcrit : Ok, that makes rsabase a really trivial dll. Please remove dlls/rsabase/main.c from cvs (Is there any way to capture this in a diff?) diff -u dlls/rsabase/main.c /dev/null >> rsabase.diff Not realy as this emp

Re: World Of Warcraft

2005-02-23 Thread Alex Woods
On Wed, Feb 23, 2005 at 09:26:25AM +, Alex Woods wrote: > inside the game properly). Unfortunately, wine crashes out if I move > the mouse to another display. so I can't take a screenshot for you :( It really doesn't like losing focus from the game, I'll try and get some logs together later,

Re: rsabase: Make rsabase a wrapper around rsaenh

2005-02-23 Thread Jonathan Ernst
Le mercredi 23 fÃvrier 2005 Ã 13:50 +0100, Michael Jung a Ãcrit : > Ok, that makes rsabase a really trivial dll. Please remove > dlls/rsabase/main.c > from cvs (Is there any way to capture this in a diff?) diff -u dlls/rsabase/main.c /dev/null >> rsabase.diff signature.asc Description: Ceci e

Re: unixfs.dll: shell namespace extension for the unix filesystem

2005-02-23 Thread Mike Hearn
On Wed, 23 Feb 2005 14:20:09 +0100, Michael Jung wrote: > Currently, unixfs is registered as a virtual folder appearing directly at 'My > Computer'. Winecfg uses SHBrowseForFolder, but it will also appear in > open/save-as dialogs. Would this be ok? Well exactly, I'm not sure we want it in the o

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread James Hawkins
On 23 Feb 2005 13:57:08 +0100, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > James Hawkins <[EMAIL PROTECTED]> writes: > > > +/* a key cannot be created directly beneath HKEY_LOCAL_MACHINE or > > HKEY_USERS */ > > +if ((hkey == HKEY_LOCAL_MACHINE || hkey == HKEY_USERS) && > > !strchr(n

Re: [ros-dev] RE: Collection of wine tools on windows

2005-02-23 Thread Boaz Harrosh
Rolf Kalbermatter wrote: This is rubish. Yes ^ 3 ( that is Yes cubed) Let us all get back on track of this discussion. Must ReactOS and MinGW use the Wine set of headers. 1. ReactOS & MinGW are by themselves GPL, So they are more strict than Wine's header set 2. Headers are out of the scope fo

Re: winmm/wineoss: use DSP_POST to flush the frag buffers

2005-02-23 Thread Jeremy White
Don't apply this; more survey of alternate sound cards shows that DSP_POST does not work as well as advertised everywhere. Jer Jeremy White wrote: When we get down to the last fragment or two in our output to the DSP, we should use the SND_DSP_POST ioctl to let the sound card know to flush those fr

Re: unixfs.dll: shell namespace extension for the unix filesystem

2005-02-23 Thread Michael Jung
On Wednesday 23 February 2005 12:38, Mike Hearn wrote: > - I do not understand why a UnixFSPIDLToPath function is needed, doesn't > Win32 already provide a generic form of this function? If we are going > to introduce new APIs then the whole excercise becomes meaningless as we > may as well j

Re: ole/storage: Problems with 'Myst Uru Demo'

2005-02-23 Thread Paul Vriens
On Wed, 2005-02-23 at 13:57, Paul Vriens wrote: > Hi, > > eventhough Michael withdrew his patch > (http://www.winehq.org/hypermail/wine-devel/2005/02/0687.html) I've > tried it, and it crashes in the ole/storage area. > > I've added some TRACE's and this is the output: > > 000b:trace:storage:Sto

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > +/* a key cannot be created directly beneath HKEY_LOCAL_MACHINE or > HKEY_USERS */ > +if ((hkey == HKEY_LOCAL_MACHINE || hkey == HKEY_USERS) && !strchr(name, > '\\')) { > +*retkey = NULL; > + return ERROR_INVALID_PARAMETER; > +}

ole/storage: Problems with 'Myst Uru Demo'

2005-02-23 Thread Paul Vriens
Hi, eventhough Michael withdrew his patch (http://www.winehq.org/hypermail/wine-devel/2005/02/0687.html) I've tried it, and it crashes in the ole/storage area. I've added some TRACE's and this is the output: 000b:trace:storage:StorageBaseImpl_Release (0x77ece0f8/0x77ece0f8) decremented refcount

Re: A call to fix the BeginPaint issue

2005-02-23 Thread Paul Vriens
On Wed, 2005-02-23 at 04:20, Nick Hornback wrote: > --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > There is a lot of interest in fixing it, but it's > > far from trivial > > especially for apps that I don't have. You can help > > by posting traces > > (+server,+win,+message is usually a good

Re: rsabase: Make rsabase a wrapper around rsaenh

2005-02-23 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > As suggested by Alexandre, I removed all implementation code from rsabase and > made it a pure wrapper around rsaenh. I've imitated the scheme used in wine's > unicows.dll to do so. You don't need that, you can forward directly in the spec file. Unico

Re: unixfs.dll: shell namespace extension for the unix filesystem

2005-02-23 Thread Mike Hearn
On Sun, 20 Feb 2005 23:14:44 +0100, Michael Jung wrote: > this is a first rough cut version of a shell namespace extension to access > the > unix filesystem from wine. It's primary use-case is for winecfg's > drive-mapping propery sheet. It already works for this purpose. Cool! Here are some c

RE: [ros-dev] RE: Collection of wine tools on windows

2005-02-23 Thread Rolf Kalbermatter
"Casper Hornstrup" <[EMAIL PROTECTED]> wrote: >Yes, but then you need to publish the sources for the non-free application under the LGPL. >When using headers to build your application, you create a derived work of those headers. > >http://www.fsf.org/licensing/licenses/lgpl.html > >"A "work based

Cygwin X11 server, notepad and message boxes

2005-02-23 Thread Krzysztof Foltman
I'm trying to run notepad on WINE, with DISPLAY environment variable pointing to Cygwin (X Server 6.7.0.0-12) running on my Windows XP machine. It works rather OK-ish, but when I try to close Notepad, it gets stuck in GetMessageW function call after displaying a "text changed, do you want to sa

richedit (ro): "Select all" or "Copy" crashes wine

2005-02-23 Thread Tobias Burnus
Hi, in Diamond 2.x (http://www.codeweavers.com/compatibility/browse/name?app_id=865) there is a structure-data richedit (read-only). (Under Windows: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_info.png; it's on the right side; Wine looks similar, but the background is grey and it is n

Re: A call to fix the BeginPaint issue

2005-02-23 Thread Nick Hornback
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > There is a lot of interest in fixing it, but it's > far from trivial > especially for apps that I don't have. You can help > by posting traces > (+server,+win,+message is usually a good start) of > the offending > behavior. I just checked out cvs

Re: Wrong keycodes ?

2005-02-23 Thread Dmitry Timoshkov
"George Ginden" <[EMAIL PROTECTED]> wrote: > Hi do you guys know anything about that already ? > It looks like some keys are not mapped correctly: > > grep -r VK_* * | grep include/winuser.h > include/winuser.h:#define VK_LEFT 0x25 > include/winuser.h:#define VK_UP 0x26

Re: World Of Warcraft

2005-02-23 Thread Alex Woods
On Wed, Feb 23, 2005 at 10:03:56AM +0100, Raphael wrote: > > It looks as though it's the Pbuffer stuff it is after. Right after all > > those wglGetProcAddress it does this: > > > > trace:opengl:wglCreatePbufferARB (0x7b8, 1, 1024, 1024, 0x55bdfc4c) > > trace:opengl:wglGetPbufferDCARB ((nil)) > >

Re: World Of Warcraft

2005-02-23 Thread Raphael
On Monday 21 February 2005 22:46, Lionel Ulmer wrote: > On Mon, Feb 21, 2005 at 09:25:05PM +, Alex Woods wrote: > > It looks as though it's the Pbuffer stuff it is after. Right after all > > those wglGetProcAddress it does this: > > > > trace:opengl:wglCreatePbufferARB (0x7b8, 1, 1024, 1024, 0

Re: World Of Warcraft

2005-02-23 Thread Raphael
Hi > It looks as though it's the Pbuffer stuff it is after. Right after all > those wglGetProcAddress it does this: > > trace:opengl:wglCreatePbufferARB (0x7b8, 1, 1024, 1024, 0x55bdfc4c) > trace:opengl:wglGetPbufferDCARB ((nil)) > > So I guess it could be setting up stuff for the minimap long be

Re: Checking Wine's spec files

2005-02-23 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > It turns out that a lot of the functions my script complains should > have the -noname or not have the -noname property should: > * really not have a name at all > * or be marked as -private > > Is this something we want to do? No, I don't think

Re: World Of Warcraft

2005-02-23 Thread Raphael
On Monday 21 February 2005 22:50, Lionel Ulmer wrote: > > >I have absolutely no understanding of this but in the list at the > > >end of your patch mailed to the list there is... > > > > > > { "wglGetSwapIntervalEXT", (void *) wglSwapIntervalEXT, NULL, > > > NULL}, > > > > > >and 5 lines later

Re: World Of Warcraft

2005-02-23 Thread Raphael
On Monday 21 February 2005 21:53, Alex Woods wrote: > On Mon, Feb 21, 2005 at 09:39:31PM +0100, Raphael wrote: > > Ouppsss > > > > better patch > > Thanks, and good timing - I was just about to go and debug it ;) :) > The new patch gives the following wglGetProcAddress stuff, which looks > more l

Re: World Of Warcraft

2005-02-23 Thread Raphael
On Tuesday 22 February 2005 03:10, Troy Rollo wrote: > On Tue, 22 Feb 2005 09:22, [EMAIL PROTECTED] wrote: > > >Since it's the only entry where the string and > > >pointer/function/object/structure/whatever don't match I wondered it > > >"wglGetSwapIntervalEXT" ... wglSwapIntervalEXT might be a typ

Re: Should winecfg drive detection create device symlinks

2005-02-23 Thread Michael Jung
On Wednesday 23 February 2005 08:40, Paul van Schayck wrote: > <[EMAIL PROTECTED]> wrote: > > I think winecfg does this already. Take a look at the function > > apply_drive_functions in drive.c. Does'nt it work for you? > > As far as I can tell it does not. We do not store the device node path > in

Re: advapi32: Don't free csp dll when a container is deleted

2005-02-23 Thread Michael Jung
On Wednesday 23 February 2005 00:04, Michael Jung wrote: > Changelog: > Don't unload Cryptographic Service Provider DLL when a key container is > deleted. There might still be open handles. Don't apply this patch, please. It fixes the crash in the "Uru Demo" installer only by coincidence. We rea