Re: USER32: Sysparams unit tests fixes and additions

2005-02-28 Thread Paul Vriens
On Tue, 2005-03-01 at 05:53, [EMAIL PROTECTED] wrote: > Changelog: > > * Created SPI_{GET,SET}KEYBOARDPREF and SPI_{GET,SET}SCREENREADER unit tests > * Removed a trace that shouldn't have been there > * Add return checking to SPI_{GET,SET}WHEELSCROLLLINES and > SPI_{GET,SET}MENUSHOWDELAY unit tes

Re: Wine cabinet.dll FDI Conformace Test Patch

2005-02-28 Thread Daniel Kegel
Andreas wrote: It's an unspoken rule that preprocessor directives (#ifdef, ...) always start at the very beginning of a line to make sure one recognizes immediately which parts of the code are being processed and which ones aren't. Good point. I should have caught that style violation when I revie

AppDB SQL Errors

2005-02-28 Thread Scott Ritchie
Here: http://www.swissarmygeek.com/winesqlerr.gif

Re: vartest.c - major pain in the build process

2005-02-28 Thread Dmitry Timoshkov
"Jakob Eriksson" <[EMAIL PROTECTED]> wrote: > >I have to repeat again: Winword, Photoshop, Internet Explorer or any other > >application I and most (if not all) developers and users are care about do > >not > >run on an invisible desktop, therefore I don't care about tests running in > >that > >

Re: Crash in Polar Precision Performance Software

2005-02-28 Thread Ron Jensen
On Mon, 2005-02-28 at 16:11 -0600, Robert Shearman wrote: > Ron Jensen wrote: > > >Hello, > > > >This trace is from Polar's Precision Performance Software > >http://www.codeweavers.com/site/compatibility/browse/name?app_id=681 > >running on CVS wine. > > > >This crash happens with CVS wine, and wi

Re: Tools for identifying what a DLL provides?

2005-02-28 Thread Michael Stefaniuc
Andreas Mohr wrote: On Mon, Feb 28, 2005 at 09:48:40AM -0600, David D. Hagood wrote: I have a DLL from a manufacturer that I don't have the source for, nor do I have the header or the import library for. Since Wine developers frequently have to reverse engineer what a given DLL provides, does an

Help with winebuild/winegcc

2005-02-28 Thread Ivan Leo Puoti
Hello, I'm trying to get a program in the programs/ directory to export symbols, I've added -shared path/to/spec/spec.c to the linker command, but I now get a segmentation fault at startup. Can someone knowledgeable about winegcc/winebuild give me a suggestion/solution? I'm really stuck because

Re: Crash in Polar Precision Performance Software

2005-02-28 Thread Robert Shearman
Ron Jensen wrote: Hello, This trace is from Polar's Precision Performance Software http://www.codeweavers.com/site/compatibility/browse/name?app_id=681 running on CVS wine. This crash happens with CVS wine, and wine I compiled from http://ftp.codeweavers.com/pub/crossover/office/source/office-src-

Re: Implements OleLoadPicturePath

2005-02-28 Thread Maxime Bellengé
Thanks for your reply, I will fix the places you mentioned to clean things up correctly. But other places in olepicture should also be fixed in this case. I will check that. Max On Mon, 2005-02-28 at 15:22 -0600, Robert Shearman wrote: > Maxime Bellengà wrote: > > >Hello, here is an implementati

Re: [PATCH] Added 2 functions to shell32

2005-02-28 Thread Jacek Caban
I doubt shell32 function on windows does this check, also original windows shell32 function is a lot more complicated and longer, I've compared the results between real and my code and they are correct. I wrote a small test for this function showing that your implementation is almost correct. It

Re: [QUARTZ] Handle End Of Stream notifications

2005-02-28 Thread Robert Shearman
Christian Costa wrote: Index: dlls/quartz/dsoundrender.c === RCS file: /home/wine/wine/dlls/quartz/dsoundrender.c,v retrieving revision 1.6 diff -u -r1.6 dsoundrender.c --- dlls/quartz/dsoundrender.c 6 Jan 2005 19:36:47 - 1.

Re: Implements OleLoadPicturePath

2005-02-28 Thread Robert Shearman
Maxime Bellengà wrote: Hello, here is an implementation of OleLoadPicturePath. The filename can be either a local file or an url. In case of a url, I needed a user-agent for wininet. I put a dummy value as I didn't find a default wine value. Is there a default value somewhere for the whole project

Re: [SOLVED] Re: Picasa2- works great, one font issue

2005-02-28 Thread Troy Rollo
On Mon, 28 Feb 2005 11:27, Matthew Mastracci wrote: > Okay - I checked out the latest Wine from CVS and it seems to be fixed. > I think this patch was the one that fixed it: > > revision 1.82 > date: 2005/02/25 13:59:22; author: julliard; state: Exp; lines: +9 -9 > TANABE Hiroshi <[EMAIL PROTECT

Re: [programs/regedit] Use Favorit* instead of Favourit*

2005-02-28 Thread Robert Shearman
Paul Vriens wrote: Hi, Our regedit displays Favourites in the menu. This patch changes that to use Favorites. The patch also changes the variables with FAVOURITE in the name. The reasoning is: a. Windows uses Favorite(s) all over the place. b. We do too. That's the only reasoning and not if eithe

OpenGL _client regression with ATI.

2005-02-28 Thread Oliver Stieber
Hi, after the whole _client, _window changes for VisualID's DirectX started displaying a bit of garbage at the top of the screen, which I toughed was because the window frames weren't taken into account in the view-port. This is sort of what's happening but it's worse. When I'm using ATI's driver

Patch 16316 causes regression in Irfan View

2005-02-28 Thread Ron Jensen
Patch 16316 causes regression in Irfan View. When I attempt to put Irfan View ( http://appdb.winehq.org/appview.php?appId=163 ) into slide show mode (Menu: File -> Slideshow, add some files and Play) Irfan View locks up and needs a control-c at the console to kill it. I will investigate furth

Re: invisible desktops - major pain in the testing process

2005-02-28 Thread Chris Morgan
> Yes. I don't argue that testing on a visible desktop is a > must. Some people are actually doing that, it seems. Or > maybe that's just you alone... :) Anyway, I tried to make > such results visually distinctive so that we shouldn't drop > all the rest. Too bad it doesn't work. > > > figuri

Re: dsound questions

2005-02-28 Thread Ove Kaaven
man, 28,.02.2005 kl. 11.23 -0600, skrev Jeremy White: > In other words, afaict, the current code computes the difference > between the number of bytes that have been played from the input > source stream (buf_writepos) and the end of the data the app has > written (probably_valid_to). It then clip

Re: Tools for identifying what a DLL provides?

2005-02-28 Thread Bill Medland
On February 28, 2005 08:55 am, Andreas Mohr wrote: > Hi, > > On Mon, Feb 28, 2005 at 09:48:40AM -0600, David D. Hagood wrote: > > I have a DLL from a manufacturer that I don't have the source for, nor do > > I have the header or the import library for. > > > > Since Wine developers frequently have

Re: dsound questions

2005-02-28 Thread Jeremy White
Ove Kaaven wrote: tor, 24,.02.2005 kl. 22.56 -0600, skrev Jeremy White: Case 1: In the first case, in DSOUND_MixOne, we compute a 'probably_valid_to' based on the 'write_pos', which seems quite wrong; I believe the logic should be testing whether or not there is sufficient data in the mixing buffe

Re: Tools for identifying what a DLL provides?

2005-02-28 Thread Andreas Mohr
Hi, On Mon, Feb 28, 2005 at 09:48:40AM -0600, David D. Hagood wrote: > I have a DLL from a manufacturer that I don't have the source for, nor do > I have the header or the import library for. > > Since Wine developers frequently have to reverse engineer what a given DLL > provides, does anybody

Re: Wine cabinet.dll FDI Conformace Test Patch

2005-02-28 Thread Andreas Mohr
Hi, On Sun, Feb 27, 2005 at 10:21:15PM -0800, Rizwan Kassim wrote: > Folks, > > Aleksandr Liber and I have put together a set of tests for > cabinet.dll. Before we submit them to wine-patches, can anyone offer > any critiques/input? We plan to submit in a day or two. Cool stuff! It's wonder

Re: dsound questions

2005-02-28 Thread Ove Kaaven
tor, 24,.02.2005 kl. 22.56 -0600, skrev Jeremy White: > Case 1: In the first case, in DSOUND_MixOne, we compute > a 'probably_valid_to' based on the 'write_pos', which seems quite > wrong; I believe the logic should be testing whether or not > there is sufficient data in the mixing buffer, not whe

Re: vartest.c - major pain in the build process

2005-02-28 Thread Ivan Leo Puoti
Dimitrie O. Paun wrote: Don't need to do that, there are plenty of tests that run fine with an invisible desktop, there's enough value in having some automated tests. Maybe we need to separate the results... I don't really care at all, I just think winrash should be kept and should be improved

Re: vartest.c - major pain in the build process

2005-02-28 Thread Dimitrie O. Paun
On Mon, Feb 28, 2005 at 01:10:25PM +0100, Ivan Leo Puoti wrote: > OK, then we can have winrash only run them in interactive mode, end of > story. Don't need to do that, there are plenty of tests that run fine with an invisible desktop, there's enough value in having some automated tests. Maybe we

[SOLVED] Re: Picasa2- works great, one font issue

2005-02-28 Thread Matthew Mastracci
Okay - I checked out the latest Wine from CVS and it seems to be fixed. I think this patch was the one that fixed it: revision 1.82 date: 2005/02/25 13:59:22; author: julliard; state: Exp; lines: +9 -9 TANABE Hiroshi <[EMAIL PROTECTED]> wrote: Remove (buf && !buflen) checking. Fixed outline r

Re: [PATCH] Added 2 functions to shell32

2005-02-28 Thread Gianluigi Tiesi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dmitry Timoshkov wrote: | "Gianluigi Tiesi" <[EMAIL PROTECTED]> wrote: | | |>+BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2) |>+{ |>+ int i; |>+ int len; |>+ if (!path1 || !path2) return FALSE; |>+ |>+ len = strlenW(path1); |>+ if (len

Re: status of winetest.exe

2005-02-28 Thread Paul Millar
Hi Stefan, Yes, things are broken due some behind-the-scenes that turned out not to be the case. I've been a bit busy these past five days, but I'm back in the country (and, more importantly, with net connectivity) so should get these problems fixed soon. Cheers, Paul. On Friday 25 February

Tools for identifying what a DLL provides?

2005-02-28 Thread David D. Hagood
I have a DLL from a manufacturer that I don't have the source for, nor do I have the header or the import library for. Since Wine developers frequently have to reverse engineer what a given DLL provides, does anybody have a good recommendation for a tool that can scan the DLL and report what fu

Re: vartest.c - major pain in the build process

2005-02-28 Thread Ivan Leo Puoti
Dmitry Timoshkov wrote: "Ivan Leo Puoti" <[EMAIL PROTECTED]> wrote: We can just have winrash run in interactive mode. Once tests are ready to run, a message pops up saying "new tests available" or something of the sort, the user then chooses to run them now or later, like the windows automatic u

Re: vartest.c - major pain in the build process

2005-02-28 Thread Dmitry Timoshkov
"Ivan Leo Puoti" <[EMAIL PROTECTED]> wrote: > We can just have winrash run in interactive mode. Once tests are ready to > run, a message pops up > saying "new tests available" or something of the sort, the user then chooses > to run them now or > later, like the windows automatic updates. Like t

Re: invisible desktops - major pain in the testing process

2005-02-28 Thread Ferenc Wagner
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "Ferenc Wagner" <[EMAIL PROTECTED]> wrote: > >> I was under the impression that most of the tests are >> independent of desktop visibility. > > Not really. Any API which directly or indirectly creates > windows or uses GDI is affected by the desktop

Use of Favourite instead a Favorite in our regedit

2005-02-28 Thread Paul Vriens
Hi, while looking through some registries (via regedit) on several windows versions and Wine, I saw that we use Favourites/Favourite etc.. instead of Favorites/Favorite in our regedit implementation. Is this deliberate or should I create a patch for this? The patch will also change ID_FAVOURITES

Re: vartest.c - major pain in the build process

2005-02-28 Thread Ivan Leo Puoti
Dmitry Timoshkov wrote: Why? What prevents someone to run the tests manually in interactive mode once a day? If that someone can't or won't do it, then we have to find another someone. I'm pretty sure that there are enough not lazy people wishing to help we could to choose from. We can just have wi