Re: version: Use proper type for third parameter of VerQueryValue

2005-03-28 Thread Uwe Bonnes
> "Dmitry" == Dmitry Timoshkov <[EMAIL PROTECTED]> writes: Dmitry> "James Hawkins" <[EMAIL PROTECTED]> wrote: >> Changelog * Use proper type for third parameter of VerQueryValue >> -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); -DWORD >> WINAPI VerQueryValueW(LPVOI

Re: version: Use proper type for third parameter of VerQueryValue

2005-03-28 Thread James Hawkins
On Tue, 29 Mar 2005 14:02:03 +0900, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > Changelog > > * Use proper type for third parameter of VerQueryValue > > > -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); > > -DWORD WINAPI Ve

Re: KERNEL: Implement undocumented SetCPGlobal API call

2005-03-28 Thread Dmitry Timoshkov
"Troy Rollo" <[EMAIL PROTECTED]> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) What app does depend on it? -- Dmitry.

Re: version: Use proper type for third parameter of VerQueryValue

2005-03-28 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > Changelog > * Use proper type for third parameter of VerQueryValue > -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); > -DWORD WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); > +BOOL WINAPI VerQueryValueA(const LPVOID,L

Japanese 106 keyboard mapping bug + patch

2005-03-28 Thread Aric Cyr
I was having a mysterious problem with my Japanese 106 keyboard in World of Warcraft. The keyboard worked just fine when logging into the game or typing messages in game, etc. However, using the macro keys for the quickbar (1 2 3 ... 0) each of the keys was off by one. The keys were mapped as: 1

Re: KERNEL: Implement undocumented SetCPGlobal API call

2005-03-28 Thread James Hawkins
On Tue, 29 Mar 2005 11:37:43 +1100, Troy Rollo <[EMAIL PROTECTED]> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) A patch would be good :) -- James Hawkins

Re: KERNEL: Implement undocumented SetCPGlobal API call

2005-03-28 Thread James Hawkins
On Tue, 29 Mar 2005 11:37:43 +1100, Troy Rollo <[EMAIL PROTECTED]> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) A patch would be good :) -- James Hawkins

Re: Dragon Naturally Speaking - working.

2005-03-28 Thread wino
Great news. Could you give more details on your alsa setup? I have not managed to get alsa working with wine appart from putting oss in the wine config and using alsa-oss Regards, On Mon, 28 Mar 2005 13:50:08 +0200, Konstantin Goudkov <[EMAIL PROTECTED]> wrote: I got NS7 working on Debian

advapi: remove signature checking code.

2005-03-28 Thread Michael Jung
Hi, Microsoft signs it's cryptographic service provider (csp) dlls with a private key. advapi32 will only load csp dlls with a valid signature. We will never be able to implement this, since this would mean having access to Microsoft's private keys. Above this, Microsofts scheme doesn't give re

Re: msi:Fix Typelib Registration

2005-03-28 Thread Huw D M Davies
On Mon, Mar 28, 2005 at 10:39:48AM -0600, Aric Stewart wrote: > make sure the GUID of the typelib we are registering matches the guid > requested from MSI. if not search the given typelib file to find the > typelib requested to register. > > > Index: dlls/msi/action.c > ===

Re: [dlls/msi/*] Strncpy elimination.

2005-03-28 Thread Peter Berg Larsen
On 28 Mar 2005, Alexandre Julliard wrote: > > This memcpyies one element more than needed.. but seemed much nicer than > > memcpy( ret, p, (len - 1)*sizeof(WHCAR); > > > > I probably should have subtracted one from len, making it obvious > > that this is a strdupW, like: > > ret = HeapAlloc( Ge

Re: [dlls/msi/*] Strncpy elimination.

2005-03-28 Thread Alexandre Julliard
Peter Berg Larsen <[EMAIL PROTECTED]> writes: > This memcpyies one element more than needed.. but seemed much nicer than > memcpy( ret, p, (len - 1)*sizeof(WHCAR); > > I probably should have subtracted one from len, making it obvious > that this is a strdupW, like: > ret = HeapAlloc( GetProcess

Re: [libs/wine/*] Strncpy elimination.

2005-03-28 Thread Alexandre Julliard
Peter Berg Larsen <[EMAIL PROTECTED]> writes: > On 28 Mar 2005, Alexandre Julliard wrote: > > > You can't use lstrcpynA in the libs/ directory, you have to stick to > > Unix APIs. > > Ok, I just compiled and wine seemed to work. Yes, that's because they are declared inline, but we don't want to

Re: DDRAW: Surface locking patch, take 2

2005-03-28 Thread Alexandre Julliard
Matthew Mastracci <[EMAIL PROTECTED]> writes: > I'm just pinging the list ot see if there's any reason why this patch > hasn't been applied yet. AFAIK, it takes into account all the > feedback received so far. If you think you have taken into account the feedback then you should resubmit the pat

Re: dbghelp: better module support

2005-03-28 Thread Eric Pouech
Eric Pouech a écrit : minidumps now contain more accurate information about modules, especially information that will allow when reloading a minidump in a debugger to check whether we're using the right modules (ELF & PE) implemented also check for this information in SymFindFileInPath A+ Please

Re: [dlls/msi/*] Strncpy elimination.

2005-03-28 Thread Peter Berg Larsen
On Mon, 28 Mar 2005, Jakob Eriksson wrote: > Good thing you sent these patches. I was just thinking, should I dig > in? :-) You could recheck them? I tend to get code blind, when having so many cases that nearly are identical. As I said there are probably one two places where I didnt get the sem

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName

2005-03-28 Thread Robert Shearman
Jeff Latimer wrote: This is the first installment of the implementation of MkParseDisplayName. I would like feed back on style and usage. Ok, I'll happily add comments on the patch. I think the implementation of the EnumMoniker interface looks ok. Comments appreciated. Jeff Latimer --

dbghelp: small fixes

2005-03-28 Thread Eric Pouech
this patch fixes a couple of bugs in dbghelp A+ -- Eric Pouech Name: dbghelp19 ChangeLog: - PDB: better checking for error conditions - Fixed name demangling (when activated) when searching for a symbol License: X11 GenDate: 2005/03/28 16:17:32 UTC ModifiedFiles: dlls/d

Re: OLE32, compositemoniker: remove function prototypes, make functions static

2005-03-28 Thread Mike McCormack
James Hawkins wrote: Candidate for a janitorial project? :) Well, it may be a little bit complex to describe for Janitorial ... but by looking at my patches you can see what I'm trying to do. This was Juan's idea in the first place though :) Mike

Re: [libs/wine/*] Strncpy elimination.

2005-03-28 Thread Peter Berg Larsen
On 28 Mar 2005, Alexandre Julliard wrote: > > Janitorial Task: Check the usage of strncpy/strncpyW. > > You can't use lstrcpynA in the libs/ directory, you have to stick to > Unix APIs. Ok, I just compiled and wine seemed to work. Peter -- E-Mail: [EMAIL PROTECTED] Real name:Peter

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName

2005-03-28 Thread Mike McCormack
Hi Jeff, Jeff Latimer wrote: This is the first installment of the implementation of MkParseDisplayName. I would like feed back on style and usage. I think the implementation of the EnumMoniker interface looks ok. Comments appreciated. I like that you've taken the time to write a test case! I

Re: OLE32, compositemoniker: remove function prototypes, make functions static

2005-03-28 Thread James Hawkins
On Mon, 28 Mar 2005 14:48:40 +0900, Mike McCormack <[EMAIL PROTECTED]> wrote: > > There's more work like this to be done. Anybody want to help out? > > Mike > > ChangeLog: > * remove function prototypes, make functions static Candidate for a janitorial project? :) -- James Hawkins

Re: [dlls/msi/*] Strncpy elimination.

2005-03-28 Thread Jakob Eriksson
Good thing you sent these patches. I was just thinking, should I dig in? :-) Peter Berg Larsen wrote: I have been checking the usage of strncpy, replacing where apropriate with a memcpy or lstrcpyn[AW]. The first raw diff was 100kb, so there is bound to be one or two slips. These are the first b

Re: [libs/wine/*] Strncpy elimination.

2005-03-28 Thread Alexandre Julliard
Peter Berg Larsen <[EMAIL PROTECTED]> writes: > Changelog: > Janitorial Task: Check the usage of strncpy/strncpyW. You can't use lstrcpynA in the libs/ directory, you have to stick to Unix APIs. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Two small scrollbar fixes

2005-03-28 Thread Rein Klazes
On 28 Mar 2005 12:48:11 +0200, you wrote: > Rein Klazes <[EMAIL PROTECTED]> writes: > > > dlls/user : scroll.c > > dlls/user/tests : win.c > > > > - GetScrollRange should return an empty range, both upper and lower > > limit zero, if the window has no scrollbars (msdn); > > - GetScrollInfo

Re: Add a stdole2 typelib

2005-03-28 Thread Huw D M Davies
On Sun, Mar 27, 2005 at 11:43:34PM -0500, Vincent Béron wrote: > Robert, Huw: Do you have something else to add before this one goes in, > or is Wine ready for it? > > Huw: I had to name the enum at line 181, else I'd get a SIGSEGV in widl. > Would you mind trying to make it accept > > typedef en

Re: wine/ windows/scroll.c dlls/x11drv/scroll.c dl ...

2005-03-28 Thread Dimitrie O. Paun
On Mon, Mar 28, 2005 at 02:14:44PM +0200, Rein Klazes wrote: > Attached is a patch that solves Micha's scroll problem, also discussed > under bug #1091. It also does not change the handling of an existing > invalidated region. Nice, at least you nailed one :). As for the initial problem that I've

Re: wine/ windows/scroll.c dlls/x11drv/scroll.c dl ...

2005-03-28 Thread Rein Klazes
On Sun, 27 Mar 2005 11:34:12 -0500, you wrote: > On Fri, Mar 25, 2005 at 11:11:04AM -0600, Alexandre Julliard wrote: > > Modified files: > > windows: scroll.c > > dlls/x11drv: scroll.c > > dlls/user/tests: win.c msg.c > > > > Log message: > > Rein Klazes <[EMAIL PRO

Re: Wine device drivers proposal

2005-03-28 Thread Damjan Jovanovic
--- Mike McCormack <[EMAIL PROTECTED]> wrote: > > Damjan Jovanovic wrote: > > > I've been trying to add STI (still image) support > to > > Wine, and I've made some progress. However, I see > a > > deep and unsurmountable need to add (at least > > user-space) device drivers to Wine, and I would >

Re: Dragon Naturally Speaking - working.

2005-03-28 Thread Konstantin Goudkov
I got NS7 working on Debian Sid, after running Sidenet setup on Wine 20050310. It took me a while to figure out that I need to raise the Capture level, not just the Mic volume on ALSA. Without it, it looked like NS (and Wine) didn't not pick up the mic even though I could hear myself on the speaker

Re: Wine device drivers proposal

2005-03-28 Thread Marcus Meissner
On Mon, Mar 28, 2005 at 07:52:48PM +0900, Mike McCormack wrote: > > Damjan Jovanovic wrote: > > >I've been trying to add STI (still image) support to > >Wine, and I've made some progress. However, I see a > >deep and unsurmountable need to add (at least > >user-space) device drivers to Wine, and

Re: Wine device drivers proposal

2005-03-28 Thread Mike McCormack
Damjan Jovanovic wrote: I've been trying to add STI (still image) support to Wine, and I've made some progress. However, I see a deep and unsurmountable need to add (at least user-space) device drivers to Wine, and I would like some feedback on these ideas. Drivers belong in the kernel. If there's

Re: Two small scrollbar fixes

2005-03-28 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > dlls/user : scroll.c > dlls/user/tests : win.c > > - GetScrollRange should return an empty range, both upper and lower > limit zero, if the window has no scrollbars (msdn); > - GetScrollInfo's return value is FALSE if the window has no scrollbar

Wine device drivers proposal

2005-03-28 Thread Damjan Jovanovic
Hi I've been trying to add STI (still image) support to Wine, and I've made some progress. However, I see a deep and unsurmountable need to add (at least user-space) device drivers to Wine, and I would like some feedback on these ideas. Basically, many Windows device drivers are really trivial, b