Robert Shearman wrote:
These changes are wrong. IStream_Read can return S_FALSE, which means
that the call was successful, but didn't do what was intended. From MSDN:
S_FALSE
The data cannot be read from the stream object. Depending on the
implementation, either S_FALSE or an error code
Robert Shearman wrote:
How hard would it be to do the work to really fix these FIXMEs? By
changing these to comments I think they are going to be forgotten.
One problem is they are creating FUD for MSI. When people install a
package, they see a stream of FIXME messages, and most of them ar
Hi,
Thanks for the comment, i agree with it but i was thinking than
keeping separated patches was better than (in this case)
merging #2 + #3 + #5 in a big patch.
Any tricks are welcome.
Thanks
Emmanuel
Le 30 déc. 05 à 13:08, Robert Shearman a écrit :
emmanuel maillard wrote:
Changelog
Hi,
Le 30 déc. 05 à 01:39, Markus Amsler a écrit :
Hi,
I took a look at your patches, here's what i've found:
ntdll_cdrom.diff:
#
@ cdecl MODULE_DllThreadAttach(ptr)
@ cdecl MODULE_GetLoadOrderW(ptr wstr wstr)
+@ cdecl CDROM_InitCDDevices()
+@ cdecl CDROM_FoundDevices()
+@ cdecl CDROM_BSDP
On 12/29/05, Joseph Garvin <[EMAIL PROTECTED]> wrote:
> For the audio freeze, try uninstalling arts if you have it. That's what
> seems to cause the freeze on my box. I also get output on the terminal
> saying "unable to create mcop directory."
>
Well in my case it seems to be wineoss.drv based on
Huw D M Davies wrote:
Huw Davies <[EMAIL PROTECTED]>
Add support for rendering on bitmaps
This patch breaks World of Warcraft, reverting this patch makes WoW work
again. This is the error:
X Error of failed request: BadMatch (invalid parameter attributes)
Major opcode of
I'll contact Joachim to get a statement. But plz give us some days...
Sven
Marcus Meissner schrieb:
Could some one from the WineTools project give us a update on our concerns here?
I am not even sure Joachim von Thadden is subscribed here.
Ciao, Marcus
Alexandre Julliard wrote:
Troy Rollo <[EMAIL PROTECTED]> writes:
1. Modify the executable after the link phase;
2. Put what we can into SizeOfImage (which could only be one part of the
calculation - presumably "_end") and adjust at load time; or
3. Don't rely on the assembler to
On Mon, 26 Dec 2005 21:50:54 -, you wrote:
>Glancing through the patch, I see what you are trying to do, and some
>comments (and remember this is just from a glance so far)
>
>1. I'm not sure the MENU_SetItemData for the ownerdraw case is correct as it
>doesn't actually take a copy of the data
emmanuel maillard wrote:
Changelog :
kernel/proces.c : Initialize darwin removable devices
I appreciate you splitting up your patches for easier review, but
patches are meant to be independent atomic changes that improve the
code. However, if Alexandre applied this patch alone then Wine
Mike McCormack wrote:
ChangeLog:
Change some FIXME messages to comments.
How hard would it be to do the work to really fix these FIXMEs? By
changing these to comments I think they are going to be forgotten.
--
Rob Shearman
Mike McCormack wrote:
}
hr=IStream_Read(pStm,header,8,&xread);
- if (hr || xread!=8) {
+ if (FAILED(hr) || xread!=8) {
FIXME("Failure while reading picture header (hr is %lx, nread is
%ld).\n",hr,xread);
return hr;
}
@@ -1128,10 +1128,10 @@ static HRESULT WINAPI OLEPictureIm
Thomas Weidenmueller wrote:
@@ -135,16 +141,16 @@
SL_ITEM_TYPE type, PDOC_ITEM LastItem)
{
PDOC_ITEM Item;
-Item = Alloc(sizeof(DOC_ITEM) + ((textlen + 1) * sizeof(WCHAR)));
+
+textlen = min(textlen, lstrlenW(Text));
+Item = Alloc(FIELD_OFF
> ChangeLog:
>
> Added support for "Use PRIMARY selection" clipboard option.
One question: Why not make this the default? This would be the unix way to use
the clipboard. Or use the primary selection on a middle mouse button click,
and the other clipboard value on paste / CTRL-V? This is the beha
Troy Rollo <[EMAIL PROTECTED]> writes:
> 1. Modify the executable after the link phase;
> 2. Put what we can into SizeOfImage (which could only be one part of the
> calculation - presumably "_end") and adjust at load time; or
> 3. Don't rely on the assembler to put anything meaningful in there an
> For the audio freeze, try uninstalling arts if you have it. That's what
> seems to cause the freeze on my box. I also get output on the terminal
> saying "unable to create mcop directory."
>
Hi,
I'm running FC4 and had the same issue with the mcop directory message.
This was introduced by either
> Could some one from the WineTools project give us a update on our concerns
> here?
I am not even sure Joachim von Thadden is subscribed here.
Ciao, Marcus
Hello Everyone,
Anyone who reads the posting on this list already knows that I stood up for
the wineTools project and almost made a couple enemies... But me and Vitaliy
came to a half way agreement on whether or not we should keep the link
on our downloads page to WineTools
I feel I need to a
Dan Kegel wrote:
The riched20 test app described in
http://bugs.winehq.com/show_bug.cgi?id=4190
seems to require the patch
http://kegel.com/wine/pr4190.patch
which adds support for invoking functions with 15 or 16 parameters.
This is similar to the first patch in
http://bugs.winehq.com/show_bug.
19 matches
Mail list logo
