RFC: XEmbed Systray Patches

2006-08-14 Thread James Liggett
Hi Everyone, First, I'd like to apologize for sending those tarballs to wine-devel, as I've just been advised on IRC that such a practice discourages reviews. I've attached a text version of the patches in the hopes that it will get some more exposure. Again, sorry for the trouble. :) James >Fro

Re: RFC: XEmbed Systray Patches

2006-08-14 Thread James Liggett
On Wed, 2006-08-09 at 13:30 -0700, James Liggett wrote: > > also a problem where a window would dock but only be allocated 1 > > pixel, I think that was a bug in GNOME that is now fixed. > I'm not quite sure about that one--I've got an X test app that docks, > but I can only get 1 pixel wide. :( O

Re: [meta-bug] I can not contact Jeremy Newman

2006-08-14 Thread Jeremy White
> Please address your comments to the folks that maintain Wine's Bugzilla. Gah. Was typing in a hurry, and hit send before I could add one more piece I wanted to add, which was: It would be really helpful if you could add a constructive comment. So, for example, if you could download and install

Re: [meta-bug] I can not contact Jeremy Newman

2006-08-14 Thread Jeremy White
Jérôme, Jeremy Newman does *not* maintain Bugzilla; there is a community of volunteers that do that. If he had his way, Bugzilla would be ripped out and burned to the ground. Please address your comments to the folks that maintain Wine's Bugzilla. Cheers, Jeremy Jérôme Bouat wrote: > Hello, >

Re: All right, let's solve these .desktop issues forever

2006-08-14 Thread Mikołaj Zalewski
I was investigating the menu problems and now I'm back so I could try to fix it. The problem is with the support for the new freedesktop.org standard. In it the /usr/share/applications and ~/.local/share/applications contains a flat list of applications while the menu structure is controlled b

[meta-bug] I can not contact Jeremy Newman

2006-08-14 Thread Jérôme Bouat
Hello, I can not reach Jeremy Newman. I hope he goes well. A very important bug still exist for years but its bugzilla issue gets no response at all : http://bugs.winehq.org/show_bug.cgi?id=5202 Please, say something (i.e. WONTFIX, INVALID, LATER, ...). I hope someone will respond. Thanks.

Re: USER: SystemParametersInfo fixes

2006-08-14 Thread Alexandre Julliard
Frank Richter <[EMAIL PROTECTED]> writes: > Subject: [PATCH] USER: Fix SPI_SETICONTITLELOGFONT to check for LOGFONTW size > [...] > Subject: [PATCH] USER: initialize size of nonclients struct in > load_nonclient_metrics Please don't attach multiple patches, each patch should be a separate mail.

Re: WineD3D: add rgb24 colorkey conversion

2006-08-14 Thread Alexandre Julliard
"Roderick Colenbrander" <[EMAIL PROTECTED]> writes: > +for (x = 0; x < len; x++) { > +/* Retrieve RGB24 color */ > +DWORD color = *((DWORD*)src); > +/* Store the RGB portion in dest and reserve a byte for > alpha */ > +*D

Re: secur32: Fix heap error.

2006-08-14 Thread Kai Blin
On Monday 14 August 2006 11:57, Kai Blin wrote: > --- > dlls/secur32/dispatcher.c |1 - > dlls/secur32/ntlm.c |1 + > 2 files changed, 1 insertions(+), 1 deletions(-) Sorry, this one is obviously a typo. Sending a new one. Kai -- Kai Blin, WorldForge developerhttp://www.world

Re: secur32: Clean up AcceptSecurityContext (reduce indent and duplication).

2006-08-14 Thread Kai Blin
On Sunday 13 August 2006 14:44, Kai Blin wrote: > --- > dlls/secur32/ntlm.c | 372 > ++- > 1 files changed, 164 insertions(+), 208 deletions(-) After sending in the fixes for my "Make AcceptSecurityContext behaviour consistent with Windows, try2"

Re: secur32: Make AcceptSecurityContext behaviour consistent withWindows.

2006-08-14 Thread Kai Blin
On Monday 14 August 2006 08:52, Dmitry Timoshkov wrote: > "Kai Blin" <[EMAIL PROTECTED]> wrote: > > phNewContext->dwUpper = ctxt_attr; > > -phNewContext->dwLower = ret; > > +phNewContext->dwLower = (DWORD)helper; > > You need to cast to ULONG_PTR to make the code 64-bit saf

Re: RFC: OpenGL x11drv rewrite (WoW fix)

2006-08-14 Thread Stefan Dösinger
Hi, > I think the patch is a correct fix for the BadMatch / ChoosePixelFormat > issues. The patch isn't 100% complete yet as I haven't updated the WGL > extensions for pbuffer and wglChoosePixelFormat to work with the new > pixelformats yet (that's why you see a line WoW hack). I will fix that part

RFC: OpenGL x11drv rewrite (WoW fix)

2006-08-14 Thread Roderick Colenbrander
Hi, Since the WM rewrite we can only use the visual which was created by x11drv at x11drv initialization. In general this is a simple 32bit RGBA visual or when that's not available it is some 16bit visual. The problem is that the opengl code advertises more formats than this single format. The

Re: Is anyone going to or presenting at Linuxworld?

2006-08-14 Thread Jeremy White
Scott Ritchie wrote: > Linuxworldexpo is this week. Since no one's mentioned it yet, I'm > assuming that we don't have a booth or speech planned :) > > http://www.linuxworldexpo.com/live/12/events/12SFO06A > > At any rate, perhaps we should be going to things like this. There's > usually a conv

Re: resend add missing glyph code to GetGlyphIndices

2006-08-14 Thread Jeff Latimer
Andreas Mohr wrote: This should have gone into a comment right there because it's a very normal reaction to immediately question code like that, so the code should properly defend itself by default ;) IOW just the usual "do coding as obvious as possible, then properly comment everything else th

Re: resend add missing glyph code to GetGlyphIndices

2006-08-14 Thread Andreas Mohr
Hi, On Mon, Aug 14, 2006 at 06:49:00PM +1000, Jeff Latimer wrote: > Dmitry Timoshkov wrote: > >I'd suggest to move GetTextMetricsW outside of the loop to not kill > >the performance. > > I put it inside the loop as I assumed that a non existent glyph would > be relatively rare and the call wo

Re: resend add missing glyph code to GetGlyphIndices

2006-08-14 Thread Jeff Latimer
Dmitry Timoshkov wrote: "Jeff L" <[EMAIL PROTECTED]> wrote: +DWORD WineEngGetGlyphIndices(HDC hdc, GdiFont font, LPCWSTR lpstr, INT count, LPWORD pgi, DWORD flags) { INT i; - +TEXTMETRICW textm; for(i = 0; i < count; i++) +{ pgi[i] = get_glyph_index(font, lpstr[i]); -

Re: gdi: Implement GetFontUnicodeRanges.

2006-08-14 Thread Hans Leidekker
On Monday 14 August 2006 00:48, Huw Davies wrote: > I wonder whether FcFreeTypeCharSet is what you really want here. It > uses a lot of heuristics which almost certainly won't match what > Windows does, so we're probably better off writing our own. A test > (on say Arial) would be useful here!

Re: resend add missing glyph code to GetGlyphIndices

2006-08-14 Thread Dmitry Timoshkov
"Jeff L" <[EMAIL PROTECTED]> wrote: -DWORD WineEngGetGlyphIndices(GdiFont font, LPCWSTR lpstr, INT count, + * */ Strange indentation at the end of a comment. +DWORD WineEngGetGlyphIndices(HDC hdc, GdiFont font, LPCWSTR lpstr, INT count, LPWORD pgi, DWORD flags) { INT i; - +TEXTMETRI