On 28/11/06, Markus Amsler [EMAIL PROTECTED] wrote:
One problem is, half of the AddRef patches were commited. Before
reverting them, I thought I send the rest again. The other problem is
the AddRef in GetParent is ugly, because it AddRefs on a d3dx object. We
should do d3dx refcounting only in
H. Verbeet [EMAIL PROTECTED] writes:
As for the previous patches, I was under the impression at the time
that the idea was to get rid of COM in wined3d, otherwise I would have
said something earlier. For consistency it would probably be best if
they were reverted.
That was my impression too,
Am Dienstag 28 November 2006 00:48 schrieb H. Verbeet:
I thought we discussed on IRC why this is a bad idea? Anyway, you
can't do this. Removing the AddRef in QueryInterface is a pretty
blatant violation of COM specs, and is pretty sure to cause problems
somewhere. The caller of that function
Am Montag 27 November 2006 11:23 schrieb Christoph Bumiller:
This is my first patch - I was trying an old game with wine
(Starfleet Academy), which crashed when using D3D, and I got the
following trace messages:
trace:ddraw_thunk:Thunk_IDirect3DDeviceImpl_1_AddViewport
(0x1b440c)-(0x1f44f0)
On 28/11/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
H. Verbeet [EMAIL PROTECTED] writes:
As for the previous patches, I was under the impression at the time
that the idea was to get rid of COM in wined3d, otherwise I would have
said something earlier. For consistency it would probably
On Mon, Nov 27, 2006 at 12:51:03PM -0600, Alexandre Julliard wrote:
Module: wine
Branch: master
Commit: da3676229722eb76c8a91bf8165b09cc9e58455c
URL:
http://source.winehq.org/git/wine.git/?a=commit;h=da3676229722eb76c8a91bf8165b09cc9e58455c
Author: Vitaliy Margolen [EMAIL PROTECTED]
Stefan Dösinger wrote:
Am Dienstag 28 November 2006 00:48 schrieb H. Verbeet:
I thought we discussed on IRC why this is a bad idea? Anyway, you
can't do this. Removing the AddRef in QueryInterface is a pretty
blatant violation of COM specs, and is pretty sure to cause problems
somewhere. The
Alexandre Julliard wrote:
H. Verbeet [EMAIL PROTECTED] writes:
As for the previous patches, I was under the impression at the time
that the idea was to get rid of COM in wined3d, otherwise I would have
said something earlier. For consistency it would probably be best if
they were reverted.
On 28.11.2006 09:48, H. Verbeet wrote:
Another issue that comes up when trying to mix eg a software vertex
shader with a hardware pixel shader is that you can't actually pass
varyings from the software vertex shader to the hardware pixel shader.
As far as I remember the fixed function pipeline
On 28/11/06, Frank Richter [EMAIL PROTECTED] wrote:
On 28.11.2006 09:48, H. Verbeet wrote:
Another issue that comes up when trying to mix eg a software vertex
shader with a hardware pixel shader is that you can't actually pass
varyings from the software vertex shader to the hardware pixel
Am Dienstag 28 November 2006 13:18 schrieben Sie:
Stefan Dösinger wrote:
Am Dienstag 28 November 2006 00:48 schrieb H. Verbeet:
I thought we discussed on IRC why this is a bad idea? Anyway, you
can't do this. Removing the AddRef in QueryInterface is a pretty
blatant violation of COM
Markus Amsler [EMAIL PROTECTED] writes:
I wasn't fully aware of the importance of the COM refcount rules, just
saw the opportunity for simplification. For removing COM it would be
probably better to start with removing the lpVtbl's. I agree it's
probably best to revert them for consistency.
Kai Blin [EMAIL PROTECTED] wrote:
+static void test_extendedSocketOptions()
+{
+WSADATA wsa;
+SOCKET sock;
+struct sockaddr_in sa;
+int sa_len = sizeof(struct sockaddr_in);
+ULONG optval, optlen = sizeof(ULONG);
Why to use ULONG if what you later cast it to is 'int *', and
Am Dienstag 28 November 2006 16:55 schrieb Alexandre Julliard:
Markus Amsler [EMAIL PROTECTED] writes:
I wasn't fully aware of the importance of the COM refcount rules, just
saw the opportunity for simplification. For removing COM it would be
probably better to start with removing the
On Tuesday 28 November 2006 17:05, Dmitry Timoshkov wrote:
Kai Blin [EMAIL PROTECTED] wrote:
+static void test_extendedSocketOptions()
+{
+WSADATA wsa;
+SOCKET sock;
+struct sockaddr_in sa;
+int sa_len = sizeof(struct sockaddr_in);
+ULONG optval, optlen =
Stefan Dösinger wrote:
I proposed getting rid of COM some time ago, but I didn't consider that we
need some features like inheritance.
I think we should keep COM, but get rid of the D3D-Specific Addrefs because
they are different between the various versions d3d versions. So keep the
AddRef
Anybody have time to help triage an install problem?
Sunbird (and FireFox 2) installs run in an endless loop for some people.
If you have time to try the install out and see if it works on your
system, then comment on bug 6613, it would help out.
http://bugs.winehq.org/show_bug.cgi?id=6613
17 matches
Mail list logo
