Re: appdb rating inflation

2007-01-05 Thread Vitaliy Margolen
Dan Kegel wrote: > The appdb says > "Only applications which install and run flawlessly on an out-of-the-box > Wine installation make it to the Platinum list" > But several platinum-rated apps seem to deserve > a silver or bronze rating. I think what we should have is: [Platinum] Entire program run

Re: msacm32: Fix greater than vs. less than typo in comparison. (Coverity)

2007-01-05 Thread Kai Blin
On Friday 05 January 2007 19:00, Alex Villací­s Lasso wrote: > This is not a typo, but rather an unnecessary verification, from when I > didn't know the true size of a DRVCONFIGINFO. The struct size should be > *exactly 16 bytes*, even though only the first 12 bytes are used. This > patch might ev

Re: Is Evolution the pile of .... it seems to be!

2007-01-05 Thread Vitaliy Margolen
Bill Medland wrote: > Does anyone doing OSS use evolution? > > I'm trying to submit a patch but can I get Evolution to not wrap it? No. Like with any e-mail client - attach the patch, preferably as plain text Vitaliy.

Re: Is Evolution the pile of .... it seems to be!

2007-01-05 Thread Robert Shearman
Bill Medland wrote: Does anyone doing OSS use evolution? I'm trying to submit a patch but can I get Evolution to not wrap it? No. I swapped from kmail to Evolution on the basis that it seemed to be being pushed as the 'real' linux mail program but I just keep being infuriated by the basic thing

Is Evolution the pile of .... it seems to be!

2007-01-05 Thread Bill Medland
Does anyone doing OSS use evolution? I'm trying to submit a patch but can I get Evolution to not wrap it? No. I swapped from kmail to Evolution on the basis that it seemed to be being pushed as the 'real' linux mail program but I just keep being infuriated by the basic things it doesn't do and it

Re: appdb rating inflation

2007-01-05 Thread Kari Hurtta
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes in gmane.comp.emulators.wine.devel: > Onsdag 03 januar 2007 21:46, skrev Kari Hurtta: > > "Chris Morgan" <[EMAIL PROTECTED]> writes in > gmane.comp.emulators.wine.devel: > > > On 03 Jan 2007 16:34:21 +0200, Kari Hurtta <[EMAIL PROTECTED]> >

re: Instructions for creating the tests directory

2007-01-05 Thread Bill Medland
On Fri, 2007-05-01 at 10:46 -0800, Dan Kegel wrote: > Bill wrote: > > Is there any documentation on how to set up the tests directory for an > > existing dll? > > Good question. Last time this came up, the answer was recorded here: > > http://kerneltraffic.osmirror.nl/wine/wn20021011_139.html#3

Re: appdb rating inflation

2007-01-05 Thread Remco
What about a checklist of problems it doesn't have, and basing the rating on that. Something like: Installation: (_) Installs correctly. (_) No installation nessecary to run. (_) Preinstalled on Windows. (x) Doesn't install. [_] Works without an unofficially patched Wine. [_] Works without a co

Re: Instructions for creating the tests directory

2007-01-05 Thread Alexandre Julliard
Bill Medland <[EMAIL PROTECTED]> writes: > Is there any documentation on how to set up the tests directory for an > existing dll? I couldn't see anything about the tests directory in the > wiki and the stuff in the developer's guide presupposes that the test > directory exists. These days all yo

Re: Instructions for creating the tests directory

2007-01-05 Thread Lei Zhang
On 1/5/07, Dan Kegel <[EMAIL PROTECTED]> wrote: Bill wrote: > Is there any documentation on how to set up the tests directory for an > existing dll? Good question. Last time this came up, the answer was recorded here: http://kerneltraffic.osmirror.nl/wine/wn20021011_139.html#3 I don't know if

Re: Instructions for creating the tests directory

2007-01-05 Thread Paul Vriens
On Fri, 2007-01-05 at 10:33 -0800, Bill Medland wrote: > Is there any documentation on how to set up the tests directory for an > existing dll? I couldn't see anything about the tests directory in the > wiki and the stuff in the developer's guide presupposes that the test > directory exists. > >

re: Instructions for creating the tests directory

2007-01-05 Thread Dan Kegel
Bill wrote: Is there any documentation on how to set up the tests directory for an existing dll? Good question. Last time this came up, the answer was recorded here: http://kerneltraffic.osmirror.nl/wine/wn20021011_139.html#3 I don't know if that's correct still, but it's a start. Can you up

Instructions for creating the tests directory

2007-01-05 Thread Bill Medland
Is there any documentation on how to set up the tests directory for an existing dll? I couldn't see anything about the tests directory in the wiki and the stuff in the developer's guide presupposes that the test directory exists. I would rather follow instructions than have to reverse-engineer th

Re: msacm32: Fix greater than vs. less than typo in comparison. (Coverity)

2007-01-05 Thread Alex Villací­s Lasso
Kai Blin escribió: --- dlls/msacm32/driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c index d4ad644..06e6614 100644 --- a/dlls/msacm32/drive

Re: mcicda: How can we get STATUS_XXX in GetLastError()?

2007-01-05 Thread Eric Pouech
Francois Gouget a écrit : In dlls/mcicda/mcicda.c we have: if (!DeviceIoControl(wmcda->handle, IOCTL_CDROM_READ_Q_CHANNEL, &fmt, sizeof(fmt), &data, sizeof(data), &br, NULL)) { if (GetLastError() == STATUS_NO_MEDIA_IN_DEVICE) mode = MCI_MODE_OPEN; Howeve

Re: rpc issues

2007-01-05 Thread Robert Shearman
Matthew Edlefsen wrote: When using RpcServerUseProtseq on Windows, according to msdn, "the port number is dynamically determined by the RPC run time, depending on availability and registry settings." If that's the case how does the client know what port to connect to? Since I'm using RpcSer

Re: winegcc: Fix memory leaks (Coverity)

2007-01-05 Thread Andrew Talbot
Alexandre Julliard wrote: > There is no reason to add a lot of complexity to fix leaks in > short-lived apps like winegcc. > Acknowledged. Thanks, -- Andy.

Re: rpc issues

2007-01-05 Thread Matthew Edlefsen
On 1/3/07, Damjan Jovanovic <[EMAIL PROTECTED]> wrote: On 1/4/07, Matthew Edlefsen <[EMAIL PROTECTED]> wrote: > > > On 1/2/07, Damjan Jovanovic <[EMAIL PROTECTED]> wrote: > > On 1/1/07, Matthew Edlefsen <[EMAIL PROTECTED]> wrote: > > > Hi, I've been trying to get a program that uses rpc to work

Re: winegcc: Fix memory leaks (Coverity)

2007-01-05 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Changelog: > winegcc: Fix memory leaks (Coverity). There is no reason to add a lot of complexity to fix leaks in short-lived apps like winegcc. -- Alexandre Julliard [EMAIL PROTECTED]

Re: ole32: Remove redundant NULL check. (Coverity)

2007-01-05 Thread Kai Blin
On Friday 05 January 2007 17:38, Kai Blin wrote: > On Friday 05 January 2007 12:00, Kai Blin wrote: > > --- > > dlls/ole32/ole2.c | 10 +- > > 1 files changed, 1 insertions(+), 9 deletions(-) > > Please ignore this one, winehq being down and git-format-patches played a > trick on me. :)

Re: ole32: Remove redundant NULL check. (Coverity)

2007-01-05 Thread Kai Blin
On Friday 05 January 2007 12:00, Kai Blin wrote: > --- > dlls/ole32/ole2.c | 10 +- > 1 files changed, 1 insertions(+), 9 deletions(-) Please ignore this one, winehq being down and git-format-patches played a trick on me. :) Kai -- Kai Blin, WorldForge developerhttp://www.world

RFC: wininet: Inconsistent use of INTERNET_SetLastError()

2007-01-05 Thread Francois Gouget
wininet has an INTERNET_SetLastError() which calls SetLastError() and does some extra tricks (see dlls/wininet/internet.c:3041). The problem is that while most functions use it, some call SetLastError() directly, seemingly without pattern or reason. Some functions even call one or the other de

Re: mcicda: How can we get STATUS_XXX in GetLastError()?

2007-01-05 Thread Hans Leidekker
On Friday 05 January 2007 13:03, Francois Gouget wrote: > And RtlNtStatusToDosError() converts STATUS_NO_MEDIA_IN_DEVICE to > ERROR_NOT_READY. So GetLastError() cannot return > STATUS_NO_MEDIA_IN_DEVICE. Or did I miss something? Maybe the right > thing would be to check the return value of Devi

Re: IDropTarget code location

2007-01-05 Thread Robert Shearman
Jeff L wrote: Can anyone point me the location of the code that implements the IDropTarget class used by OLE2? There isn't one location - it depends on what you're dropping an object into. The most common object to drag&drop is a file though, so you might want to look in dlls/shell32. -- Ro

Re: rpc issues

2007-01-05 Thread Damjan Jovanovic
Pretty sure. The only reason I say that is that when I test it I have to change to the port every test because if I don't it says the port is in use (I guess the program isn't closing the port or something). Honestly I still don't fully understand how rpc finds the port number, which may be the

Re: Winelib over Solaris/SPARC

2007-01-05 Thread Eric Frias
Keyur Pujara wrote: I am contemplating to port a complex windows application using winelib over Solaris/SPARC. In one of the emails in wine-devel list, I saw that there may be following issues in the process: * byte endianness * alignment issues * pointer size * must not use x86 assembly Co

mcicda: How can we get STATUS_XXX in GetLastError()?

2007-01-05 Thread Francois Gouget
In dlls/mcicda/mcicda.c we have: if (!DeviceIoControl(wmcda->handle, IOCTL_CDROM_READ_Q_CHANNEL, &fmt, sizeof(fmt), &data, sizeof(data), &br, NULL)) { if (GetLastError() == STATUS_NO_MEDIA_IN_DEVICE) mode = MCI_MODE_OPEN; However DeviceIoControl() does th